From: Amos Kong <akong@redhat.com>
To: virtualization@lists.linux-foundation.org
Cc: herbert@gondor.apana.org.au, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, m@bues.ch, mpm@selenic.com,
amit.shah@redhat.com
Subject: [PATCH v2 5/6] hw_random: don't double-check old_rng.
Date: Thu, 18 Sep 2014 20:37:46 +0800 [thread overview]
Message-ID: <1411043867-21109-6-git-send-email-akong@redhat.com> (raw)
In-Reply-To: <1411043867-21109-1-git-send-email-akong@redhat.com>
From: Rusty Russell <rusty@rustcorp.com.au>
Interesting anti-pattern.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---
drivers/char/hw_random/core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
index 9f6f5bb..6420409 100644
--- a/drivers/char/hw_random/core.c
+++ b/drivers/char/hw_random/core.c
@@ -473,14 +473,13 @@ int hwrng_register(struct hwrng *rng)
}
old_rng = current_rng;
+ err = 0;
if (!old_rng) {
err = hwrng_init(rng);
if (err)
goto out_unlock;
set_current_rng(rng);
- }
- err = 0;
- if (!old_rng) {
+
err = register_miscdev();
if (err) {
drop_current_rng();
--
1.9.3
next prev parent reply other threads:[~2014-09-18 12:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 12:37 [PATCH v2 0/6] fix hw_random stuck Amos Kong
2014-09-18 12:37 ` [PATCH v2 1/6] hw_random: place mutex around read functions and buffers Amos Kong
2014-09-18 12:37 ` [PATCH v2 2/6] hw_random: move some code out mutex_lock for avoiding underlying deadlock Amos Kong
2014-09-18 12:37 ` [PATCH v2 3/6] hw_random: use reference counts on each struct hwrng Amos Kong
2014-09-18 12:37 ` [PATCH v2 4/6] hw_random: fix unregister race Amos Kong
2014-10-21 14:17 ` Herbert Xu
2014-10-30 23:58 ` Rusty Russell
2014-10-31 7:23 ` Herbert Xu
2014-11-02 15:06 ` Amos Kong
2014-11-02 15:08 ` Herbert Xu
2014-11-02 15:14 ` Amos Kong
2014-09-18 12:37 ` Amos Kong [this message]
2014-09-18 12:37 ` [PATCH v2 6/6] hw_random: don't init list element we're about to add to list Amos Kong
[not found] ` <1411043867-21109-4-git-send-email-akong@redhat.com>
2014-09-18 17:08 ` [PATCH v2 3/6] hw_random: use reference counts on each struct hwrng Amos Kong
2014-10-20 0:12 ` Rusty Russell
[not found] ` <871tq3a9b8.fsf@rustcorp.com.au>
2014-10-20 3:58 ` Amos Kong
2014-10-20 0:08 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411043867-21109-6-git-send-email-akong@redhat.com \
--to=akong@redhat.com \
--cc=amit.shah@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m@bues.ch \
--cc=mpm@selenic.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).