From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: [PATCH v2 00/15] virtio: fix spec compliance issues
Date: Mon, 6 Oct 2014 18:10:37 +0300 [thread overview]
Message-ID: <1412608214-31944-1-git-send-email-mst@redhat.com> (raw)
Rusty, I have a mind to include this patchset for this merge window.
Any input on this?
This fixes the following virtio spec compliance issues:
1. on restore, drivers use device before setting ACKNOWLEDGE and DRIVER bits
2. on probe, drivers aren't prepared to handle config interrupts
arriving before probe returns
3. on probe, drivers use device before DRIVER_OK it set
Note that 1 is a clear violation of virtio spec 0.9 and 1.0,
so I am proposing the fix for stable. OTOH 2 is against 1.0 rules but
is a known documented bug in many drivers, so let's fix it going
forward, but it does not seem to be worth it to backport
the changes.
An error handling bugfix for virtio-net is also included.
2 is merely a theoretical race condition, but it seems important
to address to make sure that changes to address 3 do not introduce
instability.
Michael S. Tsirkin (15):
virtio_pci: fix virtio spec compliance on restore
virtio: unify config_changed handling
virtio-pci: move freeze/restore to virtio core
virtio: defer config changed notifications
virtio_blk: drop config_enable
virtio-blk: drop config_mutex
virtio_net: drop config_enable
virtio-net: drop config_mutex
virtio_net: minor cleanup
virtio: add API to enable VQs early
virtio_net: enable VQs early
virtio_blk: enable VQs early
virtio_console: enable VQs early
9p/trans_virtio: enable VQs early
virtio_net: fix use after free on allocation failure
include/linux/virtio.h | 14 +++++
include/linux/virtio_config.h | 17 +++++++
drivers/block/virtio_blk.c | 31 ++----------
drivers/char/virtio_console.c | 2 +
drivers/misc/mic/card/mic_virtio.c | 6 +--
drivers/net/virtio_net.c | 42 ++++-----------
drivers/s390/kvm/kvm_virtio.c | 9 +---
drivers/s390/kvm/virtio_ccw.c | 6 +--
drivers/virtio/virtio.c | 101 +++++++++++++++++++++++++++++++++++++
drivers/virtio/virtio_mmio.c | 7 +--
drivers/virtio/virtio_pci.c | 33 ++----------
net/9p/trans_virtio.c | 2 +
12 files changed, 159 insertions(+), 111 deletions(-)
--
MST
next reply other threads:[~2014-10-06 15:10 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 15:10 Michael S. Tsirkin [this message]
2014-10-06 15:10 ` [PATCH v2 01/15] virtio_pci: fix virtio spec compliance on restore Michael S. Tsirkin
2014-10-07 12:05 ` Amit Shah
2014-10-07 12:51 ` Michael S. Tsirkin
2014-10-07 12:53 ` Michael S. Tsirkin
2014-10-07 16:54 ` Amit Shah
2014-10-06 15:10 ` [PATCH v2 02/15] virtio: unify config_changed handling Michael S. Tsirkin
2014-10-06 15:16 ` Cornelia Huck
2014-10-06 15:10 ` [PATCH v2 03/15] virtio-pci: move freeze/restore to virtio core Michael S. Tsirkin
2014-10-06 15:20 ` Cornelia Huck
2014-10-06 15:26 ` Michael S. Tsirkin
2014-10-06 15:34 ` Cornelia Huck
2014-10-06 15:10 ` [PATCH v2 04/15] virtio: defer config changed notifications Michael S. Tsirkin
2014-10-06 15:25 ` Cornelia Huck
2014-10-06 15:10 ` [PATCH v2 05/15] virtio_blk: drop config_enable Michael S. Tsirkin
2014-10-06 15:26 ` Cornelia Huck
2014-10-06 15:11 ` [PATCH v2 06/15] virtio-blk: drop config_mutex Michael S. Tsirkin
2014-10-06 15:11 ` [PATCH v2 07/15] virtio_net: drop config_enable Michael S. Tsirkin
2014-10-06 15:11 ` [PATCH v2 08/15] virtio-net: drop config_mutex Michael S. Tsirkin
2014-10-06 15:11 ` [PATCH v2 09/15] virtio_net: minor cleanup Michael S. Tsirkin
2014-10-06 15:11 ` [PATCH v2 10/15] virtio: add API to enable VQs early Michael S. Tsirkin
2014-10-06 15:29 ` Cornelia Huck
2014-10-06 15:11 ` [PATCH v2 11/15] virtio_net: " Michael S. Tsirkin
2014-10-06 15:11 ` [PATCH v2 12/15] virtio_blk: " Michael S. Tsirkin
2014-10-06 15:42 ` Cornelia Huck
2014-10-06 15:11 ` [PATCH v2 13/15] virtio_console: " Michael S. Tsirkin
2014-10-06 15:11 ` [PATCH v2 14/15] 9p/trans_virtio: " Michael S. Tsirkin
2014-10-06 15:11 ` [PATCH v2 15/15] virtio_net: fix use after free on allocation failure Michael S. Tsirkin
[not found] ` <1412608214-31944-8-git-send-email-mst@redhat.com>
2014-10-06 15:28 ` [PATCH v2 07/15] virtio_net: drop config_enable Cornelia Huck
[not found] ` <1412608214-31944-12-git-send-email-mst@redhat.com>
2014-10-06 15:39 ` [PATCH v2 11/15] virtio_net: enable VQs early Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412608214-31944-1-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).