From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: [PATCH v2 10/15] virtio: add API to enable VQs early
Date: Mon, 6 Oct 2014 18:11:16 +0300 [thread overview]
Message-ID: <1412608214-31944-11-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1412608214-31944-1-git-send-email-mst@redhat.com>
virtio spec 0.9.X requires DRIVER_OK to be set before
VQs are used, but some drivers use VQs before probe
function returns.
Since DRIVER_OK is set after probe, this violates the spec.
Even though under virtio 1.0 transitional devices support this
behaviour, we want to make it possible for those early callers to become
spec compliant and eventually support non-transitional devices.
Add API for drivers to call before using VQs.
Sets DRIVER_OK internally.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/linux/virtio_config.h | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h
index e8f8f71..e36403b 100644
--- a/include/linux/virtio_config.h
+++ b/include/linux/virtio_config.h
@@ -109,6 +109,23 @@ struct virtqueue *virtio_find_single_vq(struct virtio_device *vdev,
return vq;
}
+/**
+ * virtio_enable_vqs_early - enable vq use in probe function
+ * @vdev: the device
+ *
+ * Driver must call this to use vqs in the probe function.
+ *
+ * Note: vqs are enabled automatically after probe returns.
+ */
+static inline
+void virtio_enable_vqs_early(struct virtio_device *dev)
+{
+ unsigned status = dev->config->get_status(dev);
+
+ BUG_ON(status & VIRTIO_CONFIG_S_DRIVER_OK);
+ dev->config->set_status(dev, status | VIRTIO_CONFIG_S_DRIVER_OK);
+}
+
static inline
const char *virtio_bus_name(struct virtio_device *vdev)
{
--
MST
next prev parent reply other threads:[~2014-10-06 15:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 15:10 [PATCH v2 00/15] virtio: fix spec compliance issues Michael S. Tsirkin
2014-10-06 15:10 ` [PATCH v2 01/15] virtio_pci: fix virtio spec compliance on restore Michael S. Tsirkin
2014-10-07 12:05 ` Amit Shah
2014-10-07 12:51 ` Michael S. Tsirkin
2014-10-07 12:53 ` Michael S. Tsirkin
2014-10-07 16:54 ` Amit Shah
2014-10-06 15:10 ` [PATCH v2 02/15] virtio: unify config_changed handling Michael S. Tsirkin
2014-10-06 15:16 ` Cornelia Huck
2014-10-06 15:10 ` [PATCH v2 03/15] virtio-pci: move freeze/restore to virtio core Michael S. Tsirkin
2014-10-06 15:20 ` Cornelia Huck
2014-10-06 15:26 ` Michael S. Tsirkin
2014-10-06 15:34 ` Cornelia Huck
2014-10-06 15:10 ` [PATCH v2 04/15] virtio: defer config changed notifications Michael S. Tsirkin
2014-10-06 15:25 ` Cornelia Huck
2014-10-06 15:10 ` [PATCH v2 05/15] virtio_blk: drop config_enable Michael S. Tsirkin
2014-10-06 15:26 ` Cornelia Huck
2014-10-06 15:11 ` [PATCH v2 06/15] virtio-blk: drop config_mutex Michael S. Tsirkin
2014-10-06 15:11 ` [PATCH v2 07/15] virtio_net: drop config_enable Michael S. Tsirkin
2014-10-06 15:11 ` [PATCH v2 08/15] virtio-net: drop config_mutex Michael S. Tsirkin
2014-10-06 15:11 ` [PATCH v2 09/15] virtio_net: minor cleanup Michael S. Tsirkin
2014-10-06 15:11 ` Michael S. Tsirkin [this message]
2014-10-06 15:29 ` [PATCH v2 10/15] virtio: add API to enable VQs early Cornelia Huck
2014-10-06 15:11 ` [PATCH v2 11/15] virtio_net: " Michael S. Tsirkin
2014-10-06 15:11 ` [PATCH v2 12/15] virtio_blk: " Michael S. Tsirkin
2014-10-06 15:42 ` Cornelia Huck
2014-10-06 15:11 ` [PATCH v2 13/15] virtio_console: " Michael S. Tsirkin
2014-10-06 15:11 ` [PATCH v2 14/15] 9p/trans_virtio: " Michael S. Tsirkin
2014-10-06 15:11 ` [PATCH v2 15/15] virtio_net: fix use after free on allocation failure Michael S. Tsirkin
[not found] ` <1412608214-31944-8-git-send-email-mst@redhat.com>
2014-10-06 15:28 ` [PATCH v2 07/15] virtio_net: drop config_enable Cornelia Huck
[not found] ` <1412608214-31944-12-git-send-email-mst@redhat.com>
2014-10-06 15:39 ` [PATCH v2 11/15] virtio_net: enable VQs early Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412608214-31944-11-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).