From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: David Hildenbrand <dahi@linux.vnet.ibm.com>,
virtualization@lists.linux-foundation.org
Subject: [PATCH RFC v2 07/16] virtio_config: endian conversion for v1.0
Date: Wed, 22 Oct 2014 18:50:40 +0300 [thread overview]
Message-ID: <1413992894-22976-8-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1413992894-22976-1-git-send-email-mst@redhat.com>
We (ab)use virtio conversion functions for device-specific
config space accesses.
Reviewed-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/linux/virtio_config.h | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h
index be0f6dd..09cd89c 100644
--- a/include/linux/virtio_config.h
+++ b/include/linux/virtio_config.h
@@ -255,12 +255,13 @@ static inline u16 virtio_cread16(struct virtio_device *vdev,
{
u16 ret;
vdev->config->get(vdev, offset, &ret, sizeof(ret));
- return ret;
+ return virtio16_to_cpu(vdev, (__force __virtio16)ret);
}
static inline void virtio_cwrite16(struct virtio_device *vdev,
unsigned int offset, u16 val)
{
+ val = (__force u16)cpu_to_virtio16(vdev, val);
vdev->config->set(vdev, offset, &val, sizeof(val));
}
@@ -269,12 +270,13 @@ static inline u32 virtio_cread32(struct virtio_device *vdev,
{
u32 ret;
vdev->config->get(vdev, offset, &ret, sizeof(ret));
- return ret;
+ return virtio32_to_cpu(vdev, (__force __virtio32)ret);
}
static inline void virtio_cwrite32(struct virtio_device *vdev,
unsigned int offset, u32 val)
{
+ val = (__force u32)cpu_to_virtio32(vdev, val);
vdev->config->set(vdev, offset, &val, sizeof(val));
}
@@ -283,12 +285,13 @@ static inline u64 virtio_cread64(struct virtio_device *vdev,
{
u64 ret;
vdev->config->get(vdev, offset, &ret, sizeof(ret));
- return ret;
+ return virtio64_to_cpu(vdev, (__force __virtio64)ret);
}
static inline void virtio_cwrite64(struct virtio_device *vdev,
unsigned int offset, u64 val)
{
+ val = (__force u64)cpu_to_virtio64(vdev, val);
vdev->config->set(vdev, offset, &val, sizeof(val));
}
--
MST
next prev parent reply other threads:[~2014-10-22 15:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1413992894-22976-1-git-send-email-mst@redhat.com>
2014-10-22 15:50 ` [PATCH RFC v2 01/16] virtio: memory access APIs Michael S. Tsirkin
2014-10-22 17:45 ` Christopher Covington
2014-10-22 18:40 ` Michael S. Tsirkin
2014-10-22 15:50 ` [PATCH RFC v2 02/16] virtio_ring: switch to new " Michael S. Tsirkin
2014-10-22 15:50 ` [PATCH RFC v2 03/16] virtio: use u32, not bitmap for struct virtio_device's features Michael S. Tsirkin
2014-10-22 15:50 ` [PATCH RFC v2 04/16] virtio: add support for 64 bit features Michael S. Tsirkin
2014-10-22 15:50 ` [PATCH RFC v2 05/16] virtio: add virtio 1.0 feature bit Michael S. Tsirkin
2014-10-22 15:50 ` [PATCH RFC v2 06/16] virtio: make endian-ness depend on virtio 1.0 Michael S. Tsirkin
2014-10-22 15:50 ` Michael S. Tsirkin [this message]
2014-10-22 15:50 ` [PATCH RFC v2 08/16] virtio: allow transports to get avail/used addresses Michael S. Tsirkin
2014-10-22 15:50 ` [PATCH RFC v2 09/16] virtio: set FEATURES_OK Michael S. Tsirkin
2014-10-22 15:50 ` [PATCH RFC v2 10/16] virtio_net: use v1.0 endian Michael S. Tsirkin
2014-10-22 15:50 ` [PATCH RFC v2 11/16] virtio_blk: use virtio " Michael S. Tsirkin
2014-10-22 15:51 ` [PATCH RFC v2 15/16] virtio_net: fix types for in memory structures Michael S. Tsirkin
2014-10-22 15:51 ` [PATCH RFC v2 16/16] virtio_blk: " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413992894-22976-8-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=dahi@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).