virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: virtualization@lists.linux-foundation.org
Subject: [PATCH RFC v4 10/17] virtio: simplify feature bit handling
Date: Thu, 23 Oct 2014 19:24:40 +0300	[thread overview]
Message-ID: <1414081380-14623-11-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1414081380-14623-1-git-send-email-mst@redhat.com>

Now that we use u64 for bits, we can simply & them together.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 drivers/virtio/virtio.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
index a3df817..0f44cff 100644
--- a/drivers/virtio/virtio.c
+++ b/drivers/virtio/virtio.c
@@ -160,6 +160,7 @@ static int virtio_dev_probe(struct device *_d)
 	struct virtio_device *dev = dev_to_virtio(_d);
 	struct virtio_driver *drv = drv_to_virtio(dev->dev.driver);
 	u64 device_features;
+	u64 driver_features;
 	unsigned status;
 
 	/* We have a driver! */
@@ -168,15 +169,16 @@ static int virtio_dev_probe(struct device *_d)
 	/* Figure out what features the device supports. */
 	device_features = dev->config->get_features(dev);
 
-	/* Features supported by both device and driver into dev->features. */
-	dev->features = 0;
+	/* Figure out what features the driver supports. */
+	driver_features = 0;
 	for (i = 0; i < drv->feature_table_size; i++) {
 		unsigned int f = drv->feature_table[i];
 		BUG_ON(f >= 64);
-		if (device_features & (1ULL << f))
-			dev->features |= (1ULL << f);
+		driver_features |= (1ULL << f);
 	}
 
+	dev->features = driver_features & device_features;
+
 	/* Transport features always preserved to pass to finalize_features. */
 	for (i = VIRTIO_TRANSPORT_F_START; i < VIRTIO_TRANSPORT_F_END; i++)
 		if (device_features & (1ULL << i))
-- 
MST

  parent reply	other threads:[~2014-10-23 16:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1414081380-14623-1-git-send-email-mst@redhat.com>
2014-10-23 16:24 ` [PATCH RFC v4 01/17] virtio: memory access APIs Michael S. Tsirkin
2014-10-23 16:24 ` [PATCH RFC v4 02/17] virtio_ring: switch to new " Michael S. Tsirkin
2014-10-23 16:24 ` [PATCH RFC v4 03/17] virtio: use u32, not bitmap for struct virtio_device's features Michael S. Tsirkin
2014-10-23 16:24 ` [PATCH RFC v4 04/17] virtio: add support for 64 bit features Michael S. Tsirkin
2014-10-23 16:24 ` [PATCH RFC v4 05/17] virtio: add virtio 1.0 feature bit Michael S. Tsirkin
2014-10-23 16:24 ` [PATCH RFC v4 06/17] virtio: make endian-ness depend on virtio 1.0 Michael S. Tsirkin
2014-10-23 16:24 ` [PATCH RFC v4 07/17] virtio_config: endian conversion for v1.0 Michael S. Tsirkin
2014-10-23 16:24 ` [PATCH RFC v4 08/17] virtio: allow transports to get avail/used addresses Michael S. Tsirkin
2014-10-23 16:24 ` [PATCH RFC v4 09/17] virtio: set FEATURES_OK Michael S. Tsirkin
2014-10-23 16:24 ` Michael S. Tsirkin [this message]
2014-10-23 16:24 ` [PATCH RFC v4 11/17] virtio: add legacy feature table support Michael S. Tsirkin
2014-10-23 16:24 ` [PATCH RFC v4 12/17] virtio_net: v1.0 support Michael S. Tsirkin
2014-10-23 16:24 ` [PATCH RFC v4 13/17] virtio_blk: " Michael S. Tsirkin
     [not found] ` <1414081380-14623-8-git-send-email-mst@redhat.com>
2014-10-24  8:53   ` [PATCH RFC v4 07/17] virtio_config: endian conversion for v1.0 Cornelia Huck
2014-10-24 13:52     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414081380-14623-11-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).