From: Ben Hutchings <ben@decadent.org.uk>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org,
Hannes Frederic Sowa <hannes@stressinduktion.org>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v2 net 1/2] drivers/net: Disable UFO through virtio
Date: Thu, 30 Oct 2014 22:20:02 +0000 [thread overview]
Message-ID: <1414707602.16849.70.camel@decadent.org.uk> (raw)
In-Reply-To: <1414694849.15352.3.camel@edumazet-glaptop2.roam.corp.google.com>
[-- Attachment #1.1: Type: text/plain, Size: 817 bytes --]
On Thu, 2014-10-30 at 11:47 -0700, Eric Dumazet wrote:
> On Thu, 2014-10-30 at 18:27 +0000, Ben Hutchings wrote:
>
>
> > + {
> > + static bool warned;
> > +
> > + if (!warned) {
> > + warned = true;
> > + netdev_warn(tun->dev,
> > + "%s: using disabled UFO feature; please fix this program\n",
> > + current->comm);
> > + }
> >
>
> It might be time to add netdev_warn_once() ;)
Could do. I'm trying to make small fixes that are suitable for stable.
> Alternatively, you could use
> pr_warn_once("%s: using disabled UFO feature; please fix this program\n",
> tun->dev->name, current->comm);
That's missing a "%s: ", but yes that would also work.
Ben.
--
Ben Hutchings
The program is absolutely right; therefore, the computer must be wrong.
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
[-- Attachment #2: Type: text/plain, Size: 183 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2014-10-30 22:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1414693592.16849.61.camel@decadent.org.uk>
2014-10-30 18:27 ` [PATCH v2 net 1/2] drivers/net: Disable UFO through virtio Ben Hutchings
2014-10-30 18:47 ` Eric Dumazet
2014-10-30 22:20 ` Ben Hutchings [this message]
2014-10-30 23:16 ` Eric Dumazet
2014-11-19 9:14 ` Michael S. Tsirkin
2014-11-21 1:47 ` Jason Wang
2014-11-21 18:46 ` Ben Hutchings
2014-11-23 10:33 ` Michael S. Tsirkin
2014-10-30 18:27 ` [PATCH v2 net 2/2] drivers/net,ipv6: Select IPv6 fragment idents for virtio UFO packets Ben Hutchings
2014-10-31 0:02 ` [PATCH v2 net 0/2] drivers/net,ipv6: Fix IPv6 fragment ID selection for virtio David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414707602.16849.70.camel@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=eric.dumazet@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).