virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: rusty@au1.ibm.com, virtualization@lists.linux-foundation.org,
	David Hildenbrand <dahi@linux.vnet.ibm.com>,
	pbonzini@redhat.com, David Miller <davem@davemloft.net>
Subject: [PATCH v3 06/41] virtio_config: endian conversion for v1.0
Date: Mon, 24 Nov 2014 13:53:05 +0200	[thread overview]
Message-ID: <1416829787-14252-7-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1416829787-14252-1-git-send-email-mst@redhat.com>

We (ab)use virtio conversion functions for device-specific
config space accesses.

Reviewed-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/linux/virtio_config.h | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h
index b9cd689..b50c4a1 100644
--- a/include/linux/virtio_config.h
+++ b/include/linux/virtio_config.h
@@ -271,12 +271,13 @@ static inline u16 virtio_cread16(struct virtio_device *vdev,
 {
 	u16 ret;
 	vdev->config->get(vdev, offset, &ret, sizeof(ret));
-	return ret;
+	return virtio16_to_cpu(vdev, (__force __virtio16)ret);
 }
 
 static inline void virtio_cwrite16(struct virtio_device *vdev,
 				   unsigned int offset, u16 val)
 {
+	val = (__force u16)cpu_to_virtio16(vdev, val);
 	vdev->config->set(vdev, offset, &val, sizeof(val));
 }
 
@@ -285,12 +286,13 @@ static inline u32 virtio_cread32(struct virtio_device *vdev,
 {
 	u32 ret;
 	vdev->config->get(vdev, offset, &ret, sizeof(ret));
-	return ret;
+	return virtio32_to_cpu(vdev, (__force __virtio32)ret);
 }
 
 static inline void virtio_cwrite32(struct virtio_device *vdev,
 				   unsigned int offset, u32 val)
 {
+	val = (__force u32)cpu_to_virtio32(vdev, val);
 	vdev->config->set(vdev, offset, &val, sizeof(val));
 }
 
@@ -299,12 +301,13 @@ static inline u64 virtio_cread64(struct virtio_device *vdev,
 {
 	u64 ret;
 	vdev->config->get(vdev, offset, &ret, sizeof(ret));
-	return ret;
+	return virtio64_to_cpu(vdev, (__force __virtio64)ret);
 }
 
 static inline void virtio_cwrite64(struct virtio_device *vdev,
 				   unsigned int offset, u64 val)
 {
+	val = (__force u64)cpu_to_virtio64(vdev, val);
 	vdev->config->set(vdev, offset, &val, sizeof(val));
 }
 
-- 
MST

  parent reply	other threads:[~2014-11-24 11:53 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1416829787-14252-1-git-send-email-mst@redhat.com>
2014-11-24 11:52 ` [PATCH v3 01/41] virtio: use u32, not bitmap for struct virtio_device's features Michael S. Tsirkin
2014-11-24 11:52 ` [PATCH v3 02/41] virtio: add support for 64 bit features Michael S. Tsirkin
2014-11-24 11:52 ` [PATCH v3 03/41] virtio: add virtio 1.0 feature bit Michael S. Tsirkin
2014-11-24 11:52 ` [PATCH v3 04/41] virtio: memory access APIs Michael S. Tsirkin
2014-11-24 12:03   ` Geert Uytterhoeven
2014-11-24 12:15     ` Michael S. Tsirkin
2014-11-24 12:58       ` Geert Uytterhoeven
     [not found]       ` <CAMuHMdWJA4aUyHo8wq=RX-+0w+PX3NtG1ZgvWgcMwKT5KYT_Tg@mail.gmail.com>
2014-11-24 18:49         ` Michael S. Tsirkin
2014-11-24 11:53 ` [PATCH v3 05/41] virtio_ring: switch to new " Michael S. Tsirkin
2014-11-24 11:53 ` Michael S. Tsirkin [this message]
2014-11-24 11:53 ` [PATCH v3 07/41] virtio: allow transports to get avail/used addresses Michael S. Tsirkin
2014-11-24 11:53 ` [PATCH v3 08/41] virtio: set FEATURES_OK Michael S. Tsirkin
2014-11-24 11:53 ` [PATCH v3 09/41] virtio: simplify feature bit handling Michael S. Tsirkin
2014-11-24 11:53 ` [PATCH v3 10/41] virtio: add legacy feature table support Michael S. Tsirkin
2014-11-24 11:53 ` [PATCH v3 11/41] virtio_net: v1.0 endianness Michael S. Tsirkin
2014-11-24 11:53 ` [PATCH v3 12/41] virtio_blk: v1.0 support Michael S. Tsirkin
2014-11-24 11:53 ` [PATCH v3 17/41] virtio_blk: make serial attribute static Michael S. Tsirkin
2014-11-24 11:53 ` [PATCH v3 18/41] virtio_blk: fix race at module removal Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 19/41] virtio_net: pass vi around Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 20/41] virtio_net: get rid of virtio_net_hdr/skb_vnet_hdr Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 21/41] virtio_net: stricter short buffer length checks Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 22/41] virtio_net: bigger header when VERSION_1 is set Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 23/41] virtio_net: enable v1.0 support Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 24/41] vhost: add memory access wrappers Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 25/41] vhost/net: force len for TX to host endian Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 26/41] vhost: virtio 1.0 endian-ness support Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 27/41] vhost: make features 64 bit Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 28/41] vhost/net: virtio 1.0 byte swap Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 29/41] vhost/net: larger header for virtio 1.0 Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 30/41] vhost/net: enable " Michael S. Tsirkin
2014-11-24 11:54 ` [PATCH v3 31/41] vhost/net: suppress compiler warning Michael S. Tsirkin
2014-11-24 11:55 ` [PATCH v3 37/41] virtio_scsi: v1.0 support Michael S. Tsirkin
2014-11-24 11:55 ` [PATCH v3 39/41] virtio_scsi: export to userspace Michael S. Tsirkin
2014-11-24 11:55 ` [PATCH v3 40/41] vhost/scsi: partial virtio 1.0 support Michael S. Tsirkin
     [not found] ` <1416829787-14252-27-git-send-email-mst@redhat.com>
2014-11-24 14:28   ` [PATCH v3 26/41] vhost: virtio 1.0 endian-ness support Cedric Le Goater
     [not found]   ` <5473408A.2090308@fr.ibm.com>
2014-11-24 20:28     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416829787-14252-7-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=dahi@linux.vnet.ibm.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rusty@au1.ibm.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).