virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: rusty@au1.ibm.com, virtualization@lists.linux-foundation.org,
	pbonzini@redhat.com, David Miller <davem@davemloft.net>
Subject: [PATCH v4 10/42] virtio: simplify feature bit handling
Date: Tue, 25 Nov 2014 18:42:05 +0200	[thread overview]
Message-ID: <1416933600-21398-11-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1416933600-21398-1-git-send-email-mst@redhat.com>

Now that we use u64 for bits, we can simply & them together.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 drivers/virtio/virtio.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
index a3df817..0f44cff 100644
--- a/drivers/virtio/virtio.c
+++ b/drivers/virtio/virtio.c
@@ -160,6 +160,7 @@ static int virtio_dev_probe(struct device *_d)
 	struct virtio_device *dev = dev_to_virtio(_d);
 	struct virtio_driver *drv = drv_to_virtio(dev->dev.driver);
 	u64 device_features;
+	u64 driver_features;
 	unsigned status;
 
 	/* We have a driver! */
@@ -168,15 +169,16 @@ static int virtio_dev_probe(struct device *_d)
 	/* Figure out what features the device supports. */
 	device_features = dev->config->get_features(dev);
 
-	/* Features supported by both device and driver into dev->features. */
-	dev->features = 0;
+	/* Figure out what features the driver supports. */
+	driver_features = 0;
 	for (i = 0; i < drv->feature_table_size; i++) {
 		unsigned int f = drv->feature_table[i];
 		BUG_ON(f >= 64);
-		if (device_features & (1ULL << f))
-			dev->features |= (1ULL << f);
+		driver_features |= (1ULL << f);
 	}
 
+	dev->features = driver_features & device_features;
+
 	/* Transport features always preserved to pass to finalize_features. */
 	for (i = VIRTIO_TRANSPORT_F_START; i < VIRTIO_TRANSPORT_F_END; i++)
 		if (device_features & (1ULL << i))
-- 
MST

  parent reply	other threads:[~2014-11-25 16:42 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1416933600-21398-1-git-send-email-mst@redhat.com>
2014-11-25 16:41 ` [PATCH v4 01/42] virtio: use u32, not bitmap for struct virtio_device's features Michael S. Tsirkin
2014-11-25 16:41 ` [PATCH v4 02/42] virtio: add support for 64 bit features Michael S. Tsirkin
2014-11-26 16:48   ` Greg Kurz
2014-11-26 16:56     ` Michael S. Tsirkin
2014-11-25 16:41 ` [PATCH v4 03/42] virtio: add virtio 1.0 feature bit Michael S. Tsirkin
2014-11-25 16:41 ` [PATCH v4 04/42] virtio: disable virtio 1.0 in transports Michael S. Tsirkin
2014-11-25 17:29   ` Cornelia Huck
2014-11-25 21:20     ` Michael S. Tsirkin
2014-11-26  9:09       ` Cornelia Huck
2014-11-27 10:54         ` Michael S. Tsirkin
2014-11-27 11:02           ` Cornelia Huck
2014-11-27 11:06             ` Michael S. Tsirkin
2014-11-25 16:41 ` [PATCH v4 05/42] virtio: memory access APIs Michael S. Tsirkin
2014-11-25 17:42   ` Cornelia Huck
2014-11-25 16:41 ` [PATCH v4 06/42] virtio_ring: switch to new " Michael S. Tsirkin
2014-11-25 16:41 ` [PATCH v4 07/42] virtio_config: endian conversion for v1.0 Michael S. Tsirkin
2014-11-25 16:41 ` [PATCH v4 08/42] virtio: allow transports to get avail/used addresses Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 09/42] virtio: set FEATURES_OK Michael S. Tsirkin
2014-11-25 17:48   ` Cornelia Huck
2014-11-25 21:38     ` Michael S. Tsirkin
2014-11-26  9:18       ` Cornelia Huck
2014-11-25 16:42 ` Michael S. Tsirkin [this message]
2014-11-25 16:42 ` [PATCH v4 11/42] virtio: add legacy feature table support Michael S. Tsirkin
2014-11-25 17:53   ` Cornelia Huck
2014-11-25 21:39     ` Michael S. Tsirkin
2014-11-26  9:19       ` Cornelia Huck
2014-11-25 16:42 ` [PATCH v4 12/42] virtio_net: v1.0 endianness Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 13/42] virtio_blk: v1.0 support Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 18/42] virtio_blk: make serial attribute static Michael S. Tsirkin
2014-11-26  8:48   ` Gerd Hoffmann
2014-11-26  9:50   ` Cornelia Huck
2014-11-25 16:42 ` [PATCH v4 19/42] virtio_blk: fix race at module removal Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 20/42] virtio_net: pass vi around Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 21/42] virtio_net: get rid of virtio_net_hdr/skb_vnet_hdr Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 22/42] virtio_net: stricter short buffer length checks Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 23/42] virtio_net: bigger header when VERSION_1 is set Michael S. Tsirkin
2014-11-26 13:04   ` Cornelia Huck
2014-11-25 16:43 ` [PATCH v4 24/42] virtio_net: enable v1.0 support Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 25/42] vhost: add memory access wrappers Michael S. Tsirkin
2014-11-26 13:54   ` Cornelia Huck
2014-11-26 14:05     ` Michael S. Tsirkin
2014-11-26 14:17       ` Cornelia Huck
2014-11-26 14:24         ` Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 26/42] vhost/net: force len for TX to host endian Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 27/42] vhost: virtio 1.0 endian-ness support Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 28/42] vhost: make features 64 bit Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 29/42] vhost/net: virtio 1.0 byte swap Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 30/42] vhost/net: larger header for virtio 1.0 Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 31/42] vhost/net: enable " Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 32/42] vhost/net: suppress compiler warning Michael S. Tsirkin
2014-11-25 16:44 ` [PATCH v4 38/42] virtio_scsi: v1.0 support Michael S. Tsirkin
2014-11-25 16:44 ` [PATCH v4 40/42] virtio_scsi: export to userspace Michael S. Tsirkin
2014-11-25 16:44 ` [PATCH v4 41/42] vhost/scsi: partial virtio 1.0 support Michael S. Tsirkin
     [not found] ` <1416933600-21398-8-git-send-email-mst@redhat.com>
2014-11-25 17:45   ` [PATCH v4 07/42] virtio_config: endian conversion for v1.0 Cornelia Huck
2014-11-25 21:36     ` Michael S. Tsirkin
2014-11-26  9:13       ` Cornelia Huck
     [not found] ` <1416933600-21398-14-git-send-email-mst@redhat.com>
2014-11-25 17:55   ` [PATCH v4 13/42] virtio_blk: v1.0 support Cornelia Huck
     [not found]   ` <20141125185516.7570c6e7.cornelia.huck@de.ibm.com>
2014-11-25 21:43     ` Michael S. Tsirkin
2014-11-26 15:40       ` David Hildenbrand
2014-11-26 15:48         ` Michael S. Tsirkin
     [not found] ` <1416933600-21398-20-git-send-email-mst@redhat.com>
2014-11-26  9:53   ` [PATCH v4 19/42] virtio_blk: fix race at module removal Cornelia Huck
     [not found] ` <1416933600-21398-21-git-send-email-mst@redhat.com>
2014-11-26 12:35   ` [PATCH v4 20/42] virtio_net: pass vi around Cornelia Huck
     [not found] ` <1416933600-21398-22-git-send-email-mst@redhat.com>
2014-11-26 12:50   ` [PATCH v4 21/42] virtio_net: get rid of virtio_net_hdr/skb_vnet_hdr Cornelia Huck
2014-11-26 13:11     ` Michael S. Tsirkin
     [not found] ` <1416933600-21398-23-git-send-email-mst@redhat.com>
2014-11-26 13:00   ` [PATCH v4 22/42] virtio_net: stricter short buffer length checks Cornelia Huck
     [not found] ` <1416933600-21398-25-git-send-email-mst@redhat.com>
2014-11-26 13:08   ` [PATCH v4 24/42] virtio_net: enable v1.0 support Cornelia Huck
2014-11-26 13:28     ` Michael S. Tsirkin
     [not found] ` <1416933600-21398-27-git-send-email-mst@redhat.com>
2014-11-26 14:31   ` [PATCH v4 26/42] vhost/net: force len for TX to host endian Cornelia Huck
2014-11-26 14:44     ` Michael S. Tsirkin
2014-11-26 14:54       ` Cornelia Huck
2014-11-26 15:01         ` Michael S. Tsirkin
     [not found] ` <1416933600-21398-39-git-send-email-mst@redhat.com>
2014-11-26 14:51   ` [PATCH v4 38/42] virtio_scsi: v1.0 support Cornelia Huck
2014-11-26 14:56     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416933600-21398-11-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rusty@au1.ibm.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).