virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-s390@vger.kernel.org, lguest@lists.ozlabs.org,
	Pawel Moll <pawel.moll@arm.com>,
	rusty@au1.ibm.com,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Sudeep Dutt <sudeep.dutt@intel.com>,
	virtualization@lists.linux-foundation.org,
	Ashutosh Dixit <ashutosh.dixit@intel.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Siva Yerramreddy <yshivakrishna@gmail.com>,
	linux390@de.ibm.com, pbonzini@redhat.com,
	David Miller <davem@davemloft.net>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: [PATCH v4 04/42] virtio: disable virtio 1.0 in transports
Date: Tue, 25 Nov 2014 18:41:35 +0200	[thread overview]
Message-ID: <1416933600-21398-5-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1416933600-21398-1-git-send-email-mst@redhat.com>

disable virtio 1.0 in transports that don't
support it yet.
We will gradually re-enable as support is added.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 drivers/lguest/lguest_device.c     | 3 ++-
 drivers/misc/mic/card/mic_virtio.c | 2 ++
 drivers/s390/kvm/virtio_ccw.c      | 3 ++-
 drivers/virtio/virtio_mmio.c       | 2 ++
 4 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/lguest/lguest_device.c b/drivers/lguest/lguest_device.c
index 4d29bcd..4deaf88 100644
--- a/drivers/lguest/lguest_device.c
+++ b/drivers/lguest/lguest_device.c
@@ -106,7 +106,8 @@ static u64 lg_get_features(struct virtio_device *vdev)
 		if (in_features[i / 8] & (1 << (i % 8)))
 			features |= (1ULL << i);
 
-	return features;
+	/* lguest is not in virtio 1.0 */
+	return features & ~BIT_ULL(VIRTIO_F_VERSION_1);
 }
 
 /*
diff --git a/drivers/misc/mic/card/mic_virtio.c b/drivers/misc/mic/card/mic_virtio.c
index 6d94f04..edc77f1 100644
--- a/drivers/misc/mic/card/mic_virtio.c
+++ b/drivers/misc/mic/card/mic_virtio.c
@@ -82,6 +82,8 @@ static u64 mic_get_features(struct virtio_device *vdev)
 		if (ioread8(&in_features[i / 8]) & (BIT_ULL(i % 8)))
 			features |= BIT_ULL(i);
 
+	/* MIC is not in virtio 1.0, disable it for now. */
+	features &= ~BIT_ULL(VIRTIO_F_VERSION_1);
 	return features;
 }
 
diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm/virtio_ccw.c
index abba04d..08536f0 100644
--- a/drivers/s390/kvm/virtio_ccw.c
+++ b/drivers/s390/kvm/virtio_ccw.c
@@ -704,7 +704,8 @@ static u64 virtio_ccw_get_features(struct virtio_device *vdev)
 out_free:
 	kfree(features);
 	kfree(ccw);
-	return rc;
+	/* TODO: enable virtio 1.0 */
+	return rc & ~BIT_ULL(VIRTIO_F_VERSION_1);;
 }
 
 static void virtio_ccw_finalize_features(struct virtio_device *vdev)
diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
index fd01c6d..e1d38a9 100644
--- a/drivers/virtio/virtio_mmio.c
+++ b/drivers/virtio/virtio_mmio.c
@@ -151,6 +151,8 @@ static u64 vm_get_features(struct virtio_device *vdev)
 	features = readl(vm_dev->base + VIRTIO_MMIO_HOST_FEATURES);
 	writel(1, vm_dev->base + VIRTIO_MMIO_HOST_FEATURES_SEL);
 	features |= ((u64)readl(vm_dev->base + VIRTIO_MMIO_HOST_FEATURES) << 32);
+	/* TODO: enable virtio 1.0 support */
+	features &= ~BIT_ULL(VIRTIO_F_VERSION_1);
 	return features;
 }
 
-- 
MST

  parent reply	other threads:[~2014-11-25 16:41 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1416933600-21398-1-git-send-email-mst@redhat.com>
2014-11-25 16:41 ` [PATCH v4 01/42] virtio: use u32, not bitmap for struct virtio_device's features Michael S. Tsirkin
2014-11-25 16:41 ` [PATCH v4 02/42] virtio: add support for 64 bit features Michael S. Tsirkin
2014-11-26 16:48   ` Greg Kurz
2014-11-26 16:56     ` Michael S. Tsirkin
2014-11-25 16:41 ` [PATCH v4 03/42] virtio: add virtio 1.0 feature bit Michael S. Tsirkin
2014-11-25 16:41 ` Michael S. Tsirkin [this message]
2014-11-25 17:29   ` [PATCH v4 04/42] virtio: disable virtio 1.0 in transports Cornelia Huck
2014-11-25 21:20     ` Michael S. Tsirkin
2014-11-26  9:09       ` Cornelia Huck
2014-11-27 10:54         ` Michael S. Tsirkin
2014-11-27 11:02           ` Cornelia Huck
2014-11-27 11:06             ` Michael S. Tsirkin
2014-11-25 16:41 ` [PATCH v4 05/42] virtio: memory access APIs Michael S. Tsirkin
2014-11-25 17:42   ` Cornelia Huck
2014-11-25 16:41 ` [PATCH v4 06/42] virtio_ring: switch to new " Michael S. Tsirkin
2014-11-25 16:41 ` [PATCH v4 07/42] virtio_config: endian conversion for v1.0 Michael S. Tsirkin
2014-11-25 16:41 ` [PATCH v4 08/42] virtio: allow transports to get avail/used addresses Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 09/42] virtio: set FEATURES_OK Michael S. Tsirkin
2014-11-25 17:48   ` Cornelia Huck
2014-11-25 21:38     ` Michael S. Tsirkin
2014-11-26  9:18       ` Cornelia Huck
2014-11-25 16:42 ` [PATCH v4 10/42] virtio: simplify feature bit handling Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 11/42] virtio: add legacy feature table support Michael S. Tsirkin
2014-11-25 17:53   ` Cornelia Huck
2014-11-25 21:39     ` Michael S. Tsirkin
2014-11-26  9:19       ` Cornelia Huck
2014-11-25 16:42 ` [PATCH v4 12/42] virtio_net: v1.0 endianness Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 13/42] virtio_blk: v1.0 support Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 18/42] virtio_blk: make serial attribute static Michael S. Tsirkin
2014-11-26  8:48   ` Gerd Hoffmann
2014-11-26  9:50   ` Cornelia Huck
2014-11-25 16:42 ` [PATCH v4 19/42] virtio_blk: fix race at module removal Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 20/42] virtio_net: pass vi around Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 21/42] virtio_net: get rid of virtio_net_hdr/skb_vnet_hdr Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 22/42] virtio_net: stricter short buffer length checks Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 23/42] virtio_net: bigger header when VERSION_1 is set Michael S. Tsirkin
2014-11-26 13:04   ` Cornelia Huck
2014-11-25 16:43 ` [PATCH v4 24/42] virtio_net: enable v1.0 support Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 25/42] vhost: add memory access wrappers Michael S. Tsirkin
2014-11-26 13:54   ` Cornelia Huck
2014-11-26 14:05     ` Michael S. Tsirkin
2014-11-26 14:17       ` Cornelia Huck
2014-11-26 14:24         ` Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 26/42] vhost/net: force len for TX to host endian Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 27/42] vhost: virtio 1.0 endian-ness support Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 28/42] vhost: make features 64 bit Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 29/42] vhost/net: virtio 1.0 byte swap Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 30/42] vhost/net: larger header for virtio 1.0 Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 31/42] vhost/net: enable " Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 32/42] vhost/net: suppress compiler warning Michael S. Tsirkin
2014-11-25 16:44 ` [PATCH v4 38/42] virtio_scsi: v1.0 support Michael S. Tsirkin
2014-11-25 16:44 ` [PATCH v4 40/42] virtio_scsi: export to userspace Michael S. Tsirkin
2014-11-25 16:44 ` [PATCH v4 41/42] vhost/scsi: partial virtio 1.0 support Michael S. Tsirkin
     [not found] ` <1416933600-21398-8-git-send-email-mst@redhat.com>
2014-11-25 17:45   ` [PATCH v4 07/42] virtio_config: endian conversion for v1.0 Cornelia Huck
2014-11-25 21:36     ` Michael S. Tsirkin
2014-11-26  9:13       ` Cornelia Huck
     [not found] ` <1416933600-21398-14-git-send-email-mst@redhat.com>
2014-11-25 17:55   ` [PATCH v4 13/42] virtio_blk: v1.0 support Cornelia Huck
     [not found]   ` <20141125185516.7570c6e7.cornelia.huck@de.ibm.com>
2014-11-25 21:43     ` Michael S. Tsirkin
2014-11-26 15:40       ` David Hildenbrand
2014-11-26 15:48         ` Michael S. Tsirkin
     [not found] ` <1416933600-21398-20-git-send-email-mst@redhat.com>
2014-11-26  9:53   ` [PATCH v4 19/42] virtio_blk: fix race at module removal Cornelia Huck
     [not found] ` <1416933600-21398-21-git-send-email-mst@redhat.com>
2014-11-26 12:35   ` [PATCH v4 20/42] virtio_net: pass vi around Cornelia Huck
     [not found] ` <1416933600-21398-22-git-send-email-mst@redhat.com>
2014-11-26 12:50   ` [PATCH v4 21/42] virtio_net: get rid of virtio_net_hdr/skb_vnet_hdr Cornelia Huck
2014-11-26 13:11     ` Michael S. Tsirkin
     [not found] ` <1416933600-21398-23-git-send-email-mst@redhat.com>
2014-11-26 13:00   ` [PATCH v4 22/42] virtio_net: stricter short buffer length checks Cornelia Huck
     [not found] ` <1416933600-21398-25-git-send-email-mst@redhat.com>
2014-11-26 13:08   ` [PATCH v4 24/42] virtio_net: enable v1.0 support Cornelia Huck
2014-11-26 13:28     ` Michael S. Tsirkin
     [not found] ` <1416933600-21398-27-git-send-email-mst@redhat.com>
2014-11-26 14:31   ` [PATCH v4 26/42] vhost/net: force len for TX to host endian Cornelia Huck
2014-11-26 14:44     ` Michael S. Tsirkin
2014-11-26 14:54       ` Cornelia Huck
2014-11-26 15:01         ` Michael S. Tsirkin
     [not found] ` <1416933600-21398-39-git-send-email-mst@redhat.com>
2014-11-26 14:51   ` [PATCH v4 38/42] virtio_scsi: v1.0 support Cornelia Huck
2014-11-26 14:56     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416933600-21398-5-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=ashutosh.dixit@intel.com \
    --cc=borntraeger@de.ibm.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=lguest@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux390@de.ibm.com \
    --cc=pawel.moll@arm.com \
    --cc=pbonzini@redhat.com \
    --cc=rusty@au1.ibm.com \
    --cc=schwidefsky@de.ibm.com \
    --cc=sudeep.dutt@intel.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=yshivakrishna@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).