From: Amos Kong <akong@redhat.com>
To: linux-crypto@vger.kernel.org
Cc: herbert@gondor.apana.org.au, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, m@bues.ch,
mpm@selenic.com, amit.shah@redhat.com
Subject: [PATCH v5 REPOST 0/6] fix hw_random stuck
Date: Mon, 8 Dec 2014 16:50:34 +0800 [thread overview]
Message-ID: <1418028640-4891-1-git-send-email-akong@redhat.com> (raw)
When I hotunplug a busy virtio-rng device or try to access
hwrng attributes in non-smp guest, it gets stuck.
My hotplug tests:
| test 0:
| hotunplug rng device from qemu monitor
|
| test 1:
| guest) # dd if=/dev/hwrng of=/dev/null &
| hotunplug rng device from qemu monitor
|
| test 2:
| guest) # dd if=/dev/random of=/dev/null &
| hotunplug rng device from qemu monitor
|
| test 4:
| guest) # dd if=/dev/hwrng of=/dev/null &
| cat /sys/devices/virtual/misc/hw_random/rng_*
|
| test 5:
| guest) # dd if=/dev/hwrng of=/dev/null
| cancel dd process after 10 seconds
| guest) # dd if=/dev/hwrng of=/dev/null &
| hotunplug rng device from qemu monitor
|
| test 6:
| use a fifo as rng backend, execute test 0 ~ 5 with no input of fifo
V5: reset cleanup_done flag, drop redundant init of reference count, use
compiler barrier to prevent recording.
V4: update patch 4 to fix corrupt, decrease last reference for triggering
the cleanup, fix unregister race pointed by Herbert
V3: initialize kref to 1
V2: added patch 2 to fix a deadlock, update current patch 3 to fix reference
counting issue
Amos Kong (1):
hw_random: move some code out mutex_lock for avoiding underlying
deadlock
Rusty Russell (5):
hw_random: place mutex around read functions and buffers.
hw_random: use reference counts on each struct hwrng.
hw_random: fix unregister race.
hw_random: don't double-check old_rng.
hw_random: don't init list element we're about to add to list.
drivers/char/hw_random/core.c | 173 ++++++++++++++++++++++++++++++------------
include/linux/hw_random.h | 3 +
2 files changed, 126 insertions(+), 50 deletions(-)
--
1.9.3
next reply other threads:[~2014-12-08 8:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 8:50 Amos Kong [this message]
2014-12-08 8:50 ` [PATCH v5 REPOST 1/6] hw_random: place mutex around read functions and buffers Amos Kong
2017-09-25 22:00 ` Dmitry Torokhov
[not found] ` <CAKdAkRSF1qJv_03PJh44gkQ7NOJ3ccW2EwPckGvch=iUYY1-Qw@mail.gmail.com>
2017-09-26 6:36 ` Pankaj Gupta
[not found] ` <369186187.14365871.1506407817157.JavaMail.zimbra@redhat.com>
2017-09-26 16:52 ` Dmitry Torokhov
[not found] ` <20170926165241.GB14833@dtor-ws>
2017-09-27 6:35 ` Pankaj Gupta
2014-12-08 8:50 ` [PATCH v5 REPOST 2/6] hw_random: move some code out mutex_lock for avoiding underlying deadlock Amos Kong
2014-12-08 8:50 ` [PATCH v5 REPOST 3/6] hw_random: use reference counts on each struct hwrng Amos Kong
2014-12-08 8:50 ` [PATCH v5 REPOST 4/6] hw_random: fix unregister race Amos Kong
2014-12-08 8:50 ` [PATCH v5 REPOST 5/6] hw_random: don't double-check old_rng Amos Kong
2014-12-08 8:50 ` [PATCH v5 REPOST 6/6] hw_random: don't init list element we're about to add to list Amos Kong
2014-12-22 12:05 ` [PATCH v5 REPOST 0/6] fix hw_random stuck Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418028640-4891-1-git-send-email-akong@redhat.com \
--to=akong@redhat.com \
--cc=amit.shah@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=kvm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m@bues.ch \
--cc=mpm@selenic.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox