* [PATCH v5 06/10] virtio_pci: drop msi_off on probe [not found] <1427641227-7574-1-git-send-email-mst@redhat.com> @ 2015-03-29 15:04 ` Michael S. Tsirkin 2015-04-02 3:55 ` Fam Zheng 0 siblings, 1 reply; 2+ messages in thread From: Michael S. Tsirkin @ 2015-03-29 15:04 UTC (permalink / raw) To: linux-kernel Cc: Fam Zheng, linux-pci, virtualization, Yinghai Lu, Yijing Wang, Bjorn Helgaas pci core now disables msi on probe automatically, drop this from device-specific code. Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: linux-pci@vger.kernel.org Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- drivers/virtio/virtio_pci_common.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c index e894eb2..806bb2c 100644 --- a/drivers/virtio/virtio_pci_common.c +++ b/drivers/virtio/virtio_pci_common.c @@ -501,9 +501,6 @@ static int virtio_pci_probe(struct pci_dev *pci_dev, INIT_LIST_HEAD(&vp_dev->virtqueues); spin_lock_init(&vp_dev->lock); - /* Disable MSI/MSIX to bring device to a known good state. */ - pci_msi_off(pci_dev); - /* enable the device */ rc = pci_enable_device(pci_dev); if (rc) -- MST ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v5 06/10] virtio_pci: drop msi_off on probe 2015-03-29 15:04 ` [PATCH v5 06/10] virtio_pci: drop msi_off on probe Michael S. Tsirkin @ 2015-04-02 3:55 ` Fam Zheng 0 siblings, 0 replies; 2+ messages in thread From: Fam Zheng @ 2015-04-02 3:55 UTC (permalink / raw) To: Michael S. Tsirkin Cc: linux-pci, linux-kernel, virtualization, Yinghai Lu, Yijing Wang, Bjorn Helgaas On Sun, 03/29 17:04, Michael S. Tsirkin wrote: > pci core now disables msi on probe automatically, > drop this from device-specific code. > > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: linux-pci@vger.kernel.org > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > --- > drivers/virtio/virtio_pci_common.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c > index e894eb2..806bb2c 100644 > --- a/drivers/virtio/virtio_pci_common.c > +++ b/drivers/virtio/virtio_pci_common.c > @@ -501,9 +501,6 @@ static int virtio_pci_probe(struct pci_dev *pci_dev, > INIT_LIST_HEAD(&vp_dev->virtqueues); > spin_lock_init(&vp_dev->lock); > > - /* Disable MSI/MSIX to bring device to a known good state. */ > - pci_msi_off(pci_dev); > - > /* enable the device */ > rc = pci_enable_device(pci_dev); > if (rc) > -- > MST > Reviewed-by: Fam Zheng <famz@redhat.com> ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-02 3:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1427641227-7574-1-git-send-email-mst@redhat.com>
2015-03-29 15:04 ` [PATCH v5 06/10] virtio_pci: drop msi_off on probe Michael S. Tsirkin
2015-04-02 3:55 ` Fam Zheng
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).