From: Gerd Hoffmann <kraxel@redhat.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: open list <linux-kernel@vger.kernel.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
"open list:VIRTIO GPU DRIVER"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH 1/5] virtio-gpu: add virtio_gpu_queue_ctrl_buffer_nolock
Date: Thu, 10 Sep 2015 16:04:48 +0200 [thread overview]
Message-ID: <1441893888.11233.3.camel@redhat.com> (raw)
In-Reply-To: <CACvgo53bZnLoKHu_Gh-+mBVxs0MX07LckGc-hVxCpYxXmSTwRg@mail.gmail.com>
On Do, 2015-09-10 at 09:39 +0100, Emil Velikov wrote:
> Hi Gerd,
>
> On 9 September 2015 at 12:42, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > Add virtio_gpu_queue_ctrl_buffer_nolock function, which does the same as
> > virtio_gpu_queue_ctrl_buffer but does not take the virtqueue lock. The
> > caller must hold the lock instead.
> >
> The drm subsystem tends to use *_locked and *_unlocked suffixes. With
> the latter being less common.
> Not a big deal but perhaps you can use one of those for virtio ?
_locked looks correct for this case to me (looking at drm_vm_close +
drm_vm_close_locked to compare). I'll change it.
cheers,
Gerd
next prev parent reply other threads:[~2015-09-10 14:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1441798946-26233-1-git-send-email-kraxel@redhat.com>
2015-09-09 11:42 ` [PATCH 1/5] virtio-gpu: add virtio_gpu_queue_ctrl_buffer_nolock Gerd Hoffmann
2015-09-09 11:42 ` [PATCH 2/5] virtio-gpu: add & use virtio_gpu_queue_fenced_ctrl_buffer Gerd Hoffmann
2015-09-09 11:42 ` [PATCH 3/5] update virtio gpu driver: add 3d/virgl support Gerd Hoffmann
2015-09-09 11:42 ` [PATCH 4/5] virtio_gpu: add basic prime support Gerd Hoffmann
2015-09-09 11:42 ` [PATCH 5/5] virtgpu: mark as a render gpu Gerd Hoffmann
[not found] ` <1441798946-26233-2-git-send-email-kraxel@redhat.com>
2015-09-10 8:39 ` [PATCH 1/5] virtio-gpu: add virtio_gpu_queue_ctrl_buffer_nolock Emil Velikov
[not found] ` <CACvgo53bZnLoKHu_Gh-+mBVxs0MX07LckGc-hVxCpYxXmSTwRg@mail.gmail.com>
2015-09-10 14:04 ` Gerd Hoffmann [this message]
[not found] ` <1441798946-26233-4-git-send-email-kraxel@redhat.com>
2015-09-10 8:56 ` [PATCH 3/5] update virtio gpu driver: add 3d/virgl support Emil Velikov
[not found] ` <CACvgo51Y7j0ka46Rfq2eBvXzP4q8Jc6x4j-JrYHDLkH6_xOh7w@mail.gmail.com>
2015-09-10 10:32 ` Dave Airlie
[not found] ` <CAPM=9txn4yGwQg+ZdL5Z9ZtFzSnw3QfUtAWT5mSXgB_JL00pYA@mail.gmail.com>
2015-09-10 12:15 ` Emil Velikov
2015-09-10 14:45 ` Gerd Hoffmann
[not found] ` <1441798946-26233-6-git-send-email-kraxel@redhat.com>
2015-09-10 8:59 ` [PATCH 5/5] virtgpu: mark as a render gpu Emil Velikov
[not found] ` <CACvgo53wYvAk_bVouPZ-F7wNm=Diyouue8m1AvO0=U+PvL61_Q@mail.gmail.com>
2015-09-10 14:23 ` Gerd Hoffmann
2015-09-10 14:33 ` Emil Velikov
[not found] ` <CACvgo50SU46SYXBbVe+VGcAb6uFSj-iBY0E4=Vuuzf5RKbE+2Q@mail.gmail.com>
2015-09-10 14:52 ` Gerd Hoffmann
[not found] ` <1441896765.11233.25.camel@redhat.com>
2015-09-10 15:04 ` Emil Velikov
[not found] ` <CACvgo51skbWdw8E8RftZZjA2wUV0_RHPCiPbSR42XPY9aCfg6w@mail.gmail.com>
2015-09-11 6:32 ` Dave Airlie
[not found] ` <CAPM=9tz_4NSXnmmT6EuXGWp5wUK0vZfUhk-zhnhQ6QTgtEuVfQ@mail.gmail.com>
2015-09-11 9:16 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441893888.11233.3.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).