From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-arch@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
linux-sh@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Ingo Molnar <mingo@kernel.org>
Subject: [PATCH 24/34] sh: define __smp_XXX, fix smp_store_mb for !SMP
Date: Wed, 30 Dec 2015 15:25:57 +0200 [thread overview]
Message-ID: <1451473761-30019-25-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1451473761-30019-1-git-send-email-mst@redhat.com>
sh variant of smp_store_mb() calls xchg() on !SMP which is stronger than
implied by both the name and the documentation.
define __smp_store_mb instead: code in asm-generic/barrier.h
will then define smp_store_mb correctly depending on
CONFIG_SMP.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
arch/sh/include/asm/barrier.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/sh/include/asm/barrier.h b/arch/sh/include/asm/barrier.h
index bf91037..f887c64 100644
--- a/arch/sh/include/asm/barrier.h
+++ b/arch/sh/include/asm/barrier.h
@@ -32,7 +32,8 @@
#define ctrl_barrier() __asm__ __volatile__ ("nop;nop;nop;nop;nop;nop;nop;nop")
#endif
-#define smp_store_mb(var, value) do { (void)xchg(&var, value); } while (0)
+#define __smp_store_mb(var, value) do { (void)xchg(&var, value); } while (0)
+#define smp_store_mb(var, value) __smp_store_mb(var, value)
#include <asm-generic/barrier.h>
--
MST
next prev parent reply other threads:[~2015-12-30 13:25 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-30 13:24 [PATCH 00/34] arch: barrier cleanup + __smp_XXX barriers for virt Michael S. Tsirkin
2015-12-30 13:24 ` [PATCH 01/34] Documentation/memory-barriers.txt: document __smb_mb() Michael S. Tsirkin
2015-12-30 13:24 ` [PATCH 02/34] asm-generic: guard smp_store_release/load_acquire Michael S. Tsirkin
2015-12-30 13:24 ` [PATCH 03/34] ia64: rename nop->iosapic_nop Michael S. Tsirkin
2015-12-30 13:24 ` [PATCH 04/34] ia64: reuse asm-generic/barrier.h Michael S. Tsirkin
2015-12-30 16:41 ` Luck, Tony
2015-12-30 13:24 ` [PATCH 05/34] powerpc: " Michael S. Tsirkin
2015-12-30 13:24 ` [PATCH 06/34] s390: " Michael S. Tsirkin
2015-12-30 13:24 ` [PATCH 07/34] sparc: " Michael S. Tsirkin
2015-12-30 13:24 ` [PATCH 08/34] asm-generic: smp_store_mb should use smp_mb Michael S. Tsirkin
2015-12-30 13:44 ` Arnd Bergmann
[not found] ` <5946017.BCmPrpGMuh@wuerfel>
2015-12-30 20:30 ` Michael S. Tsirkin
[not found] ` <20151230222703-mutt-send-email-mst@redhat.com>
2015-12-30 22:43 ` Arnd Bergmann
2015-12-30 13:24 ` [PATCH 09/34] arm: reuse asm-generic/barrier.h Michael S. Tsirkin
2015-12-30 13:24 ` [PATCH 10/34] arm64: " Michael S. Tsirkin
2015-12-30 13:25 ` [PATCH 11/34] metag: " Michael S. Tsirkin
2015-12-30 13:25 ` [PATCH 12/34] mips: " Michael S. Tsirkin
2015-12-30 13:25 ` [PATCH 13/34] x86/um: " Michael S. Tsirkin
2015-12-30 13:25 ` [PATCH 14/34] x86: " Michael S. Tsirkin
2015-12-30 13:25 ` [PATCH 15/34] asm-generic: add __smp_XXX wrappers Michael S. Tsirkin
2015-12-30 13:25 ` [PATCH 16/34] powerpc: define __smp_XXX Michael S. Tsirkin
2015-12-30 13:25 ` [PATCH 17/34] arm64: " Michael S. Tsirkin
2015-12-30 13:25 ` [PATCH 18/34] arm: " Michael S. Tsirkin
2015-12-30 13:25 ` [PATCH 19/34] blackfin: " Michael S. Tsirkin
2015-12-30 13:25 ` [PATCH 20/34] ia64: " Michael S. Tsirkin
2015-12-30 16:43 ` Luck, Tony
2015-12-30 13:25 ` [PATCH 21/34] metag: " Michael S. Tsirkin
2015-12-30 13:25 ` [PATCH 22/34] mips: " Michael S. Tsirkin
2015-12-30 13:25 ` [PATCH 23/34] s390: " Michael S. Tsirkin
2015-12-30 13:25 ` Michael S. Tsirkin [this message]
2015-12-30 13:26 ` [PATCH 25/34] sparc: " Michael S. Tsirkin
2015-12-30 13:26 ` [PATCH 26/34] tile: " Michael S. Tsirkin
2015-12-30 13:26 ` [PATCH 27/34] xtensa: " Michael S. Tsirkin
2015-12-30 13:26 ` [PATCH 28/34] x86: " Michael S. Tsirkin
2015-12-30 13:26 ` [PATCH 29/34] Revert "virtio_ring: Update weak barriers to use dma_wmb/rmb" Michael S. Tsirkin
2015-12-30 13:26 ` [PATCH 30/34] virtio_ring: update weak barriers to use __smp_XXX Michael S. Tsirkin
2015-12-30 13:26 ` [PATCH 31/34] xenbus: use __smp_XXX barriers Michael S. Tsirkin
2015-12-30 13:26 ` [PATCH 32/34] xen/io: " Michael S. Tsirkin
2015-12-30 13:26 ` [PATCH 33/34] virtio: use __smp_load_acquire/__smp_store_release Michael S. Tsirkin
2015-12-30 13:26 ` [PATCH 34/34] virtio_ring: use __smp_store_mb Michael S. Tsirkin
2015-12-30 13:49 ` [PATCH 00/34] arch: barrier cleanup + __smp_XXX barriers for virt Arnd Bergmann
2015-12-30 21:45 ` [PATCH 00/34] arch: barrier cleanup + __smp_xxx " Michael S. Tsirkin
[not found] ` <20151230234521-mutt-send-email-mst@redhat.com>
2015-12-30 22:45 ` Arnd Bergmann
[not found] ` <1451473761-30019-4-git-send-email-mst@redhat.com>
2015-12-30 16:39 ` [PATCH 03/34] ia64: rename nop->iosapic_nop Luck, Tony
[not found] ` <1451473761-30019-8-git-send-email-mst@redhat.com>
2015-12-30 17:56 ` [PATCH 07/34] sparc: reuse asm-generic/barrier.h David Miller
[not found] ` <20151230.125603.75638711551088484.davem@davemloft.net>
2015-12-30 19:55 ` Michael S. Tsirkin
2015-12-30 20:47 ` David Miller
2015-12-30 20:46 ` [PATCH 00/34] arch: barrier cleanup + __smp_xxx barriers for virt David Miller
2015-12-30 21:36 ` Michael S. Tsirkin
[not found] ` <20151230224855-mutt-send-email-mst@redhat.com>
2015-12-30 21:59 ` David Miller
[not found] ` <1451473761-30019-2-git-send-email-mst@redhat.com>
2016-01-04 11:08 ` [PATCH 01/34] Documentation/memory-barriers.txt: document __smb_mb() Stefano Stabellini
[not found] ` <alpine.DEB.2.02.1601041104290.19710@kaball.uk.xensource.com>
2016-01-04 11:27 ` Michael S. Tsirkin
[not found] ` <1451473761-30019-32-git-send-email-mst@redhat.com>
2016-01-04 11:58 ` [PATCH 31/34] xenbus: use __smp_XXX barriers Stefano Stabellini
[not found] ` <1451473761-30019-33-git-send-email-mst@redhat.com>
2016-01-04 11:59 ` [PATCH 32/34] xen/io: " Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1451473761-30019-25-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=andrew.cooper3@citrix.com \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).