From: "Sinclair Yeh" <syeh@vmware.com>
To: x86@kernel.org
Cc: Sinclair Yeh <syeh@vmware.com>,
pv-drivers@vmware.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-graphics-maintainer@vmware.com
Subject: [PATCH 4/6] Input: Remove vmmouse port reservation
Date: Tue, 19 Jan 2016 13:46:03 -0800 [thread overview]
Message-ID: <1453239965-1466-5-git-send-email-syeh@vmware.com> (raw)
In-Reply-To: <1453239965-1466-1-git-send-email-syeh@vmware.com>
This port is used by quite a few guest-to-host communication
capabilities, e.g. getting configuration, logging, etc. Currently
multiple kernel modules, and one or more priviledged guest user
mode app, e.g. open-vm-tools, use this port without reservation.
It was determined that no reservation is required when accessing
the port in this manner.
Signed-off-by: Sinclair Yeh <syeh@vmware.com>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
Cc: pv-drivers@vmware.com
Cc: linux-graphics-maintainer@vmware.com
Cc: virtualization@lists.linux-foundation.org
Cc: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/input/mouse/vmmouse.c | 19 +------------------
1 file changed, 1 insertion(+), 18 deletions(-)
diff --git a/drivers/input/mouse/vmmouse.c b/drivers/input/mouse/vmmouse.c
index d06daf6..85fb3d47 100644
--- a/drivers/input/mouse/vmmouse.c
+++ b/drivers/input/mouse/vmmouse.c
@@ -347,16 +347,10 @@ int vmmouse_detect(struct psmouse *psmouse, bool set_properties)
return -ENXIO;
}
- if (!request_region(VMMOUSE_PROTO_PORT, 4, "vmmouse")) {
- psmouse_dbg(psmouse, "VMMouse port in use.\n");
- return -EBUSY;
- }
-
/* Check if the device is present */
response = ~VMMOUSE_PROTO_MAGIC;
VMMOUSE_CMD(GETVERSION, 0, version, response, dummy1, dummy2);
if (response != VMMOUSE_PROTO_MAGIC || version == 0xffffffffU) {
- release_region(VMMOUSE_PROTO_PORT, 4);
return -ENXIO;
}
@@ -366,8 +360,6 @@ int vmmouse_detect(struct psmouse *psmouse, bool set_properties)
psmouse->model = version;
}
- release_region(VMMOUSE_PROTO_PORT, 4);
-
return 0;
}
@@ -386,7 +378,6 @@ static void vmmouse_disconnect(struct psmouse *psmouse)
psmouse_reset(psmouse);
input_unregister_device(priv->abs_dev);
kfree(priv);
- release_region(VMMOUSE_PROTO_PORT, 4);
}
/**
@@ -430,15 +421,10 @@ int vmmouse_init(struct psmouse *psmouse)
struct input_dev *rel_dev = psmouse->dev, *abs_dev;
int error;
- if (!request_region(VMMOUSE_PROTO_PORT, 4, "vmmouse")) {
- psmouse_dbg(psmouse, "VMMouse port in use.\n");
- return -EBUSY;
- }
-
psmouse_reset(psmouse);
error = vmmouse_enable(psmouse);
if (error)
- goto release_region;
+ return error;
priv = kzalloc(sizeof(*priv), GFP_KERNEL);
abs_dev = input_allocate_device();
@@ -493,8 +479,5 @@ init_fail:
kfree(priv);
psmouse->private = NULL;
-release_region:
- release_region(VMMOUSE_PROTO_PORT, 4);
-
return error;
}
--
1.9.1
next prev parent reply other threads:[~2016-01-19 21:46 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1449008047-8252-1-git-send-email-syeh@vmware.com>
2015-12-01 22:18 ` [PATCH 1/6] x86: Add VMWare Host Communication Macros Sinclair Yeh
2015-12-01 22:18 ` [PATCH 2/6] x86: Update vmware.c to use the common VMW_PORT macros Sinclair Yeh
2015-12-01 22:18 ` [PATCH 3/6] Input: Update vmmouse.c " Sinclair Yeh
2015-12-01 22:24 ` Dmitry Torokhov
[not found] ` <20151201222414.GH3740@dtor-ws>
2015-12-01 22:32 ` Sinclair Yeh
[not found] ` <20151201223255.GA10753@syeh-linux>
2015-12-01 22:45 ` Dmitry Torokhov
[not found] ` <CAKdAkRTVJ_DWD6uYhp+qd1uYwe3rPguDFAMXpa5=8CwVuO16NQ@mail.gmail.com>
2015-12-01 22:54 ` Sinclair Yeh
2015-12-01 23:56 ` Dmitry Torokhov
2015-12-02 0:04 ` Greg Kroah-Hartman
2015-12-02 2:21 ` Sinclair Yeh
2015-12-02 7:07 ` [Linux-graphics-maintainer] " Thomas Hellstrom
[not found] ` <20151202022106.GA6471@syeh-linux>
2015-12-02 15:31 ` Greg Kroah-Hartman
2015-12-02 15:57 ` Sinclair Yeh
2015-12-02 17:26 ` Dmitry Torokhov
2015-12-02 17:29 ` [Linux-graphics-maintainer] " Thomas Hellstrom
2015-12-02 18:45 ` Greg Kroah-Hartman
2015-12-02 18:58 ` Dmitry Torokhov
2015-12-02 19:02 ` Sinclair Yeh
2015-12-02 0:01 ` Greg Kroah-Hartman
2015-12-01 22:18 ` [PATCH 4/6] Input: Remove vmmouse port reservation Sinclair Yeh
2015-12-01 22:18 ` [PATCH 6/6] VMware balloon: Update vmw_balloon.c to use the VMW_PORT macro Sinclair Yeh
[not found] ` <1449008332-9394-4-git-send-email-syeh@vmware.com>
2015-12-01 22:30 ` [PATCH 4/6] Input: Remove vmmouse port reservation Dmitry Torokhov
2015-12-01 23:04 ` Sinclair Yeh
2015-12-01 23:52 ` Dmitry Torokhov
2015-12-01 22:32 ` [PATCH 1/6] x86: Add VMWare Host Communication Macros Xavier Deguillard
[not found] ` <1449008332-9394-6-git-send-email-syeh@vmware.com>
2015-12-01 22:38 ` [PATCH 6/6] VMware balloon: Update vmw_balloon.c to use the VMW_PORT macro Xavier Deguillard
[not found] ` <20151201223801.GN24642@xdeguillard-ws.eng.vmware.com>
2015-12-01 23:17 ` Sinclair Yeh
2015-12-01 22:49 ` [PATCH 1/6] x86: Add VMWare Host Communication Macros H. Peter Anvin
[not found] ` <565E23E7.5090800@zytor.com>
2015-12-04 22:33 ` Sinclair Yeh
[not found] ` <1449271183-1746-1-git-send-email-syeh@vmware.com>
2015-12-04 23:19 ` Sinclair Yeh
2015-12-04 23:19 ` [PATCH 2/6] x86: Update vmware.c to use the common VMW_PORT macros Sinclair Yeh
2015-12-04 23:19 ` [PATCH 3/6] Input: Update vmmouse.c " Sinclair Yeh
2015-12-04 23:19 ` [PATCH 4/6] Input: Remove vmmouse port reservation Sinclair Yeh
2015-12-04 23:19 ` [PATCH 6/6] VMware balloon: Update vmw_balloon.c to use the VMW_PORT macro Sinclair Yeh
[not found] ` <1453239965-1466-1-git-send-email-syeh@vmware.com>
2016-01-19 21:46 ` [PATCH 1/6] x86: Add VMWare Host Communication Macros Sinclair Yeh
2016-01-19 21:46 ` [PATCH 2/6] x86: Update vmware.c to use the common VMW_PORT macros Sinclair Yeh
2016-01-19 21:46 ` [PATCH 3/6] Input: Update vmmouse.c " Sinclair Yeh
2016-01-19 21:46 ` Sinclair Yeh [this message]
2016-01-19 21:46 ` [PATCH 6/6] VMware balloon: Update vmw_balloon.c to use the VMW_PORT macro Sinclair Yeh
2016-02-08 19:41 ` Greg KH
2016-03-31 14:39 ` Sinclair Yeh
[not found] ` <20160331143953.GA23662@syeh-linux>
2016-03-31 16:30 ` Greg KH
2016-03-31 17:32 ` Sinclair Yeh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453239965-1466-5-git-send-email-syeh@vmware.com \
--to=syeh@vmware.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).