* [PATCH] sh: fix smp_store_mb for !SMP
@ 2016-01-21 10:29 Michael S. Tsirkin
0 siblings, 0 replies; only message in thread
From: Michael S. Tsirkin @ 2016-01-21 10:29 UTC (permalink / raw)
To: linux-kernel
Cc: linux-arch, Arnd Bergmann, linux-sh, Peter Zijlstra,
virtualization, Linus Torvalds, Ingo Molnar
sh variant of smp_store_mb() calls xchg() on !SMP which is stronger than
implied by both the name and the documentation.
commit 90a3ccb0be538a914e6a5c51ae919762261563ad ("sh: define __smp_xxx,
fix smp_store_mb for !SMP") was supposed to fix it but
left the bug in place.
Drop smp_store_mb, so that code in asm-generic/barrier.h
will define it correctly depending on CONFIG_SMP.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
I put this in my tree as that's where the original commit
came through, but if anyone else prefers to merge it, pls
let me know.
arch/sh/include/asm/barrier.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/sh/include/asm/barrier.h b/arch/sh/include/asm/barrier.h
index f887c64..8a84e05 100644
--- a/arch/sh/include/asm/barrier.h
+++ b/arch/sh/include/asm/barrier.h
@@ -33,7 +33,6 @@
#endif
#define __smp_store_mb(var, value) do { (void)xchg(&var, value); } while (0)
-#define smp_store_mb(var, value) __smp_store_mb(var, value)
#include <asm-generic/barrier.h>
--
MST
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-01-21 10:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-21 10:29 [PATCH] sh: fix smp_store_mb for !SMP Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).