From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org, linux-kernel@vger.kernel.org
Cc: Wei Liu <wei.liu2@citrix.com>, Andy Lutomirski <luto@kernel.org>,
qemu-block@nongnu.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
peterx@redhat.com, virtualization@lists.linux-foundation.org,
Amit Shah <amit.shah@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
kvm@vger.kernel.org, pbonzini@redhat.com,
David Woodhouse <dwmw2@infradead.org>
Subject: [PATCH RFC] fixup! virtio: convert to use DMA api
Date: Mon, 18 Apr 2016 14:47:24 +0300 [thread overview]
Message-ID: <1460979793-6621-1-git-send-email-mst__32001.4879609973$1460980072$gmane$org@redhat.com> (raw)
This adds a flag to enable/disable bypassing the IOMMU by
virtio devices.
This is on top of patch
http://article.gmane.org/gmane.comp.emulators.qemu/403467
virtio: convert to use DMA api
Tested with patchset
http://article.gmane.org/gmane.linux.kernel.virtualization/27545
virtio-pci: iommu support
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/hw/virtio/virtio-access.h | 3 ++-
include/hw/virtio/virtio.h | 6 +++++-
include/standard-headers/linux/virtio_config.h | 8 ++++++++
3 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/include/hw/virtio/virtio-access.h b/include/hw/virtio/virtio-access.h
index 967cc75..bb6f34e 100644
--- a/include/hw/virtio/virtio-access.h
+++ b/include/hw/virtio/virtio-access.h
@@ -23,7 +23,8 @@ static inline AddressSpace *virtio_get_dma_as(VirtIODevice *vdev)
BusState *qbus = qdev_get_parent_bus(DEVICE(vdev));
VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus);
- if (k->get_dma_as) {
+ if ((vdev->host_features & (0x1ULL << VIRTIO_F_IOMMU_PLATFORM)) &&
+ k->get_dma_as) {
return k->get_dma_as(qbus->parent);
}
return &address_space_memory;
diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index b12faa9..34d3041 100644
--- a/include/hw/virtio/virtio.h
+++ b/include/hw/virtio/virtio.h
@@ -228,7 +228,11 @@ typedef struct VirtIORNGConf VirtIORNGConf;
DEFINE_PROP_BIT64("notify_on_empty", _state, _field, \
VIRTIO_F_NOTIFY_ON_EMPTY, true), \
DEFINE_PROP_BIT64("any_layout", _state, _field, \
- VIRTIO_F_ANY_LAYOUT, true)
+ VIRTIO_F_ANY_LAYOUT, true), \
+ DEFINE_PROP_BIT64("iommu_passthrough", _state, _field, \
+ VIRTIO_F_IOMMU_PASSTHROUGH, false), \
+ DEFINE_PROP_BIT64("iommu_platform", _state, _field, \
+ VIRTIO_F_IOMMU_PLATFORM, false)
hwaddr virtio_queue_get_desc_addr(VirtIODevice *vdev, int n);
hwaddr virtio_queue_get_avail_addr(VirtIODevice *vdev, int n);
diff --git a/include/standard-headers/linux/virtio_config.h b/include/standard-headers/linux/virtio_config.h
index bcc445b..5564dab 100644
--- a/include/standard-headers/linux/virtio_config.h
+++ b/include/standard-headers/linux/virtio_config.h
@@ -61,4 +61,12 @@
/* v1.0 compliant. */
#define VIRTIO_F_VERSION_1 32
+/* Request IOMMU passthrough (if available)
+ * Without VIRTIO_F_IOMMU_PLATFORM: bypass the IOMMU even if enabled.
+ * With VIRTIO_F_IOMMU_PLATFORM: suggest disabling IOMMU.
+ */
+#define VIRTIO_F_IOMMU_PASSTHROUGH 33
+
+/* Do not bypass the IOMMU (if configured) */
+#define VIRTIO_F_IOMMU_PLATFORM 34
#endif /* _LINUX_VIRTIO_CONFIG_H */
--
MST
next reply other threads:[~2016-04-18 11:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 11:47 Michael S. Tsirkin [this message]
[not found] <1460979793-6621-1-git-send-email-mst@redhat.com>
2016-04-18 11:58 ` [PATCH RFC] fixup! virtio: convert to use DMA api David Woodhouse
[not found] ` <1460980717.12793.43.camel@infradead.org>
2016-04-18 13:12 ` Michael S. Tsirkin
[not found] ` <20160418160731-mutt-send-email-mst@redhat.com>
2016-04-18 14:03 ` David Woodhouse
[not found] ` <1460988232.22654.7.camel@infradead.org>
2016-04-18 14:23 ` Michael S. Tsirkin
2016-04-18 15:22 ` David Woodhouse
2016-04-18 15:30 ` Michael S. Tsirkin
2016-04-18 15:51 ` David Woodhouse
2016-04-18 16:27 ` Michael S. Tsirkin
2016-04-18 18:29 ` David Woodhouse
2016-04-18 19:24 ` Andy Lutomirski
2016-04-19 10:27 ` Michael S. Tsirkin
2016-04-19 16:02 ` Andy Lutomirski
[not found] ` <CALCETrX72XV25B-0GdaMyJNkJRvvC8MbT4G=L5oGR=D5stpG6w@mail.gmail.com>
2016-04-19 16:09 ` Michael S. Tsirkin
[not found] ` <20160419190520-mutt-send-email-mst@redhat.com>
2016-04-19 16:12 ` Andy Lutomirski
2016-04-19 16:20 ` Michael S. Tsirkin
2016-04-19 16:26 ` David Woodhouse
2016-04-19 17:49 ` Michael S. Tsirkin
[not found] ` <20160419204907-mutt-send-email-mst@redhat.com>
2016-04-19 18:01 ` Andy Lutomirski
[not found] ` <CALCETrXsbYj5c3j2em2-jrhBWp-VqRJd900s5WDdVUMCN2aiNg@mail.gmail.com>
2016-04-19 20:16 ` Michael S. Tsirkin
[not found] ` <20160419231437-mutt-send-email-mst@redhat.com>
2016-04-19 20:27 ` Andy Lutomirski
[not found] ` <CALCETrXqrbwvStj9MhKizceze56SAFH_hUJwsQ83NsSRzWiq8Q@mail.gmail.com>
2016-04-19 20:54 ` Michael S. Tsirkin
[not found] ` <20160419235212-mutt-send-email-mst@redhat.com>
2016-04-19 21:07 ` Andy Lutomirski
[not found] ` <CALCETrUif0iAFWFsz-i848yUO9WrXZ7q+Kx3-4wu-dQRiuCweg@mail.gmail.com>
2016-04-20 13:14 ` Michael S. Tsirkin
2016-04-20 15:43 ` Andy Lutomirski
2016-04-19 9:13 ` Michael S. Tsirkin
2016-04-19 14:44 ` Alex Williamson
2016-04-19 16:00 ` Andy Lutomirski
[not found] ` <CALCETrVBo-XBD53eStOCwJd53F7_VTnrMJ9rY7_cXwnt2Z6AOw@mail.gmail.com>
2016-04-19 16:04 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='1460979793-6621-1-git-send-email-mst__32001.4879609973$1460980072$gmane$org@redhat.com' \
--to=mst@redhat.com \
--cc=amit.shah@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=dwmw2@infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.liu2@citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).