* [PATCH v3] tools/virtio/ringtest: fix run-on-all.sh to work without /dev/cpu [not found] <20160504101454.2b62e974.cornelia.huck@de.ibm.com> @ 2016-05-04 10:15 ` Mike Rapoport 2016-05-04 10:24 ` Cornelia Huck 2016-05-24 12:41 ` Mike Rapoport 0 siblings, 2 replies; 5+ messages in thread From: Mike Rapoport @ 2016-05-04 10:15 UTC (permalink / raw) To: Michael S. Tsirkin; +Cc: Mike Rapoport, kvm, virtualization /dev/cpu is only available on x86 with certain modules (e.g. msr) enabled. Using lscpu to get processors count is more portable. Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com> --- v3: simplify by using lscpu -p=cpu v2: use lspcu instead of /proc/cpuinfo as per Cornelia's suggestion tools/virtio/ringtest/run-on-all.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virtio/ringtest/run-on-all.sh b/tools/virtio/ringtest/run-on-all.sh index 52b0f71..2e69ca8 100755 --- a/tools/virtio/ringtest/run-on-all.sh +++ b/tools/virtio/ringtest/run-on-all.sh @@ -3,10 +3,10 @@ #use last CPU for host. Why not the first? #many devices tend to use cpu0 by default so #it tends to be busier -HOST_AFFINITY=$(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n|tail -1) +HOST_AFFINITY=$(lscpu -p=cpu | tail -1) #run command on all cpus -for cpu in $(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n); +for cpu in $(seq 0 $HOST_AFFINITY) do #Don't run guest and host on same CPU #It actually works ok if using signalling -- 1.9.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3] tools/virtio/ringtest: fix run-on-all.sh to work without /dev/cpu 2016-05-04 10:15 ` [PATCH v3] tools/virtio/ringtest: fix run-on-all.sh to work without /dev/cpu Mike Rapoport @ 2016-05-04 10:24 ` Cornelia Huck 2016-05-24 12:41 ` Mike Rapoport 1 sibling, 0 replies; 5+ messages in thread From: Cornelia Huck @ 2016-05-04 10:24 UTC (permalink / raw) To: Mike Rapoport; +Cc: virtualization, kvm, Michael S. Tsirkin On Wed, 4 May 2016 13:15:50 +0300 Mike Rapoport <rppt@linux.vnet.ibm.com> wrote: > /dev/cpu is only available on x86 with certain modules (e.g. msr) enabled. > Using lscpu to get processors count is more portable. > > Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com> > --- > v3: simplify by using lscpu -p=cpu > v2: use lspcu instead of /proc/cpuinfo as per Cornelia's suggestion > > tools/virtio/ringtest/run-on-all.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/virtio/ringtest/run-on-all.sh b/tools/virtio/ringtest/run-on-all.sh > index 52b0f71..2e69ca8 100755 > --- a/tools/virtio/ringtest/run-on-all.sh > +++ b/tools/virtio/ringtest/run-on-all.sh > @@ -3,10 +3,10 @@ > #use last CPU for host. Why not the first? > #many devices tend to use cpu0 by default so > #it tends to be busier > -HOST_AFFINITY=$(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n|tail -1) > +HOST_AFFINITY=$(lscpu -p=cpu | tail -1) > > #run command on all cpus > -for cpu in $(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n); > +for cpu in $(seq 0 $HOST_AFFINITY) > do > #Don't run guest and host on same CPU > #It actually works ok if using signalling I think it's fine to depend on lscpu for such a test tool. Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] tools/virtio/ringtest: fix run-on-all.sh to work without /dev/cpu 2016-05-04 10:15 ` [PATCH v3] tools/virtio/ringtest: fix run-on-all.sh to work without /dev/cpu Mike Rapoport 2016-05-04 10:24 ` Cornelia Huck @ 2016-05-24 12:41 ` Mike Rapoport 2016-06-06 6:55 ` Mike Rapoport [not found] ` <201606060656.u566rhsn006487@mx0a-001b2d01.pphosted.com> 1 sibling, 2 replies; 5+ messages in thread From: Mike Rapoport @ 2016-05-24 12:41 UTC (permalink / raw) To: Michael S. Tsirkin; +Cc: kvm, virtualization Michael, Any updates on this? On Wed, May 04, 2016 at 01:15:50PM +0300, Mike Rapoport wrote: > /dev/cpu is only available on x86 with certain modules (e.g. msr) enabled. > Using lscpu to get processors count is more portable. > > Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com> > --- > v3: simplify by using lscpu -p=cpu > v2: use lspcu instead of /proc/cpuinfo as per Cornelia's suggestion > > tools/virtio/ringtest/run-on-all.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/virtio/ringtest/run-on-all.sh b/tools/virtio/ringtest/run-on-all.sh > index 52b0f71..2e69ca8 100755 > --- a/tools/virtio/ringtest/run-on-all.sh > +++ b/tools/virtio/ringtest/run-on-all.sh > @@ -3,10 +3,10 @@ > #use last CPU for host. Why not the first? > #many devices tend to use cpu0 by default so > #it tends to be busier > -HOST_AFFINITY=$(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n|tail -1) > +HOST_AFFINITY=$(lscpu -p=cpu | tail -1) > > #run command on all cpus > -for cpu in $(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n); > +for cpu in $(seq 0 $HOST_AFFINITY) > do > #Don't run guest and host on same CPU > #It actually works ok if using signalling > -- > 1.9.1 > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] tools/virtio/ringtest: fix run-on-all.sh to work without /dev/cpu 2016-05-24 12:41 ` Mike Rapoport @ 2016-06-06 6:55 ` Mike Rapoport [not found] ` <201606060656.u566rhsn006487@mx0a-001b2d01.pphosted.com> 1 sibling, 0 replies; 5+ messages in thread From: Mike Rapoport @ 2016-06-06 6:55 UTC (permalink / raw) To: Michael S. Tsirkin; +Cc: kvm, virtualization Ping? On Tue, May 24, 2016 at 03:41:33PM +0300, Mike Rapoport wrote: > Michael, > > Any updates on this? > > On Wed, May 04, 2016 at 01:15:50PM +0300, Mike Rapoport wrote: > > /dev/cpu is only available on x86 with certain modules (e.g. msr) enabled. > > Using lscpu to get processors count is more portable. > > > > Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com> > > --- > > v3: simplify by using lscpu -p=cpu > > v2: use lspcu instead of /proc/cpuinfo as per Cornelia's suggestion > > > > tools/virtio/ringtest/run-on-all.sh | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/tools/virtio/ringtest/run-on-all.sh b/tools/virtio/ringtest/run-on-all.sh > > index 52b0f71..2e69ca8 100755 > > --- a/tools/virtio/ringtest/run-on-all.sh > > +++ b/tools/virtio/ringtest/run-on-all.sh > > @@ -3,10 +3,10 @@ > > #use last CPU for host. Why not the first? > > #many devices tend to use cpu0 by default so > > #it tends to be busier > > -HOST_AFFINITY=$(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n|tail -1) > > +HOST_AFFINITY=$(lscpu -p=cpu | tail -1) > > > > #run command on all cpus > > -for cpu in $(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n); > > +for cpu in $(seq 0 $HOST_AFFINITY) > > do > > #Don't run guest and host on same CPU > > #It actually works ok if using signalling > > -- > > 1.9.1 > > > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <201606060656.u566rhsn006487@mx0a-001b2d01.pphosted.com>]
* Re: [PATCH v3] tools/virtio/ringtest: fix run-on-all.sh to work without /dev/cpu [not found] ` <201606060656.u566rhsn006487@mx0a-001b2d01.pphosted.com> @ 2016-06-06 13:57 ` Michael S. Tsirkin 0 siblings, 0 replies; 5+ messages in thread From: Michael S. Tsirkin @ 2016-06-06 13:57 UTC (permalink / raw) To: Mike Rapoport; +Cc: kvm, virtualization It's queued in my tree and will be merged shortly. Thanks! On Mon, Jun 06, 2016 at 09:55:59AM +0300, Mike Rapoport wrote: > Ping? > > On Tue, May 24, 2016 at 03:41:33PM +0300, Mike Rapoport wrote: > > Michael, > > > > Any updates on this? > > > > On Wed, May 04, 2016 at 01:15:50PM +0300, Mike Rapoport wrote: > > > /dev/cpu is only available on x86 with certain modules (e.g. msr) enabled. > > > Using lscpu to get processors count is more portable. > > > > > > Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com> > > > --- > > > v3: simplify by using lscpu -p=cpu > > > v2: use lspcu instead of /proc/cpuinfo as per Cornelia's suggestion > > > > > > tools/virtio/ringtest/run-on-all.sh | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/tools/virtio/ringtest/run-on-all.sh b/tools/virtio/ringtest/run-on-all.sh > > > index 52b0f71..2e69ca8 100755 > > > --- a/tools/virtio/ringtest/run-on-all.sh > > > +++ b/tools/virtio/ringtest/run-on-all.sh > > > @@ -3,10 +3,10 @@ > > > #use last CPU for host. Why not the first? > > > #many devices tend to use cpu0 by default so > > > #it tends to be busier > > > -HOST_AFFINITY=$(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n|tail -1) > > > +HOST_AFFINITY=$(lscpu -p=cpu | tail -1) > > > > > > #run command on all cpus > > > -for cpu in $(cd /dev/cpu; ls|grep -v '[a-z]'|sort -n); > > > +for cpu in $(seq 0 $HOST_AFFINITY) > > > do > > > #Don't run guest and host on same CPU > > > #It actually works ok if using signalling > > > -- > > > 1.9.1 > > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe kvm" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-06-06 13:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20160504101454.2b62e974.cornelia.huck@de.ibm.com>
2016-05-04 10:15 ` [PATCH v3] tools/virtio/ringtest: fix run-on-all.sh to work without /dev/cpu Mike Rapoport
2016-05-04 10:24 ` Cornelia Huck
2016-05-24 12:41 ` Mike Rapoport
2016-06-06 6:55 ` Mike Rapoport
[not found] ` <201606060656.u566rhsn006487@mx0a-001b2d01.pphosted.com>
2016-06-06 13:57 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).