From: Wendy Liang <wendy.liang@xilinx.com>
To: virtualization@lists.linux-foundation.org, edgari@xilinx.com,
cyrilc@xilinx.com
Cc: Wendy Liang <jliang@xilinx.com>
Subject: [RFC LINUX PATCH 1/2] virtio_ring: Do not call dma_map_page if sg is already mapped.
Date: Mon, 21 Nov 2016 16:32:42 -0800 [thread overview]
Message-ID: <1479774763-28188-2-git-send-email-jliang@xilinx.com> (raw)
In-Reply-To: <1479774763-28188-1-git-send-email-jliang@xilinx.com>
If sg is already dma mapped, do not call dma_map_page() in
vring_map_one_sg().
In case of rpmsg, rpmsg uses dma_alloc_coherent() to allocate
memory to share with the remote. There is no pages setup
in dma_alloc_coherent().
In this case, we cannot convert the virtual address back to the
physical address. In this case, we can setup the sg_dma_addr to
store the DMA address, and also mark the sg is already mapped.
In the vring, we can detect if the address is already mapped
by checking the sg_dma_addr. If yes, do not call dma_map_page().
Signed-off-by: Wendy Liang <jliang@xilinx.com>
---
drivers/virtio/virtio_ring.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
index 489bfc6..9793e1f 100644
--- a/drivers/virtio/virtio_ring.c
+++ b/drivers/virtio/virtio_ring.c
@@ -180,6 +180,12 @@ static dma_addr_t vring_map_one_sg(const struct vring_virtqueue *vq,
if (!vring_use_dma_api(vq->vq.vdev))
return (dma_addr_t)sg_phys(sg);
+ /* If the sg is already mapped, return the DMA address */
+ if (sg_dma_address(sg)) {
+ sg->length = sg_dma_len(sg);
+ return sg_dma_address(sg);
+ }
+
/*
* We can't use dma_map_sg, because we don't use scatterlists in
* the way it expects (we don't guarantee that the scatterlist
--
1.9.1
next prev parent reply other threads:[~2016-11-22 0:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 0:32 [RFC LINUX PATCH 0/2] Virtio ring works with DMA coherent memory Wendy Liang
2016-11-22 0:32 ` Wendy Liang [this message]
2016-11-22 0:32 ` [RFC LINUX PATCH 2/2] rpmsg: DMA map sgs passed to virtio Wendy Liang
-- strict thread matches above, loose matches on Subject: below --
2016-12-06 18:08 [RFC LINUX PATCH 0/2] Virtio ring works with DMA coherent memory Wendy Liang
2016-12-06 18:08 ` [RFC LINUX PATCH 1/2] virtio_ring: Do not call dma_map_page if sg is already mapped Wendy Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479774763-28188-2-git-send-email-jliang@xilinx.com \
--to=wendy.liang@xilinx.com \
--cc=cyrilc@xilinx.com \
--cc=edgari@xilinx.com \
--cc=jliang@xilinx.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).