From: Phi Nguyen <phind.uet@gmail.com>
To: Michal Luczaj <mhal@rbox.co>, Stefano Garzarella <sgarzare@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
syzbot+1b2c9c4a0f8708082678@syzkaller.appspotmail.com,
virtualization@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vsock: use sock_error() to consume sk_err after connect timeout
Date: Thu, 30 Jul 2026 00:51:55 +0800 [thread overview]
Message-ID: <148e56ec-dc26-4be2-a7af-eb547b517a68@gmail.com> (raw)
In-Reply-To: <bf3a61f0-cd82-4796-a3ce-d6de8c8dd7ae@rbox.co>
On 7/29/2026 11:49 PM, Michal Luczaj wrote:
> On 7/29/26 15:29, Stefano Garzarella wrote:
>>
>> This is a good point!
>>
>> So we still need to remove `sk_err` check in vsock_accept(), or set
>> `sk->sk_err = 0` in vsock_listen() to have a complete fix, right?
>
> Yup, that's my understanding as well.
>
> That said, I'm not against flushing sk_err on a failed blocking connect()
> (this patch) as a follow up, if you guys agree that makes vsock behave like
> other socket families.
IMO, we should remove the sk_err check in vsock_accept() and invoke
sock_error() in vsock_connnect()
Thanks,
Phi
prev parent reply other threads:[~2026-07-29 16:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-19 21:57 [PATCH] vsock: use sock_error() to consume sk_err after connect timeout Nguyen Dinh Phi
2026-07-20 8:17 ` Stefano Garzarella
2026-07-20 17:34 ` Phi Nguyen
2026-07-22 7:55 ` Stefano Garzarella
2026-07-23 4:14 ` Nguyen Dinh Phi [SG]
2026-07-23 6:00 ` Michal Luczaj
2026-07-23 8:24 ` Stefano Garzarella
2026-07-23 10:26 ` Nguyen Dinh Phi [SG]
2026-07-23 21:43 ` Michal Luczaj
2026-07-24 7:34 ` Nguyen Dinh Phi [SG]
2026-07-28 8:21 ` Stefano Garzarella
2026-07-29 9:46 ` Nguyen Dinh Phi [SG]
2026-07-29 13:03 ` Stefano Garzarella
2026-07-29 13:20 ` Michal Luczaj
2026-07-29 13:29 ` Stefano Garzarella
2026-07-29 15:49 ` Michal Luczaj
2026-07-29 16:51 ` Phi Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=148e56ec-dc26-4be2-a7af-eb547b517a68@gmail.com \
--to=phind.uet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhal@rbox.co \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sgarzare@redhat.com \
--cc=syzbot+1b2c9c4a0f8708082678@syzkaller.appspotmail.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox