* [RFC] virtio_blk: add DISCARD support to virtio_blk driver
@ 2017-03-20 4:56 Changpeng Liu
0 siblings, 0 replies; 3+ messages in thread
From: Changpeng Liu @ 2017-03-20 4:56 UTC (permalink / raw)
To: virtualization; +Cc: changpeng.liu
Currently virtio_blk driver does not provide discard feature
flag, so the filesystems which built on top of the block device
will not send discard command. This is okay for HDD backend, but
it will impact the performance for SSD backend.
Add a feature flag such as VIRTIO_BLK_F_DISCARD to virtio_blk driver
is very straightforward, but it will extend the exist virtio_blk
protocol, I'm preparing to add this feature, before that, I'd like
to get comments or suggestions from community.
---
1.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RFC] virtio_blk: add DISCARD support to virtio_blk driver
@ 2017-03-17 1:34 Changpeng Liu
2017-03-20 15:28 ` Stefan Hajnoczi
0 siblings, 1 reply; 3+ messages in thread
From: Changpeng Liu @ 2017-03-17 1:34 UTC (permalink / raw)
To: virtualization; +Cc: changpeng.liu, mst
Currently virtio_blk driver does not provide discard feature
flag, so the filesystems which built on top of the block device
will not send discard command. This is okay for HDD backend, but
it will impact the performance for SSD backend.
Add a feature flag such as VIRTIO_BLK_F_DISCARD to virtio_blk driver
is very straightforward, but it will extend the exist virtio_blk
protocol, I'm preparing to add this feature, before that, I'd like
to get comments or suggestions from community.
---
1.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC] virtio_blk: add DISCARD support to virtio_blk driver
2017-03-17 1:34 Changpeng Liu
@ 2017-03-20 15:28 ` Stefan Hajnoczi
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2017-03-20 15:28 UTC (permalink / raw)
To: Changpeng Liu; +Cc: Paolo Bonzini, Michael S. Tsirkin, Linux Virtualization
On Fri, Mar 17, 2017 at 1:34 AM, Changpeng Liu <changpeng.liu@intel.com> wrote:
> Currently virtio_blk driver does not provide discard feature
> flag, so the filesystems which built on top of the block device
> will not send discard command. This is okay for HDD backend, but
> it will impact the performance for SSD backend.
>
> Add a feature flag such as VIRTIO_BLK_F_DISCARD to virtio_blk driver
> is very straightforward, but it will extend the exist virtio_blk
> protocol, I'm preparing to add this feature, before that, I'd like
> to get comments or suggestions from community.
Please remember to also send a VIRTIO spec change:
https://www.oasis-open.org/committees/tc_home.php?wg_abbrev=virtio#feedback
This feature was not added to virtio-blk in the past because
virtio-scsi was essentially a replacement that could support all disk
I/O features (thanks to the SCSI command set). There are many
virtio-blk users and some may not want to migrate to virtio-scsi. So
it seems reasonable to add a DISCARD command to virtio-blk.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-20 15:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-20 4:56 [RFC] virtio_blk: add DISCARD support to virtio_blk driver Changpeng Liu
-- strict thread matches above, loose matches on Subject: below --
2017-03-17 1:34 Changpeng Liu
2017-03-20 15:28 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).