From: Amos Kong <akong@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio-spec: serial: english tweak
Date: Tue, 4 Dec 2012 01:08:43 -0500 (EST) [thread overview]
Message-ID: <1493537565.18025348.1354601323962.JavaMail.root@redhat.com> (raw)
In-Reply-To: <20120909121116.GA2972@redhat.com>
----- Original Message -----
> "A number of virtqueues are created" seems clearer
> than "the number of virtqueues": it's
> virtqueues that are created not the number.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Amos Kong <akong@redhat.com>
Two opposite problem exists:
--- virtio-0.9.5.lyx.orig 2012-12-04 09:29:03.249676649 +0800
+++ virtio-0.9.5.lyx 2012-12-04 09:28:26.272678220 +0800
@@ -8685,7 +8685,7 @@ s on QueueNum, QueueAlign and QueuePFN a
\begin_inset Newline newline
\end_inset
- Queue size is a number of elements in the queue, therefore size of the
+ Queue size is the number of elements in the queue, therefore size of the
descriptor table and both available and used rings.
\begin_inset Newline newline
\end_inset
@@ -8850,7 +8850,7 @@ reference "sub:Device-Initialization-Seq
\end_layout
\begin_layout Standard
-Virtual queue size is a number of elements in the queue, therefore size
+Virtual queue size is the number of elements in the queue, therefore size
of the descriptor table and both available and used rings.
\end_layout
> ---
>
> I'm not a native english speaker but the below
> seems correct to me. Rusty?
>
> virtio-spec.lyx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/virtio-spec.lyx b/virtio-spec.lyx
> index d9626a9..a29315c 100644
> --- a/virtio-spec.lyx
> +++ b/virtio-spec.lyx
> @@ -6406,7 +6406,7 @@ If the VIRTIO_CONSOLE_F_MULTIPORT feature is
> negotiated, the driver can
> spawn multiple ports, not all of which may be attached to a
> console.
> Some could be generic ports.
> In this case, the control virtqueues are enabled and according to
> the max_nr_po
> -rts configuration-space value, the appropriate number of virtqueues
> are
> +rts configuration-space value, an appropriate number of virtqueues
> are
> created.
> A control message indicating the driver is ready is sent to the
> host.
> The host can then send control messages for adding new ports to the
> device.
> --
> MST
> _______________________________________________
> Virtualization mailing list
> Virtualization@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/virtualization
>
next prev parent reply other threads:[~2012-12-04 6:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-09 12:11 [PATCH] virtio-spec: serial: english tweak Michael S. Tsirkin
2012-09-09 20:58 ` Amit Shah
2012-11-12 16:56 ` Michael S. Tsirkin
2012-12-04 6:08 ` Amos Kong [this message]
2013-01-03 0:15 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493537565.18025348.1354601323962.JavaMail.root@redhat.com \
--to=akong@redhat.com \
--cc=amit.shah@redhat.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).