From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dmitry Torokhov <dtor@vmware.com>
Subject: Re: [Pv-drivers] [PATCH 04/10] VMCI: device driver implementaton.
Date: Thu, 25 Oct 2012 13:45:39 -0700
Message-ID: <1635399.c93qq9Svfo@dtor-d630.eng.vmware.com>
References: <20121025192851.GA26627@kroah.com>
	<574849395.2604157.1351196160882.JavaMail.root@vmware.com>
	<20121025203148.GA28096@kroah.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <virtualization-bounces@lists.linux-foundation.org>
In-Reply-To: <20121025203148.GA28096@kroah.com>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/virtualization>,
	<mailto:virtualization-request@lists.linux-foundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/virtualization/>
List-Post: <mailto:virtualization@lists.linux-foundation.org>
List-Help: <mailto:virtualization-request@lists.linux-foundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/virtualization>,
	<mailto:virtualization-request@lists.linux-foundation.org?subject=subscribe>
Sender: virtualization-bounces@lists.linux-foundation.org
Errors-To: virtualization-bounces@lists.linux-foundation.org
To: pv-drivers@vmware.com
Cc: Andy King <acking@vmware.com>, Greg KH <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, vm-crosstalk@vmware.com, George Zhang <georgezhang@vmware.com>
List-Id: virtualization@lists.linuxfoundation.org

On Thursday, October 25, 2012 01:31:48 PM Greg KH wrote:
> On Thu, Oct 25, 2012 at 01:16:00PM -0700, Andy King wrote:
> > Hi Greg,
> > 
> > > > +EXPORT_SYMBOL(vmci_device_get);
> > > 
> > > EXPORT_SYMBOL_GPL() for this, and all other exports?
> > 
> > We'd prefer to leave them as vanilla exports.  While we're committed
> > to open-sourcing everything, including our non-upstreamed drivers,
> > we don't really have a strong opinion regarding consuming our exports
> > in closed-source (general GPL issues aside).
> 
> You can't just say "general GPL issues aside".  Honestly, given your
> company's prior actions in regards to Linux kernel drivers and the
> licenses of them, I don't trust them at all.  To help gain that trust
> back, marking the exports in this manner will be a great improvement.
> 
> To insist otherwise is to only reinforce my doubts, and reduce my
> wanting to even review or accept this code at all.  Sorry about that.

Huh? What are the concerns exactly? I do not really see difference between
EXPORT_SYMBOL() and EXPORT_SYMBOL_GPL(). The code either derivative of the
kernel or it is not and so it either falls under the kernel license or not.

>From out perspective we do not really care what other code might use VMCI,
all our Linux drivers, even if not all are upstream [yet], are GPL.

Thanks,
Dmitry