From: Steve Sistare <steven.sistare@oracle.com>
To: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Si-Wei Liu <si-wei.liu@oracle.com>,
Eugenio Perez Martin <eperezma@redhat.com>,
Xie Yongji <xieyongji@bytedance.com>,
Stefano Garzarella <sgarzare@redhat.com>,
Steve Sistare <steven.sistare@oracle.com>
Subject: [PATCH V2 3/3] vdpa_sim: flush workers on suspend
Date: Mon, 12 Feb 2024 09:16:14 -0800 [thread overview]
Message-ID: <1707758174-142161-4-git-send-email-steven.sistare@oracle.com> (raw)
In-Reply-To: <1707758174-142161-1-git-send-email-steven.sistare@oracle.com>
Flush to guarantee no workers are running when suspend returns.
Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
---
drivers/vdpa/vdpa_sim/vdpa_sim.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
index be2925d0d283..a662b90357c3 100644
--- a/drivers/vdpa/vdpa_sim/vdpa_sim.c
+++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
@@ -74,6 +74,17 @@ static void vdpasim_worker_change_mm_sync(struct vdpasim *vdpasim,
kthread_flush_work(work);
}
+static void flush_work_fn(struct kthread_work *work) {}
+
+static void vdpasim_flush_work(struct vdpasim *vdpasim)
+{
+ struct kthread_work work;
+
+ kthread_init_work(&work, flush_work_fn);
+ kthread_queue_work(vdpasim->worker, &work);
+ kthread_flush_work(&work);
+}
+
static struct vdpasim *vdpa_to_sim(struct vdpa_device *vdpa)
{
return container_of(vdpa, struct vdpasim, vdpa);
@@ -511,6 +522,8 @@ static int vdpasim_suspend(struct vdpa_device *vdpa)
vdpasim->running = false;
mutex_unlock(&vdpasim->mutex);
+ vdpasim_flush_work(vdpasim);
+
return 0;
}
--
2.39.3
next prev parent reply other threads:[~2024-02-12 17:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 17:16 [PATCH V2 0/3] flush workers on suspend Steve Sistare
2024-02-12 17:16 ` [PATCH V2 1/3] vhost-vdpa: " Steve Sistare
2024-02-13 15:58 ` Eugenio Perez Martin
2024-02-14 17:48 ` Steven Sistare
2024-02-12 17:16 ` [PATCH V2 2/3] vduse: suspend Steve Sistare
2024-02-12 17:16 ` Steve Sistare [this message]
2024-02-13 16:10 ` [PATCH V2 3/3] vdpa_sim: flush workers on suspend Eugenio Perez Martin
2024-02-14 17:50 ` Steven Sistare
2024-02-14 19:39 ` Eugenio Perez Martin
2024-02-14 19:52 ` Steven Sistare
2024-02-15 15:44 ` Eugenio Perez Martin
2024-02-16 15:15 ` Steven Sistare
2024-02-13 15:10 ` [PATCH V2 0/3] " Steven Sistare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1707758174-142161-4-git-send-email-steven.sistare@oracle.com \
--to=steven.sistare@oracle.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=sgarzare@redhat.com \
--cc=si-wei.liu@oracle.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).