From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 872BC13048E for ; Tue, 26 Mar 2024 07:18:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711437526; cv=none; b=XTIhtZucLOupyg042QleGhSVT02w+nCcq/JGJWmiM/KWU/5wFwCllqDJ/dQiYycyRtvWiUH+WcMlCjsjoLUgRVFhWoIamls57ZlVeUx2a2MwgfYfz7l0ZayRbMtp6zEwinmGMWEPZX/NAOX0Fv5rbkS2J2Y2uVQbJ8xvBZTILDg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711437526; c=relaxed/simple; bh=lvPHXAmlthw4ylJLu+8Br+cOBpAUBI32m3n1uEjmn1s=; h=Message-ID:Subject:Date:From:To:Cc:References:In-Reply-To: Content-Type; b=Lf8lOqIRQh6P+F0zh7Vt/vCRZ8T5PhMbUxRAYo1SWWyWR0eP+DB1Vm+Q49WK+TfGPJQIdMwBXEpP4XEQofnQXm+JM9qNlq8GJoVXWrcFHE6KC5VVo3DzCya187nlxPd/DfOcEqUy/bWgxqSr8NicjwcINnjh+9ubvGXNxArIk1w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=gxuKFk8B; arc=none smtp.client-ip=115.124.30.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="gxuKFk8B" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1711437521; h=Message-ID:Subject:Date:From:To:Content-Type; bh=lvPHXAmlthw4ylJLu+8Br+cOBpAUBI32m3n1uEjmn1s=; b=gxuKFk8BbjYoFt7s0xOQ7GXNjJrcKZrM3F2OzJqwiwyNvK4TUgG3lmsJgwBGming++SHEDryo/l9QRZB4/jwAkc3JA0Au+TrA2qg8J4m5eci8QvmHTHvqYhSHQBytNvBKbP8fQ38Mi9/2VJ9ECD0HXL/o2eF9m7vh+GS3Fh8les= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R501e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=25;SR=0;TI=SMTPD_---0W3K6Xbp_1711437519; Received: from localhost(mailfrom:xuanzhuo@linux.alibaba.com fp:SMTPD_---0W3K6Xbp_1711437519) by smtp.aliyun-inc.com; Tue, 26 Mar 2024 15:18:40 +0800 Message-ID: <1711437497.65582-1-xuanzhuo@linux.alibaba.com> Subject: Re: [PATCH vhost v5 1/6] virtio_balloon: remove the dependence where names[] is null Date: Tue, 26 Mar 2024 15:18:17 +0800 From: Xuan Zhuo To: Jason Wang Cc: virtualization@lists.linux.dev, Richard Weinberger , Anton Ivanov , Johannes Berg , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Eric Farman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "Michael S. Tsirkin" , David Hildenbrand , linux-um@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org References: <20240325090419.33677-1-xuanzhuo@linux.alibaba.com> <20240325090419.33677-2-xuanzhuo@linux.alibaba.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: On Tue, 26 Mar 2024 12:14:17 +0800, Jason Wang wrote: > On Mon, Mar 25, 2024 at 5:04=E2=80=AFPM Xuan Zhuo wrote: > > > > Currently, the init_vqs function within the virtio_balloon driver relies > > on the condition that certain names array entries are null in order to > > skip the initialization of some virtual queues (vqs). > > If there's a respin I would add something like: > > 1) the virtqueue index is contiguous for all the existing devices. > 2) the current behaviour of virtio-balloon device is different from > what is described in the spec 1.0-1.2 > 3) there's no functional changes and explain why > > > This behavior is > > unique to this part of the codebase. In an upcoming commit, we plan to > > eliminate this dependency by removing the function entirely. Therefore, > > with this change, we are ensuring that the virtio_balloon no longer > > depends on the aforementioned function. > > > > Signed-off-by: Xuan Zhuo > > With the above tweak. OK. I will add these in next version. Thanks. > > Acked-by: Jason Wang > > Thanks >