From: Heng Qi <hengqi@linux.alibaba.com>
To: netdev@vger.kernel.org, virtualization@lists.linux.dev
Cc: Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jason Wang <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Ratheesh Kannoth <rkannoth@marvell.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: [PATCH net-next v6 4/4] virtio-net: support dim profile fine-tuning
Date: Thu, 11 Apr 2024 22:12:31 +0800 [thread overview]
Message-ID: <1712844751-53514-5-git-send-email-hengqi@linux.alibaba.com> (raw)
In-Reply-To: <1712844751-53514-1-git-send-email-hengqi@linux.alibaba.com>
Virtio-net has different types of back-end device
implementations. In order to effectively optimize
the dim library's gains for different device
implementations, let's use the new interface params
to fine-tune the profile list.
Signed-off-by: Heng Qi <hengqi@linux.alibaba.com>
---
drivers/net/virtio_net.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index a64656e..813d9ed 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -3584,7 +3584,7 @@ static void virtnet_rx_dim_work(struct work_struct *work)
if (!rq->dim_enabled)
continue;
- update_moder = net_dim_get_rx_moderation(dim->mode, dim->profile_ix);
+ update_moder = dev->rx_eqe_profile[dim->profile_ix];
if (update_moder.usec != rq->intr_coal.max_usecs ||
update_moder.pkts != rq->intr_coal.max_packets) {
err = virtnet_send_rx_ctrl_coal_vq_cmd(vi, qnum,
@@ -3868,7 +3868,8 @@ static int virtnet_set_rxnfc(struct net_device *dev, struct ethtool_rxnfc *info)
static const struct ethtool_ops virtnet_ethtool_ops = {
.supported_coalesce_params = ETHTOOL_COALESCE_MAX_FRAMES |
- ETHTOOL_COALESCE_USECS | ETHTOOL_COALESCE_USE_ADAPTIVE_RX,
+ ETHTOOL_COALESCE_USECS | ETHTOOL_COALESCE_USE_ADAPTIVE_RX |
+ ETHTOOL_COALESCE_RX_EQE_PROFILE,
.get_drvinfo = virtnet_get_drvinfo,
.get_link = ethtool_op_get_link,
.get_ringparam = virtnet_get_ringparam,
@@ -4424,6 +4425,7 @@ static int virtnet_find_vqs(struct virtnet_info *vi)
static void virtnet_dim_init(struct virtnet_info *vi)
{
+ struct net_device *dev = vi->dev;
int i;
if (!virtio_has_feature(vi->vdev, VIRTIO_NET_F_VQ_NOTF_COAL))
@@ -4433,6 +4435,8 @@ static void virtnet_dim_init(struct virtnet_info *vi)
INIT_WORK(&vi->rq[i].dim.work, virtnet_rx_dim_work);
vi->rq[i].dim.mode = DIM_CQ_PERIOD_MODE_START_FROM_EQE;
}
+
+ dev->priv_flags |= IFF_PROFILE_USEC | IFF_PROFILE_PKTS;
}
static int virtnet_alloc_queues(struct virtnet_info *vi)
--
1.8.3.1
next prev parent reply other threads:[~2024-04-11 14:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 14:12 [PATCH net-next v6 0/4] ethtool: provide the dim profile fine-tuning channel Heng Qi
2024-04-11 14:12 ` [PATCH net-next v6 1/4] linux/dim: move useful macros to .h file Heng Qi
2024-04-11 14:12 ` [PATCH net-next v6 2/4] ethtool: provide customized dim profile management Heng Qi
2024-04-11 15:19 ` Brett Creeley
2024-04-12 2:07 ` Heng Qi
2024-04-12 15:33 ` Brett Creeley
2024-04-12 16:05 ` Heng Qi
2024-04-12 3:56 ` kernel test robot
2024-04-12 4:39 ` kernel test robot
2024-04-12 17:44 ` kernel test robot
2024-04-13 2:26 ` Jakub Kicinski
2024-04-13 10:14 ` Heng Qi
2024-04-13 2:27 ` Jakub Kicinski
2024-04-11 14:12 ` [PATCH net-next v6 3/4] virtio-net: refactor dim initialization/destruction Heng Qi
2024-04-11 14:12 ` Heng Qi [this message]
2024-04-11 15:23 ` [PATCH net-next v6 4/4] virtio-net: support dim profile fine-tuning Brett Creeley
2024-04-12 2:19 ` Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1712844751-53514-5-git-send-email-hengqi@linux.alibaba.com \
--to=hengqi@linux.alibaba.com \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).