From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: guanjun@linux.alibaba.com, Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
virtualization@lists.linux-foundation.org,
xieyongji@bytedance.com, elic@nvidia.com,
gautam.dawar@xilinx.com, dan.carpenter@oracle.com
Subject: Re: [PATCH v2] vduse: prevent uninitialized memory accesses
Date: Wed, 31 Aug 2022 17:47:10 +0200 [thread overview]
Message-ID: <175a4e24-f8ee-ee9d-d02e-6a61d18a75ad@redhat.com> (raw)
In-Reply-To: <20220831114534-mutt-send-email-mst@kernel.org>
On 8/31/22 17:46, Michael S. Tsirkin wrote:
> On Wed, Aug 31, 2022 at 05:01:11PM +0200, Maxime Coquelin wrote:
>> On 8/29/22 09:48, Greg KH wrote:
>>> On Mon, Aug 29, 2022 at 09:34:24AM +0200, Maxime Coquelin wrote:
>>>> If the VDUSE application provides a smaller config space
>>>> than the driver expects, the driver may use uninitialized
>>>> memory from the stack.
>>>>
>>>> This patch prevents it by initializing the buffer passed by
>>>> the driver to store the config value.
>>>>
>>>> This fix addresses CVE-2022-2308.
>>>>
>>>> Cc: xieyongji@bytedance.com
>>>> Cc: stable@vger.kernel.org # v5.15+
>>>> Fixes: c8a6153b6c59 ("vduse: Introduce VDUSE - vDPA Device in Userspace")
>>>>
>>>> Acked-by: Jason Wang <jasowang@redhat.com>
>>>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>>>
>>> Please no blank line above the Acked-by: line here if possible.
>>
>> Sure.
>>
>> Jason, do you prefer I post a new revision with this single change or
>> you will handle it while applying? Either way is fine to me.
>>
>> Thanks,
>> Maxime
>
> I queue these normally.
Ok, I'm preparing the V2.
Thanks,
Maxime
>>> thanks,
>>>
>>> greg k-h
>>>
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
prev parent reply other threads:[~2022-08-31 15:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 7:34 [PATCH v2] vduse: prevent uninitialized memory accesses Maxime Coquelin
2022-08-29 7:48 ` Greg KH
2022-08-31 15:01 ` Maxime Coquelin
2022-08-31 15:12 ` Michael S. Tsirkin
2022-08-31 15:46 ` Michael S. Tsirkin
2022-08-31 15:47 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175a4e24-f8ee-ee9d-d02e-6a61d18a75ad@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=elic@nvidia.com \
--cc=gautam.dawar@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=guanjun@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=stable@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).