* [PATCH net v2] selftests/vsock: avoid false-positives when checking dmesg
@ 2025-11-05 15:59 Bobby Eshleman
2025-11-05 16:16 ` Stefano Garzarella
2025-11-06 15:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Bobby Eshleman @ 2025-11-05 15:59 UTC (permalink / raw)
To: Stefano Garzarella, Shuah Khan, Jakub Kicinski, Bobby Eshleman
Cc: virtualization, netdev, linux-kselftest, linux-kernel,
Bobby Eshleman, Simon Horman
From: Bobby Eshleman <bobbyeshleman@meta.com>
Sometimes VMs will have some intermittent dmesg warnings that are
unrelated to vsock. Change the dmesg parsing to filter on strings
containing 'vsock' to avoid false positive failures that are unrelated
to vsock. The downside is that it is possible for some vsock related
warnings to not contain the substring 'vsock', so those will be missed.
Fixes: a4a65c6fe08b ("selftests/vsock: add initial vmtest.sh for vsock")
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Bobby Eshleman <bobbyeshleman@meta.com>
---
Previously was part of the series:
https://lore.kernel.org/all/20251022-vsock-selftests-fixes-and-improvements-v1-0-edeb179d6463@meta.com/
---
Changes in v2:
- use consistent quoting for vsock string
- Link to v1: https://lore.kernel.org/r/20251104-vsock-vmtest-dmesg-fix-v1-1-80c8db3f5dfe@meta.com
---
tools/testing/selftests/vsock/vmtest.sh | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/testing/selftests/vsock/vmtest.sh b/tools/testing/selftests/vsock/vmtest.sh
index edacebfc1632..8ceeb8a7894f 100755
--- a/tools/testing/selftests/vsock/vmtest.sh
+++ b/tools/testing/selftests/vsock/vmtest.sh
@@ -389,9 +389,9 @@ run_test() {
local rc
host_oops_cnt_before=$(dmesg | grep -c -i 'Oops')
- host_warn_cnt_before=$(dmesg --level=warn | wc -l)
+ host_warn_cnt_before=$(dmesg --level=warn | grep -c -i 'vsock')
vm_oops_cnt_before=$(vm_ssh -- dmesg | grep -c -i 'Oops')
- vm_warn_cnt_before=$(vm_ssh -- dmesg --level=warn | wc -l)
+ vm_warn_cnt_before=$(vm_ssh -- dmesg --level=warn | grep -c -i 'vsock')
name=$(echo "${1}" | awk '{ print $1 }')
eval test_"${name}"
@@ -403,7 +403,7 @@ run_test() {
rc=$KSFT_FAIL
fi
- host_warn_cnt_after=$(dmesg --level=warn | wc -l)
+ host_warn_cnt_after=$(dmesg --level=warn | grep -c -i 'vsock')
if [[ ${host_warn_cnt_after} -gt ${host_warn_cnt_before} ]]; then
echo "FAIL: kernel warning detected on host" | log_host "${name}"
rc=$KSFT_FAIL
@@ -415,7 +415,7 @@ run_test() {
rc=$KSFT_FAIL
fi
- vm_warn_cnt_after=$(vm_ssh -- dmesg --level=warn | wc -l)
+ vm_warn_cnt_after=$(vm_ssh -- dmesg --level=warn | grep -c -i 'vsock')
if [[ ${vm_warn_cnt_after} -gt ${vm_warn_cnt_before} ]]; then
echo "FAIL: kernel warning detected on vm" | log_host "${name}"
rc=$KSFT_FAIL
---
base-commit: 89aec171d9d1ab168e43fcf9754b82e4c0aef9b9
change-id: 20251104-vsock-vmtest-dmesg-fix-b2c59e1d9c38
Best regards,
--
Bobby Eshleman <bobbyeshleman@meta.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net v2] selftests/vsock: avoid false-positives when checking dmesg
2025-11-05 15:59 [PATCH net v2] selftests/vsock: avoid false-positives when checking dmesg Bobby Eshleman
@ 2025-11-05 16:16 ` Stefano Garzarella
2025-11-06 15:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Garzarella @ 2025-11-05 16:16 UTC (permalink / raw)
To: Bobby Eshleman
Cc: Shuah Khan, Jakub Kicinski, virtualization, netdev,
linux-kselftest, linux-kernel, Bobby Eshleman, Simon Horman
On Wed, Nov 05, 2025 at 07:59:19AM -0800, Bobby Eshleman wrote:
>From: Bobby Eshleman <bobbyeshleman@meta.com>
>
>Sometimes VMs will have some intermittent dmesg warnings that are
>unrelated to vsock. Change the dmesg parsing to filter on strings
>containing 'vsock' to avoid false positive failures that are unrelated
>to vsock. The downside is that it is possible for some vsock related
>warnings to not contain the substring 'vsock', so those will be missed.
>
>Fixes: a4a65c6fe08b ("selftests/vsock: add initial vmtest.sh for vsock")
>Reviewed-by: Simon Horman <horms@kernel.org>
>Signed-off-by: Bobby Eshleman <bobbyeshleman@meta.com>
>---
>Previously was part of the series:
>https://lore.kernel.org/all/20251022-vsock-selftests-fixes-and-improvements-v1-0-edeb179d6463@meta.com/
>---
>Changes in v2:
>- use consistent quoting for vsock string
>- Link to v1: https://lore.kernel.org/r/20251104-vsock-vmtest-dmesg-fix-v1-1-80c8db3f5dfe@meta.com
>---
> tools/testing/selftests/vsock/vmtest.sh | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
>
>diff --git a/tools/testing/selftests/vsock/vmtest.sh b/tools/testing/selftests/vsock/vmtest.sh
>index edacebfc1632..8ceeb8a7894f 100755
>--- a/tools/testing/selftests/vsock/vmtest.sh
>+++ b/tools/testing/selftests/vsock/vmtest.sh
>@@ -389,9 +389,9 @@ run_test() {
> local rc
>
> host_oops_cnt_before=$(dmesg | grep -c -i 'Oops')
>- host_warn_cnt_before=$(dmesg --level=warn | wc -l)
>+ host_warn_cnt_before=$(dmesg --level=warn | grep -c -i 'vsock')
> vm_oops_cnt_before=$(vm_ssh -- dmesg | grep -c -i 'Oops')
>- vm_warn_cnt_before=$(vm_ssh -- dmesg --level=warn | wc -l)
>+ vm_warn_cnt_before=$(vm_ssh -- dmesg --level=warn | grep -c -i 'vsock')
>
> name=$(echo "${1}" | awk '{ print $1 }')
> eval test_"${name}"
>@@ -403,7 +403,7 @@ run_test() {
> rc=$KSFT_FAIL
> fi
>
>- host_warn_cnt_after=$(dmesg --level=warn | wc -l)
>+ host_warn_cnt_after=$(dmesg --level=warn | grep -c -i 'vsock')
> if [[ ${host_warn_cnt_after} -gt ${host_warn_cnt_before} ]]; then
> echo "FAIL: kernel warning detected on host" | log_host "${name}"
> rc=$KSFT_FAIL
>@@ -415,7 +415,7 @@ run_test() {
> rc=$KSFT_FAIL
> fi
>
>- vm_warn_cnt_after=$(vm_ssh -- dmesg --level=warn | wc -l)
>+ vm_warn_cnt_after=$(vm_ssh -- dmesg --level=warn | grep -c -i 'vsock')
> if [[ ${vm_warn_cnt_after} -gt ${vm_warn_cnt_before} ]]; then
> echo "FAIL: kernel warning detected on vm" | log_host "${name}"
> rc=$KSFT_FAIL
>
>---
>base-commit: 89aec171d9d1ab168e43fcf9754b82e4c0aef9b9
>change-id: 20251104-vsock-vmtest-dmesg-fix-b2c59e1d9c38
>
>Best regards,
>--
>Bobby Eshleman <bobbyeshleman@meta.com>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net v2] selftests/vsock: avoid false-positives when checking dmesg
2025-11-05 15:59 [PATCH net v2] selftests/vsock: avoid false-positives when checking dmesg Bobby Eshleman
2025-11-05 16:16 ` Stefano Garzarella
@ 2025-11-06 15:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-11-06 15:40 UTC (permalink / raw)
To: Bobby Eshleman
Cc: sgarzare, shuah, kuba, virtualization, netdev, linux-kselftest,
linux-kernel, bobbyeshleman, horms
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 05 Nov 2025 07:59:19 -0800 you wrote:
> From: Bobby Eshleman <bobbyeshleman@meta.com>
>
> Sometimes VMs will have some intermittent dmesg warnings that are
> unrelated to vsock. Change the dmesg parsing to filter on strings
> containing 'vsock' to avoid false positive failures that are unrelated
> to vsock. The downside is that it is possible for some vsock related
> warnings to not contain the substring 'vsock', so those will be missed.
>
> [...]
Here is the summary with links:
- [net,v2] selftests/vsock: avoid false-positives when checking dmesg
https://git.kernel.org/netdev/net/c/3534e03e0ec2
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-06 15:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-05 15:59 [PATCH net v2] selftests/vsock: avoid false-positives when checking dmesg Bobby Eshleman
2025-11-05 16:16 ` Stefano Garzarella
2025-11-06 15:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).