From: David Ahern <dsahern@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>,
Alexander Lobakin <alexandr.lobakin@intel.com>
Cc: "Song Liu" <songliubraving@fb.com>,
"Sergey Ryazanov" <ryazanov.s.a@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
"Andrei Vagin" <avagin@gmail.com>,
"Tony Nguyen" <anthony.l.nguyen@intel.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Ioana Ciornei" <ioana.ciornei@nxp.com>,
"Arthur Kiyanovski" <akiyano@amazon.com>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Jonathan Corbet" <corbet@lwn.net>,
linux-rdma@vger.kernel.org, linux-doc@vger.kernel.org,
"John Fastabend" <john.fastabend@gmail.com>,
"Noam Dagan" <ndagan@amazon.com>,
"Cong Wang" <cong.wang@bytedance.com>,
"Martin Habets" <habetsm.xilinx@gmail.com>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"Johannes Berg" <johannes.berg@intel.com>,
"KP Singh" <kpsingh@kernel.org>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Claudiu Manoil" <claudiu.manoil@nxp.com>,
"Yonghong Song" <yhs@fb.com>,
"Shay Agroskin" <shayagr@amazon.com>,
"Marcin Wojtas" <mw@semihalf.com>,
"Leon Romanovsky" <leon@kernel.org>,
"David Arinzon" <darinzon@amazon.com>,
"David Ahern" <dsahern@kernel.org>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, "Martin KaFai Lau" <kafai@fb.com>,
"Edward Cree" <ecree.xilinx@gmail.com>,
"Yajun Deng" <yajun.deng@linux.dev>,
netdev@vger.kernel.org, "Saeed Bishara" <saeedb@amazon.com>,
"Michal Swiatkowski" <michal.swiatkowski@linux.intel.com>,
bpf@vger.kernel.org, "Saeed Mahameed" <saeedm@nvidia.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v2 net-next 00/26] net: introduce and use generic XDP stats
Date: Tue, 30 Nov 2021 10:38:14 -0700 [thread overview]
Message-ID: <18655462-c72e-1d26-5b59-d03eb993d832@gmail.com> (raw)
In-Reply-To: <20211130090449.58a8327d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 11/30/21 10:04 AM, Jakub Kicinski wrote:
> On Tue, 30 Nov 2021 17:34:54 +0100 Alexander Lobakin wrote:
>>> Another thought on this patch: with individual attributes you could save
>>> some overhead by not sending 0 counters to userspace. e.g., define a
>>> helper that does:
>>
>> I know about ETHTOOL_STAT_NOT_SET, but RTNL xstats doesn't use this,
>> does it?
>
> Not sure if you're asking me or Dave but no, to my knowledge RTNL does
> not use such semantics today. But the reason is mostly because there
> weren't many driver stats added there. Knowing if an error counter is
> not supported or supporter and 0 is important for monitoring. Even if
> XDP stats don't have a counter which may not be supported today it's
> not a good precedent to make IMO.
>
Today, stats are sent as a struct so skipping stats whose value is 0 is
not an option. When using individual attributes for the counters this
becomes an option. Given there is no value in sending '0' why do it?
Is your pushback that there should be a uapi to opt-in to this behavior?
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-11-30 17:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211123163955.154512-1-alexandr.lobakin@intel.com>
[not found] ` <20211123163955.154512-22-alexandr.lobakin@intel.com>
2021-11-24 0:52 ` [PATCH v2 net-next 21/26] ice: add XDP and XSK generic per-channel statistics Daniel Borkmann
2021-11-25 11:56 ` Toke Høiland-Jørgensen
[not found] ` <20211125170708.127323-1-alexandr.lobakin@intel.com>
[not found] ` <20211125094440.6c402d63@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
[not found] ` <20211125204007.133064-1-alexandr.lobakin@intel.com>
2021-11-26 12:30 ` Toke Høiland-Jørgensen
[not found] ` <20211126100611.514df099@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
2021-11-26 18:47 ` Toke Høiland-Jørgensen
[not found] ` <20211126111431.4a2ed007@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
2021-11-28 17:54 ` Ido Schimmel
2021-11-26 22:27 ` Daniel Borkmann
2021-11-29 11:51 ` Toke Høiland-Jørgensen
[not found] ` <20211123163955.154512-9-alexandr.lobakin@intel.com>
2021-11-24 11:33 ` [PATCH v2 net-next 08/26] mvpp2: provide .ndo_get_xdp_stats() callback Russell King (Oracle)
2021-11-24 11:36 ` Russell King (Oracle)
[not found] ` <20211123163955.154512-8-alexandr.lobakin@intel.com>
2021-11-24 11:39 ` [PATCH v2 net-next 07/26] mvneta: add " Russell King (Oracle)
2021-11-28 22:23 ` [PATCH v2 net-next 00/26] net: introduce and use generic XDP stats David Ahern
[not found] ` <20211123163955.154512-2-alexandr.lobakin@intel.com>
2021-11-30 2:36 ` [PATCH v2 net-next 01/26] rtnetlink: introduce generic XDP statistics David Ahern
[not found] ` <20211130155612.594688-1-alexandr.lobakin@intel.com>
2021-11-30 16:17 ` [PATCH v2 net-next 00/26] net: introduce and use generic XDP stats Toke Høiland-Jørgensen
[not found] ` <20211130090716.4a557036@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
2021-11-30 17:56 ` David Ahern
[not found] ` <20211130081207.228f42ba@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
[not found] ` <20211130163454.595897-1-alexandr.lobakin@intel.com>
[not found] ` <20211130090449.58a8327d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
2021-11-30 17:38 ` David Ahern [this message]
2021-12-01 15:21 ` Jamal Hadi Salim
2021-11-30 17:45 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18655462-c72e-1d26-5b59-d03eb993d832@gmail.com \
--to=dsahern@gmail.com \
--cc=akiyano@amazon.com \
--cc=alexandr.lobakin@intel.com \
--cc=andrii@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=avagin@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=claudiu.manoil@nxp.com \
--cc=cong.wang@bytedance.com \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=darinzon@amazon.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=ecree.xilinx@gmail.com \
--cc=habetsm.xilinx@gmail.com \
--cc=hawk@kernel.org \
--cc=ioana.ciornei@nxp.com \
--cc=johannes.berg@intel.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=mst@redhat.com \
--cc=mw@semihalf.com \
--cc=ndagan@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=ryazanov.s.a@gmail.com \
--cc=saeedb@amazon.com \
--cc=saeedm@nvidia.com \
--cc=shayagr@amazon.com \
--cc=songliubraving@fb.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=toke@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=vladimir.oltean@nxp.com \
--cc=yajun.deng@linux.dev \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).