From: Jason Wang <jasowang@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
mst@redhat.com, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: wexu@redhat.com
Subject: Re: [PATCH net-next 6/8] virtio: introduce packed ring defines
Date: Thu, 5 Jul 2018 19:30:18 +0800 [thread overview]
Message-ID: <196f5521-9215-c163-aa7c-38caf3f1e7a4@redhat.com> (raw)
In-Reply-To: <0f293989-a0ca-e7ad-f907-83a8d8445335@redhat.com>
On 2018年07月05日 04:15, Maxime Coquelin wrote:
>
>
> On 07/03/2018 07:38 AM, Jason Wang wrote:
>> diff --git a/include/uapi/linux/virtio_ring.h
>> b/include/uapi/linux/virtio_ring.h
>> index 6d5d5fa..71c7a46 100644
>> --- a/include/uapi/linux/virtio_ring.h
>> +++ b/include/uapi/linux/virtio_ring.h
>> @@ -43,6 +43,8 @@
>> #define VRING_DESC_F_WRITE 2
>> /* This means the buffer contains a list of buffer descriptors. */
>> #define VRING_DESC_F_INDIRECT 4
>> +#define VRING_DESC_F_AVAIL 7
>> +#define VRING_DESC_F_USED 15
>
> For consistency, you may want to make VRING_DESC_F_AVAIL and
> VRING_DESC_F_USED to represent the bit mask and not the bit position,
> as done for VRING_DESC_F_WRITE and VRING_DESC_F_INDIRECT.
>
> Regards,
> Maxime
Yes, Tiwei has the same comment.
Will fix this.
Thanks
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
prev parent reply other threads:[~2018-07-05 11:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 5:37 [PATCH net-next 0/8] Packed virtqueue for vhost Jason Wang
2018-07-03 5:37 ` [PATCH net-next 1/8] vhost: move get_rx_bufs to vhost.c Jason Wang
2018-07-03 5:37 ` [PATCH net-next 2/8] vhost: hide used ring layout from device Jason Wang
2018-07-03 5:37 ` [PATCH net-next 3/8] vhost: do not use vring_used_elem Jason Wang
2018-07-03 5:38 ` [PATCH net-next 4/8] vhost_net: do not explicitly manipulate vhost_used_elem Jason Wang
2018-07-03 5:38 ` [PATCH net-next 5/8] vhost: vhost_put_user() can accept metadata type Jason Wang
2018-07-03 5:38 ` [PATCH net-next 6/8] virtio: introduce packed ring defines Jason Wang
2018-07-03 5:38 ` [PATCH net-next 7/8] vhost: packed ring support Jason Wang
2018-07-03 5:38 ` [PATCH net-next 8/8] vhost: event suppression for packed ring Jason Wang
[not found] ` <1530596284-4101-9-git-send-email-jasowang@redhat.com>
2018-07-04 4:13 ` Wei Xu
2018-07-04 5:23 ` Jason Wang
2018-07-04 8:13 ` Wei Xu
[not found] ` <1530596284-4101-7-git-send-email-jasowang@redhat.com>
2018-07-04 4:48 ` [PATCH net-next 6/8] virtio: introduce packed ring defines Tiwei Bie
2018-07-04 5:26 ` Jason Wang
[not found] ` <0f293989-a0ca-e7ad-f907-83a8d8445335@redhat.com>
2018-07-05 11:30 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=196f5521-9215-c163-aa7c-38caf3f1e7a4@redhat.com \
--to=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wexu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).