From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2] virtio-blk: add DISCARD support to virtio-blk driver Date: Wed, 5 Jul 2017 10:00:23 +0200 Message-ID: <1e57bca7-cf5c-741d-b0f2-d026826d2dcc@redhat.com> References: <1499244279-3484-1-git-send-email-changpeng.liu@intel.com> <01542f21-6fa3-c406-65e1-a37d04130fb7@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Liu, Changpeng" , "virtualization@lists.linux-foundation.org" Cc: "hch@lst.de" , "mst@redhat.com" List-Id: virtualization@lists.linuxfoundation.org On 05/07/2017 09:57, Liu, Changpeng wrote: >> Please include a patch for the specification. Since we are at it, I > Thanks Paolo, do you mean include a text file which describe the changes for the specification? The specification is hosted in an svn (Subversion) repository at https://tools.oasis-open.org/version-control/svn/virtio. You can provide a patch and send it to virtio-comment@lists.oasis-open.org. Thanks, Paolo >> would like to have three operations defined using the same descriptor: >> >> - discard (SCSI UNMAP) >> >> - write zeroes (SCSI WRITE SAME without UNMAP flag) >> >> - write zeroes and possibly discard (SCSI WRITE SAME with UNMAP flag) >> >> The last two can use the same command VIRTIO_BLK_T_WRITE_ZEROES, using >> the reserved field as a flags field. > > Will add write zeroes feature.