From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [PATCH v2 net-next 2/4] vhost_net: Avoid tx vring kicks during busyloop Date: Tue, 3 Jul 2018 17:04:07 +0800 Message-ID: <1f38d03b-6e66-9581-aa9c-c083f110dcd3@redhat.com> References: <1530603094-2476-1-git-send-email-makita.toshiaki@lab.ntt.co.jp> <1530603094-2476-3-git-send-email-makita.toshiaki@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1530603094-2476-3-git-send-email-makita.toshiaki@lab.ntt.co.jp> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Toshiaki Makita , "David S. Miller" , "Michael S. Tsirkin" Cc: netdev@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org CgpPbiAyMDE45bm0MDfmnIgwM+aXpSAxNTozMSwgVG9zaGlha2kgTWFraXRhIHdyb3RlOgo+IFVu ZGVyIGhlYXZ5IGxvYWQgdmhvc3QgYnVzeXBvbGwgbWF5IHJ1biB3aXRob3V0IHN1cHByZXNzaW5n Cj4gbm90aWZpY2F0aW9uLiBGb3IgZXhhbXBsZSB0eCB6ZXJvY29weSBjYWxsYmFjayBjYW4gcHVz aCB0eCB3b3JrIHdoaWxlCj4gaGFuZGxlX3R4KCkgaXMgcnVubmluZywgdGhlbiBidXN5bG9vcCBl eGl0cyBkdWUgdG8gdmhvc3RfaGFzX3dvcmsoKQo+IGNvbmRpdGlvbiBhbmQgZW5hYmxlcyBub3Rp ZmljYXRpb24gYnV0IGltbWVkaWF0ZWx5IHJlZW50ZXJzIGhhbmRsZV90eCgpCj4gYmVjYXVzZSB0 aGUgcHVzaGVkIHdvcmsgd2FzIHR4LiBJbiB0aGlzIGNhc2UgaGFuZGxlX3R4KCkgdHJpZXMgdG8K PiBkaXNhYmxlIG5vdGlmaWNhdGlvbiBhZ2FpbiwgYnV0IHdoZW4gdXNpbmcgZXZlbnRfaWR4IGl0 IGJ5IGRlc2lnbgo+IGNhbm5vdC4gVGhlbiBidXN5bG9vcCB3aWxsIHJ1biB3aXRob3V0IHN1cHBy ZXNzaW5nIG5vdGlmaWNhdGlvbi4KPiBBbm90aGVyIGV4YW1wbGUgaXMgdGhlIGNhc2Ugd2hlcmUg aGFuZGxlX3R4KCkgdHJpZXMgdG8gZW5hYmxlCj4gbm90aWZpY2F0aW9uIGJ1dCBhdmFpbCBpZHgg aXMgYWR2YW5jZWQgc28gZGlzYWJsZXMgaXQgYWdhaW4uIFRoaXMgY2FzZQo+IGFsc28gbGVhZHMg dG8gdGhlIHNhbWUgc2l0dWF0aW9uIHdpdGggZXZlbnRfaWR4Lgo+Cj4gVGhlIHByb2JsZW0gaXMg dGhhdCBvbmNlIHdlIGVudGVyIHRoaXMgc2l0dWF0aW9uIGJ1c3lsb29wIGRvZXMgbm90IHdvcmsK PiB1bmRlciBoZWF2eSBsb2FkIGZvciBjb25zaWRlcmFibGUgYW1vdW50IG9mIHRpbWUsIGJlY2F1 c2Ugbm90aWZpY2F0aW9uCj4gaXMgbGlrZWx5IHRvIGhhcHBlbiBkdXJpbmcgYnVzeWxvb3AgYW5k IGhhbmRsZV90eCgpIGltbWVkaWF0ZWx5IGVuYWJsZXMKPiBub3RpZmljYXRpb24gYWZ0ZXIgbm90 aWZpY2F0aW9uIGhhcHBlbnMuIFNwZWNpZmljYWxseSBidXN5bG9vcCBkZXRlY3RzCj4gbm90aWZp Y2F0aW9uIGJ5IHZob3N0X2hhc193b3JrKCkgYW5kIHRoZW4gaGFuZGxlX3R4KCkgY2FsbHMKPiB2 aG9zdF9lbmFibGVfbm90aWZ5KCkuIEJlY2F1c2UgdGhlIGRldGVjdGVkIHdvcmsgd2FzIHRoZSB0 eCB3b3JrLCBpdAo+IGVudGVycyBoYW5kbGVfdHgoKSwgYW5kIGVudGVycyBidXN5bG9vcCB3aXRo b3V0IHN1cHByZXNzaW9uIGFnYWluLgo+IFRoaXMgaXMgbGlrZWx5IHRvIGJlIHJlcGVhdGVkLCBz byB3aXRoIGV2ZW50X2lkeCB3ZSBhcmUgYWxtb3N0IG5vdCBhYmxlCj4gdG8gc3VwcHJlc3Mgbm90 aWZpY2F0aW9uIGluIHRoaXMgY2FzZS4KPgo+IFRvIGZpeCB0aGlzLCBwb2xsIHRoZSB3b3JrIGlu c3RlYWQgb2YgZW5hYmxpbmcgbm90aWZpY2F0aW9uIHdoZW4KPiBidXN5cG9sbCBpcyBpbnRlcnJ1 cHRlZCBieSBzb21ldGhpbmcuIElNSE8gdmhvc3RfaGFzX3dvcmsoKSBpcyBraW5kIG9mCj4gaW50 ZXJydXB0aW9uIHJhdGhlciB0aGFuIGEgc2lnbmFsIHRvIGNvbXBsZXRlbHkgY2FuY2VsIHRoZSBi dXN5cG9sbCwgc28KPiBsZXQncyBydW4gYnVzeXBvbGwgYWZ0ZXIgdGhlIG5lY2Vzc2FyeSB3b3Jr IGlzIGRvbmUuCj4KPiBTaWduZWQtb2ZmLWJ5OiBUb3NoaWFraSBNYWtpdGEgPG1ha2l0YS50b3No aWFraUBsYWIubnR0LmNvLmpwPgo+IC0tLQo+ICAgZHJpdmVycy92aG9zdC9uZXQuYyB8IDM1ICsr KysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgMjIg aW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy92 aG9zdC9uZXQuYyBiL2RyaXZlcnMvdmhvc3QvbmV0LmMKPiBpbmRleCAzOTM5YzUwLi44MTFjMGU1 IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvdmhvc3QvbmV0LmMKPiArKysgYi9kcml2ZXJzL3Zob3N0 L25ldC5jCj4gQEAgLTM5NiwxMyArMzk2LDEwIEBAIHN0YXRpYyBpbmxpbmUgdW5zaWduZWQgbG9u ZyBidXN5X2Nsb2NrKHZvaWQpCj4gICAJcmV0dXJuIGxvY2FsX2Nsb2NrKCkgPj4gMTA7Cj4gICB9 Cj4gICAKPiAtc3RhdGljIGJvb2wgdmhvc3RfY2FuX2J1c3lfcG9sbChzdHJ1Y3Qgdmhvc3RfZGV2 ICpkZXYsCj4gLQkJCQl1bnNpZ25lZCBsb25nIGVuZHRpbWUpCj4gK3N0YXRpYyBib29sIHZob3N0 X2Nhbl9idXN5X3BvbGwodW5zaWduZWQgbG9uZyBlbmR0aW1lKQo+ICAgewo+IC0JcmV0dXJuIGxp a2VseSghbmVlZF9yZXNjaGVkKCkpICYmCj4gLQkgICAgICAgbGlrZWx5KCF0aW1lX2FmdGVyKGJ1 c3lfY2xvY2soKSwgZW5kdGltZSkpICYmCj4gLQkgICAgICAgbGlrZWx5KCFzaWduYWxfcGVuZGlu ZyhjdXJyZW50KSkgJiYKPiAtCSAgICAgICAhdmhvc3RfaGFzX3dvcmsoZGV2KTsKPiArCXJldHVy biBsaWtlbHkoIW5lZWRfcmVzY2hlZCgpICYmICF0aW1lX2FmdGVyKGJ1c3lfY2xvY2soKSwgZW5k dGltZSkgJiYKPiArCQkgICAgICAhc2lnbmFsX3BlbmRpbmcoY3VycmVudCkpOwo+ICAgfQo+ICAg Cj4gICBzdGF0aWMgdm9pZCB2aG9zdF9uZXRfZGlzYWJsZV92cShzdHJ1Y3Qgdmhvc3RfbmV0ICpu LAo+IEBAIC00MzQsNyArNDMxLDggQEAgc3RhdGljIGludCB2aG9zdF9uZXRfZW5hYmxlX3ZxKHN0 cnVjdCB2aG9zdF9uZXQgKm4sCj4gICBzdGF0aWMgaW50IHZob3N0X25ldF90eF9nZXRfdnFfZGVz YyhzdHJ1Y3Qgdmhvc3RfbmV0ICpuZXQsCj4gICAJCQkJICAgIHN0cnVjdCB2aG9zdF92aXJ0cXVl dWUgKnZxLAo+ICAgCQkJCSAgICBzdHJ1Y3QgaW92ZWMgaW92W10sIHVuc2lnbmVkIGludCBpb3Zf c2l6ZSwKPiAtCQkJCSAgICB1bnNpZ25lZCBpbnQgKm91dF9udW0sIHVuc2lnbmVkIGludCAqaW5f bnVtKQo+ICsJCQkJICAgIHVuc2lnbmVkIGludCAqb3V0X251bSwgdW5zaWduZWQgaW50ICppbl9u dW0sCj4gKwkJCQkgICAgYm9vbCAqYnVzeWxvb3BfaW50cikKPiAgIHsKPiAgIAl1bnNpZ25lZCBs b25nIHVuaW5pdGlhbGl6ZWRfdmFyKGVuZHRpbWUpOwo+ICAgCWludCByID0gdmhvc3RfZ2V0X3Zx X2Rlc2ModnEsIHZxLT5pb3YsIEFSUkFZX1NJWkUodnEtPmlvdiksCj4gQEAgLTQ0Myw5ICs0NDEs MTUgQEAgc3RhdGljIGludCB2aG9zdF9uZXRfdHhfZ2V0X3ZxX2Rlc2Moc3RydWN0IHZob3N0X25l dCAqbmV0LAo+ICAgCWlmIChyID09IHZxLT5udW0gJiYgdnEtPmJ1c3lsb29wX3RpbWVvdXQpIHsK PiAgIAkJcHJlZW1wdF9kaXNhYmxlKCk7Cj4gICAJCWVuZHRpbWUgPSBidXN5X2Nsb2NrKCkgKyB2 cS0+YnVzeWxvb3BfdGltZW91dDsKPiAtCQl3aGlsZSAodmhvc3RfY2FuX2J1c3lfcG9sbCh2cS0+ ZGV2LCBlbmR0aW1lKSAmJgo+IC0JCSAgICAgICB2aG9zdF92cV9hdmFpbF9lbXB0eSh2cS0+ZGV2 LCB2cSkpCj4gKwkJd2hpbGUgKHZob3N0X2Nhbl9idXN5X3BvbGwoZW5kdGltZSkpIHsKPiArCQkJ aWYgKHZob3N0X2hhc193b3JrKHZxLT5kZXYpKSB7Cj4gKwkJCQkqYnVzeWxvb3BfaW50ciA9IHRy dWU7Cj4gKwkJCQlicmVhazsKPiArCQkJfQo+ICsJCQlpZiAoIXZob3N0X3ZxX2F2YWlsX2VtcHR5 KHZxLT5kZXYsIHZxKSkKPiArCQkJCWJyZWFrOwo+ICAgCQkJY3B1X3JlbGF4KCk7Cj4gKwkJfQo+ ICAgCQlwcmVlbXB0X2VuYWJsZSgpOwo+ICAgCQlyID0gdmhvc3RfZ2V0X3ZxX2Rlc2ModnEsIHZx LT5pb3YsIEFSUkFZX1NJWkUodnEtPmlvdiksCj4gICAJCQkJICAgICAgb3V0X251bSwgaW5fbnVt LCBOVUxMLCBOVUxMKTsKPiBAQCAtNTAxLDIwICs1MDUsMjQgQEAgc3RhdGljIHZvaWQgaGFuZGxl X3R4KHN0cnVjdCB2aG9zdF9uZXQgKm5ldCkKPiAgIAl6Y29weSA9IG52cS0+dWJ1ZnM7Cj4gICAK PiAgIAlmb3IgKDs7KSB7Cj4gKwkJYm9vbCBidXN5bG9vcF9pbnRyOwo+ICsKPiAgIAkJLyogUmVs ZWFzZSBETUFzIGRvbmUgYnVmZmVycyBmaXJzdCAqLwo+ICAgCQlpZiAoemNvcHkpCj4gICAJCQl2 aG9zdF96ZXJvY29weV9zaWduYWxfdXNlZChuZXQsIHZxKTsKPiAgIAo+IC0KPiArCQlidXN5bG9v cF9pbnRyID0gZmFsc2U7Cj4gICAJCWhlYWQgPSB2aG9zdF9uZXRfdHhfZ2V0X3ZxX2Rlc2MobmV0 LCB2cSwgdnEtPmlvdiwKPiAgIAkJCQkJCUFSUkFZX1NJWkUodnEtPmlvdiksCj4gLQkJCQkJCSZv dXQsICZpbik7Cj4gKwkJCQkJCSZvdXQsICZpbiwgJmJ1c3lsb29wX2ludHIpOwo+ICAgCQkvKiBP biBlcnJvciwgc3RvcCBoYW5kbGluZyB1bnRpbCB0aGUgbmV4dCBraWNrLiAqLwo+ICAgCQlpZiAo dW5saWtlbHkoaGVhZCA8IDApKQo+ICAgCQkJYnJlYWs7Cj4gICAJCS8qIE5vdGhpbmcgbmV3PyAg V2FpdCBmb3IgZXZlbnRmZCB0byB0ZWxsIHVzIHRoZXkgcmVmaWxsZWQuICovCj4gICAJCWlmICho ZWFkID09IHZxLT5udW0pIHsKPiAtCQkJaWYgKHVubGlrZWx5KHZob3N0X2VuYWJsZV9ub3RpZnko Jm5ldC0+ZGV2LCB2cSkpKSB7Cj4gKwkJCWlmICh1bmxpa2VseShidXN5bG9vcF9pbnRyKSkgewo+ ICsJCQkJdmhvc3RfcG9sbF9xdWV1ZSgmdnEtPnBvbGwpOwo+ICsJCQl9IGVsc2UgaWYgKHVubGlr ZWx5KHZob3N0X2VuYWJsZV9ub3RpZnkoJm5ldC0+ZGV2LCB2cSkpKSB7Cj4gICAJCQkJdmhvc3Rf ZGlzYWJsZV9ub3RpZnkoJm5ldC0+ZGV2LCB2cSk7Cj4gICAJCQkJY29udGludWU7Cj4gICAJCQl9 Cj4gQEAgLTY2Myw3ICs2NzEsOCBAQCBzdGF0aWMgaW50IHZob3N0X25ldF9yeF9wZWVrX2hlYWRf bGVuKHN0cnVjdCB2aG9zdF9uZXQgKm5ldCwgc3RydWN0IHNvY2sgKnNrKQo+ICAgCQlwcmVlbXB0 X2Rpc2FibGUoKTsKPiAgIAkJZW5kdGltZSA9IGJ1c3lfY2xvY2soKSArIHR2cS0+YnVzeWxvb3Bf dGltZW91dDsKPiAgIAo+IC0JCXdoaWxlICh2aG9zdF9jYW5fYnVzeV9wb2xsKCZuZXQtPmRldiwg ZW5kdGltZSkgJiYKPiArCQl3aGlsZSAodmhvc3RfY2FuX2J1c3lfcG9sbChlbmR0aW1lKSAmJgo+ ICsJCSAgICAgICAhdmhvc3RfaGFzX3dvcmsoJm5ldC0+ZGV2KSAmJgo+ICAgCQkgICAgICAgIXNr X2hhc19yeF9kYXRhKHNrKSAmJgo+ICAgCQkgICAgICAgdmhvc3RfdnFfYXZhaWxfZW1wdHkoJm5l dC0+ZGV2LCB0dnEpKQo+ICAgCQkJY3B1X3JlbGF4KCk7CgpBY2tlZC1ieTogSmFzb24gV2FuZyA8 amFzb3dhbmdAcmVkaGF0LmNvbT4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFsaXphdGlvbkBs aXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5v cmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg==