virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Zachary Amsden <zach@vmware.com>
Cc: "virtualization@lists.osdl.org" <virtualization@lists.osdl.org>
Subject: Re: paravirt patches in -mm
Date: Sat, 30 Sep 2006 22:15:31 -0700	[thread overview]
Message-ID: <20060930221531.be7b4cfc.akpm@osdl.org> (raw)
In-Reply-To: <451F483A.6000202@vmware.com>

On Sat, 30 Sep 2006 21:46:50 -0700
Zachary Amsden <zach@vmware.com> wrote:

> Andrew Morton wrote:
> > Guys, could you please confirm that these patches from -mm:
> >
> > paravirt-remove-read-hazard-from-cow.patch
> > paravirt-pte-clear-not-present.patch
> > paravirt-lazy-mmu-mode-hooks.patch
> > paravirt-combine-flush-accessed-dirty.patch
> > paravirt-kpte-flush.patch
> > paravirt-optimize-ptep-establish-for-pae.patch
> > paravirt-remove-set-pte-atomic.patch
> > paravirt-pae-compile-fix.patch
> > paravirt-update-pte-hook.patch
> >
> > are suitable for mainline inclusion?
> >   
> 
> Yes, these are all originally by me, and they are suitable for 
> mainline.  They are either nops in mainline or are actually enhancements 
> to mainline, simplifying or optimizing the pte accessors on i386 and 
> have zero impact (or improved) impact on code generation and 
> performance.

OK, thanks.

>  The only regrettable fact is that I broke PAE somewhere in 
> the middle of the series (thus requiring paravirt-pae-compile-fix as a 
> separate patch, when I should have rolled the fix into the proper 
> patch).

I can find no PAE compile error, and paravirt-pae-compile-fix.patch just
removes a few config.h inclusions.

>  But if you take the whole batch, there is no problem.

Well we don't like to break the build partway through a patch series
because that makes git-bisecting a pain if you happen to land at a bad
spot.

<ten compiles later>

It all looks good to me. 

  reply	other threads:[~2006-10-01  5:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-01  4:01 paravirt patches in -mm Andrew Morton
2006-10-01  4:46 ` Zachary Amsden
2006-10-01  5:15   ` Andrew Morton [this message]
2006-10-02  6:48     ` Zachary Amsden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060930221531.be7b4cfc.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=virtualization@lists.osdl.org \
    --cc=zach@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).