From: Zachary Amsden <zach@vmware.com>
To: Andrew Morton <akpm@osdl.org>,
Rusty Russell <rusty@rustcorp.com.au>, Andi Kleen <ak@muc.de>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Chris Wright <chrisw@sous-sol.org>,
Virtualization Mailing List <virtualization@lists.osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Zachary Amsden <zach@vmware.com>
Subject: [PATCH 1/5] Skip timer works.patch
Date: Thu, 19 Oct 2006 17:09:22 -0700 [thread overview]
Message-ID: <200610200009.k9K09MrS027558@zach-dev.vmware.com> (raw)
Add a way to disable the timer IRQ routing check via a boot option. The
VMI timer code uses this to avoid triggering the pester Mingo code, which
probes for some very unusual and broken motherboard routings. It fires
100% of the time when using a paravirtual delay mechanism instead of
using a realtime delay, since there is no elapsed real time, and the 4 timer
IRQs have not yet been delivered.
In addition, it is entirely possible, though improbable, that this bug
could surface on real hardware which picks a particularly bad time to enter
SMM mode, causing a long latency during one of the timer IRQs.
While here, make check_timer be __init.
Signed-off-by: Zachary Amsden <zach@vmware.com>
===================================================================
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -603,8 +603,6 @@ and is between 256 and 4096 characters.
hugepages= [HW,IA-32,IA-64] Maximal number of HugeTLB pages.
- noirqbalance [IA-32,SMP,KNL] Disable kernel irq balancing
-
i8042.direct [HW] Put keyboard port into non-translated mode
i8042.dumbkbd [HW] Pretend that controller can only read data from
keyboard and cannot control its state
@@ -1060,8 +1058,13 @@ and is between 256 and 4096 characters.
in certain environments such as networked servers or
real-time systems.
+ noirqbalance [IA-32,SMP,KNL] Disable kernel irq balancing
+
noirqdebug [IA-32] Disables the code which attempts to detect and
disable unhandled interrupt sources.
+
+ noirqtest [IA-32,APIC] Disables the code which tests for broken
+ timer IRQ sources.
noisapnp [ISAPNP] Disables ISA PnP code.
===================================================================
--- a/arch/i386/kernel/io_apic.c
+++ b/arch/i386/kernel/io_apic.c
@@ -1864,6 +1864,15 @@ static void __init setup_ioapic_ids_from
static void __init setup_ioapic_ids_from_mpc(void) { }
#endif
+int timer_irq_really_works __initdata;
+int __init irqtest_disable(char *str)
+{
+ timer_irq_really_works = 1;
+ return 1;
+}
+
+__setup("noirqtest", irqtest_disable);
+
/*
* There is a nasty bug in some older SMP boards, their mptable lies
* about the timer IRQ. We do the following to work around the situation:
@@ -1872,9 +1881,12 @@ static void __init setup_ioapic_ids_from
* - if this function detects that timer IRQs are defunct, then we fall
* back to ISA timer IRQs
*/
-static int __init timer_irq_works(void)
+int __init timer_irq_works(void)
{
unsigned long t1 = jiffies;
+
+ if (timer_irq_really_works)
+ return 1;
local_irq_enable();
/* Let ten ticks pass... */
@@ -2146,7 +2158,7 @@ int timer_uses_ioapic_pin_0;
* is so screwy. Thanks to Brian Perkins for testing/hacking this beast
* fanatically on his truly buggy board.
*/
-static inline void check_timer(void)
+static inline void __init check_timer(void)
{
int apic1, pin1, apic2, pin2;
int vector;
next reply other threads:[~2006-10-20 0:09 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-20 0:09 Zachary Amsden [this message]
2006-10-27 14:56 ` [PATCH 1/5] Skip timer works.patch Andi Kleen
2006-10-27 19:09 ` Zachary Amsden
2006-10-27 21:16 ` Andi Kleen
2006-10-30 20:54 ` Zachary Amsden
2006-10-30 22:50 ` Andi Kleen
2006-10-30 23:09 ` Zachary Amsden
2006-10-30 23:12 ` Andi Kleen
2006-10-30 23:24 ` Zachary Amsden
2006-10-30 23:50 ` Andi Kleen
2006-11-15 8:03 ` Chris Wright
2006-11-15 8:21 ` Zachary Amsden
2006-11-15 22:40 ` Chris Wright
2006-11-15 22:54 ` Chris Wright
2006-11-16 3:27 ` Andi Kleen
2006-11-16 3:37 ` Chris Wright
2006-11-16 3:37 ` Andi Kleen
2006-11-16 5:06 ` Andrew Morton
2006-11-16 6:13 ` Zachary Amsden
2006-11-16 7:23 ` Andi Kleen
2006-11-16 7:02 ` Andi Kleen
2006-11-16 7:16 ` Chris Wright
2006-11-16 8:26 ` Chris Wright
2006-11-16 10:28 ` Chris Wright
2006-11-16 13:16 ` Andi Kleen
2006-11-16 19:03 ` Chris Wright
2006-11-16 19:46 ` Andi Kleen
2006-11-16 20:24 ` Chris Wright
2006-11-17 4:47 ` Andi Kleen
2006-11-17 7:33 ` Chris Wright
2006-11-17 7:38 ` Andi Kleen
2006-11-16 22:53 ` Andrew Morton
2006-11-16 23:08 ` Zachary Amsden
2006-11-16 23:10 ` Chris Wright
2006-11-17 5:05 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610200009.k9K09MrS027558@zach-dev.vmware.com \
--to=zach@vmware.com \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=chrisw@sous-sol.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).