From: Andrew Morton <akpm@osdl.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Pavel Machek <pavel@ucw.cz>,
Rusty Russell <rusty@rustcorp.com.au>,
virtualization <virtualization@lists.osdl.org>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] Prep for paravirt: Be careful about touching BIOS address space
Date: Fri, 27 Oct 2006 14:41:57 -0700 [thread overview]
Message-ID: <20061027144157.f23fcf89.akpm@osdl.org> (raw)
In-Reply-To: <45427ABD.6070407@goop.org>
On Fri, 27 Oct 2006 14:31:41 -0700
Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> Pavel Machek wrote:
> > Indentation is b0rken here.
> >
>
> Oops. How strange.
>
> > And... is get_user right primitive for accessing area that may not be
> > there?
>
> I'm pretty sure there's precedent for using __get_user in this way
> (get_user is a different matter, since it cares about whether the
> address is within the user part of the address space). Certainly in
> arch/i386 code there shouldn't be a problem. Is there some other way to
> achieve the same effect (without manually setting up an exception/fixup
> block)?
It'd be better to use include/linux/uaccess.h:probe_kernel_address() for
this operation.
next prev parent reply other threads:[~2006-10-27 21:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-27 3:38 [PATCH 1/4] Prep for paravirt: move pagetable includes Rusty Russell
2006-10-27 3:42 ` [PATCH 1/4] Prep for paravirt: Be careful about touching BIOS address space Rusty Russell
2006-10-27 3:43 ` [PATCH 2/4] Prep for paravirt: cpu_detect extraction Rusty Russell
2006-10-27 3:45 ` [PATCH 3/4] Prep for paravirt: desc.h clearer parameter names, some code motion Rusty Russell
2006-10-27 3:46 ` [PATCH 4/4] Prep for paravirt: rearrange processor.h Rusty Russell
2006-10-29 20:01 ` [PATCH] Re: [PATCH 3/4] Prep for paravirt: desc.h clearer parameter names, some code motion Don Mullis
2006-10-29 21:06 ` Andi Kleen
2006-10-29 21:44 ` Don Mullis
2006-10-30 0:05 ` Rusty Russell
2006-10-27 11:30 ` [PATCH 1/4] Prep for paravirt: Be careful about touching BIOS address space Pavel Machek
2006-10-27 21:31 ` Jeremy Fitzhardinge
2006-10-27 21:41 ` Andrew Morton [this message]
2006-10-28 4:33 ` Jeremy Fitzhardinge
2006-10-28 4:50 ` Andrew Morton
2006-10-30 2:35 ` Rusty Russell
2006-10-29 20:01 ` Don Mullis
2006-10-27 10:30 ` [PATCH 1/4] Prep for paravirt: move pagetable includes Zachary Amsden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061027144157.f23fcf89.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).