Re: [PATCH 1/5] Skip timer works.patch

[Andi Kleen <ak@suse.de>]

On Wed, Nov 15, 2006 at 07:37:03PM -0800, Chris Wright wrote:
> * Andi Kleen (ak@suse.de) wrote:
> > I got Andrew's patches now but the result doesn't compile as earlier
> > (on SUSE 10.0, gcc 4.0)
> > 
> > I'll adapt my old make-it-compile patch that fixed the inline assembly. 
> > Hopefully it'll work then.
> > 
> > -Andi
> > 
> > /home/lsrc/quilt/linux/kernel/spinlock.c: In function '_spin_lock_irqsave':
> > include2/asm/spinlock.h:59: error: invalid 'asm': operand number missing after %
> > -letter
> > include2/asm/spinlock.h:59: error: invalid 'asm': operand number missing after %
> > -letter
> > include2/asm/spinlock.h:59: error: invalid 'asm': operand number missing after %
> > -letter
> > include2/asm/spinlock.h:59: error: invalid 'asm': operand number missing after %
> > -letter
> > include2/asm/spinlock.h:59: error: invalid 'asm': operand number missing after %
> > -letter
> > include2/asm/spinlock.h:59: error: invalid 'asm': operand number missing after %
> > -letter
> > include2/asm/spinlock.h:59: error: invalid 'asm': operand number missing after %
> > -letter
> > include2/asm/spinlock.h:59: error: invalid 'asm': operand number missing after %
> > -letter
> > {standard input}: Assembler messages:
> > {standard input}:593: Error: undefined symbol `paravirt_ops' in operation
> > {standard input}:593: Error: undefined symbol `PARAVIRT_irq_enable' in operation
> > {standard input}:605: Error: undefined symbol `paravirt_ops' in operation
> > {standard input}:605: Error: undefined symbol `PARAVIRT_irq_disable' in operation
> 
> That should be fixed (it is over here). 

Ok.

I think my old paravirt-broken diff fixed it too (among other things), but it 
would be better to use your version.


> Is ff quilt stuff uptodate?

Not yet.  I was just merging the latest -git. Will push it out soon.

> I can sync up with it and diff to see what you might be missing.

Please.

> 
> > ICECREAM[14067]: Compiled on 10.23.204.76
> 
> mmm, ice cream ;-)

It sometimes causes interesting effect with funky assembly -- e.g. .include doesn't
work because the assembler runs on a different host. But that shouldn't be the
case here.

-Andi