From: Randy Dunlap <randy.dunlap@oracle.com>
To: Andrew Morton <akpm@osdl.org>
Cc: zippel@linux-m68k.org,
"virtualization@lists.osdl.org" <virtualization@lists.osdl.org>,
linux-kernel@vger.kernel.org, Adrian Bunk <bunk@stusta.de>
Subject: Re: 2.6.19-rc5-mm2: paravirt X86_PAE=y compile error
Date: Tue, 28 Nov 2006 15:36:35 -0800 [thread overview]
Message-ID: <20061128153635.abaeb1fc.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20061115153614.a71f944d.akpm@osdl.org>
On Wed, 15 Nov 2006 15:36:14 -0800 Andrew Morton wrote:
> On Thu, 16 Nov 2006 00:16:26 +0100
> Adrian Bunk <bunk@stusta.de> wrote:
>
> > Paravirt breaks CONFIG_X86_PAE=y compilation:
> >
> > <-- snip -->
> >
> > ...
> > CC init/main.o
> > In file included from include2/asm/pgtable.h:245,
> > from
> > /home/bunk/linux/kernel-2.6/linux-2.6.19-rc5-mm2/include/linux/mm.h:40,
> > from
> > /home/bunk/linux/kernel-2.6/linux-2.6.19-rc5-mm2/include/linux/poll.h:11,
> > from
> > /home/bunk/linux/kernel-2.6/linux-2.6.19-rc5-mm2/include/linux/rtc.h:113,
> > from
> > /home/bunk/linux/kernel-2.6/linux-2.6.19-rc5-mm2/include/linux/efi.h:19,
> > from
> > /home/bunk/linux/kernel-2.6/linux-2.6.19-rc5-mm2/init/main.c:43:
> > include2/asm/pgtable-3level.h:108: error: redefinition of 'pte_clear'
> > include2/asm/paravirt.h:365: error: previous definition of 'pte_clear' was here
> > include2/asm/pgtable-3level.h:115: error: redefinition of 'pmd_clear'
> > include2/asm/paravirt.h:370: error: previous definition of 'pmd_clear' was here
> > make[2]: *** [init/main.o] Error 1
> >
>
> So it does. Zach will save us.
>
> How come allmodconfig doesn't select highmem?
Must be because of "choice" and its default:
choice
prompt "High Memory Support"
default NOHIGHMEM
Changing the default fixes it. I suppose conf.c could be
hacked to do something different on choices, but it's not
clear how/what to do there as a general rule.
---
From: Randy Dunlap <randy.dunlap@oracle.com>
Make ix86 default to HIGHMEM4G instead of NOHIGHMEM.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
arch/i386/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-2.6.19-rc6-git10.orig/arch/i386/Kconfig
+++ linux-2.6.19-rc6-git10/arch/i386/Kconfig
@@ -443,7 +443,8 @@ source "drivers/firmware/Kconfig"
choice
prompt "High Memory Support"
- default NOHIGHMEM
+ default HIGHMEM4G if !X86_NUMAQ
+ default HIGHMEM64G if X86_NUMAQ
config NOHIGHMEM
bool "off"
prev parent reply other threads:[~2006-11-28 23:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061114014125.dd315fff.akpm@osdl.org>
[not found] ` <20061114225622.GO22565@stusta.de>
2006-11-14 23:09 ` 2.6.19-rc5-mm2: warnings in MODPOST and later Andrew Morton
2006-11-15 7:42 ` Arjan van de Ven
[not found] ` <20061115231626.GC31879@stusta.de>
2006-11-15 23:36 ` 2.6.19-rc5-mm2: paravirt X86_PAE=y compile error Andrew Morton
2006-11-16 1:30 ` Zachary Amsden
2006-11-16 2:27 ` Chris Wright
2006-11-16 7:05 ` Andi Kleen
2006-11-28 23:36 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061128153635.abaeb1fc.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).