From: Andi Kleen <ak@muc.de>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Andrew Morton <akpm@osdl.org>,
virtualization <virtualization@lists.osdl.org>,
Linus Torvalds <torvalds@osdl.org>, Neil Brown <neilb@suse.de>,
Ingo Molnar <mingo@elte.hu>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Use correct macros in raid code, not raw asm
Date: 29 Dec 2006 12:13:55 +0100
Date: Fri, 29 Dec 2006 12:13:55 +0100 [thread overview]
Message-ID: <20061229111355.GA82929@muc.de> (raw)
In-Reply-To: <1167350803.30506.49.camel@localhost.localdomain>
>
> The code looks like it's designed to be included from userspace for
> testing; as it compiles without this include (and has no other
> includes), I chose not to add it.
>
> Linus makes a good point, but someone who actually knows the code
> should, y'know, test it and stuff...
It should use kernel_fpu_begin() imho. If someone wants to test
it in user space again they can add dummy definitions of that
to their user space header.
-Andi
next prev parent reply other threads:[~2006-12-29 11:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-28 23:34 [PATCH] Use correct macros in raid code, not raw asm Rusty Russell
2006-12-28 23:51 ` Linus Torvalds
2006-12-28 23:56 ` Andrew Morton
2006-12-29 0:06 ` Rusty Russell
2006-12-29 11:13 ` Andi Kleen [this message]
2007-02-09 1:20 ` H. Peter Anvin
2007-02-09 1:37 ` Neil Brown
2007-02-09 1:43 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061229111355.GA82929@muc.de \
--to=ak@muc.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=neilb@suse.de \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@osdl.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).