virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Andi Kleen <ak@muc.de>
Cc: Chris Wright <chrisw@sous-sol.org>,
	virtualization@lists.osdl.org, xen-devel@lists.xensource.com,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: [patch 02/24] Xen-paravirt_ops: Clean up ELF note generation
Date: Wed, 21 Feb 2007 12:52:56 -0800	[thread overview]
Message-ID: <20070221205322.515407374@goop.org> (raw)
In-Reply-To: 20070221205254.169835700@goop.org

[-- Attachment #1: cleanup-note-generation.patch --]
[-- Type: text/plain, Size: 1693 bytes --]

Three cleanups:

1: ELF notes are never mapped, so there's no need to have any access
flags in their phdr.

2: When generating them from asm, tell the assembler to use a SHT_NOTE
section type.  There doesn't seem to be a way to do this from C.

3: Use ANSI rather than traditional cpp behaviour to stringify the
macro argument.

Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>
Cc: Eric W. Biederman <ebiederm@xmission.com>

===================================================================
--- a/arch/i386/kernel/vmlinux.lds.S
+++ b/arch/i386/kernel/vmlinux.lds.S
@@ -34,7 +34,7 @@ PHDRS {
 PHDRS {
 	text PT_LOAD FLAGS(5);	/* R_E */
 	data PT_LOAD FLAGS(7);	/* RWE */
-	note PT_NOTE FLAGS(4);	/* R__ */
+	note PT_NOTE FLAGS(0);	/* ___ */
 }
 SECTIONS
 {
===================================================================
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -208,7 +208,7 @@
 	}
 
 #define NOTES								\
-		.notes : { *(.note.*) } :note
+	.notes : { *(.note.*) } :note
 
 #define INITCALLS							\
   	*(.initcall0.init)						\
===================================================================
--- a/include/linux/elfnote.h
+++ b/include/linux/elfnote.h
@@ -39,12 +39,12 @@
  *      ELFNOTE(XYZCo, 12, .long, 0xdeadbeef)
  */
 #define ELFNOTE(name, type, desctype, descdata)	\
-.pushsection .note.name			;	\
+.pushsection .note.name, "",@note	;	\
   .align 4				;	\
   .long 2f - 1f		/* namesz */	;	\
   .long 4f - 3f		/* descsz */	;	\
   .long type				;	\
-1:.asciz "name"				;	\
+1:.asciz #name				;	\
 2:.align 4				;	\
 3:desctype descdata			;	\
 4:.align 4				;	\

-- 

  parent reply	other threads:[~2007-02-21 20:52 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-21 20:52 [patch 00/24] Xen-paravirt_ops: Xen guest implementation for paravirt_ops interface Jeremy Fitzhardinge
2007-02-21 20:52 ` [patch 01/24] Xen-paravirt_ops: No need to use -traditional for processing asm in arch/i386/ Jeremy Fitzhardinge
2007-02-21 20:52 ` Jeremy Fitzhardinge [this message]
2007-02-21 20:52 ` [patch 03/24] Xen-paravirt_ops: Fix typo in sync_constant_test_bit()s name Jeremy Fitzhardinge
2007-02-21 20:52 ` [patch 04/24] Xen-paravirt_ops: ignore vgacon if hardware not present Jeremy Fitzhardinge
2007-02-21 20:52 ` [patch 05/24] Xen-paravirt_ops: Add pagetable accessors to pack and unpack pagetable entries Jeremy Fitzhardinge
2007-02-21 22:15   ` Andi Kleen
2007-02-21 22:20     ` Jeremy Fitzhardinge
2007-02-21 23:20     ` Rusty Russell
2007-02-21 23:27       ` Jeremy Fitzhardinge
2007-02-21 20:53 ` [patch 06/24] Xen-paravirt_ops: paravirt_ops: hooks to set up initial pagetable Jeremy Fitzhardinge
2007-02-21 20:53 ` [patch 07/24] Xen-paravirt_ops: paravirt_ops: allocate a fixmap slot Jeremy Fitzhardinge
2007-02-21 20:53 ` [patch 08/24] Xen-paravirt_ops: Allow paravirt backend to choose kernel PMD sharing Jeremy Fitzhardinge
2007-02-21 20:53 ` [patch 09/24] Xen-paravirt_ops: add hooks to intercept mm creation and destruction Jeremy Fitzhardinge
2007-02-21 20:53 ` [patch 10/24] Xen-paravirt_ops: remove HAVE_ARCH_MM_LIFETIME, define no-op architecture implementations Jeremy Fitzhardinge
2007-02-21 20:53 ` [patch 11/24] Xen-paravirt_ops: Add apply_to_page_range() which applies a function to a pte range Jeremy Fitzhardinge
2007-02-21 20:53 ` [patch 12/24] Xen-paravirt_ops: Allocate and free vmalloc areas Jeremy Fitzhardinge
2007-02-21 20:53 ` [patch 13/24] Xen-paravirt_ops: Add nosegneg capability to the vsyscall page notes Jeremy Fitzhardinge
2007-02-21 20:53 ` [patch 14/24] Xen-paravirt_ops: Add XEN config options Jeremy Fitzhardinge
2007-02-21 20:53 ` [patch 15/24] Xen-paravirt_ops: Add Xen interface header files Jeremy Fitzhardinge
2007-02-21 20:53 ` [patch 16/24] Xen-paravirt_ops: Core Xen implementation Jeremy Fitzhardinge
2007-02-21 20:53 ` [patch 17/24] Xen-paravirt_ops: avoid having a bad selector in %gs during context switch Jeremy Fitzhardinge
2007-02-21 22:10   ` Andi Kleen
2007-02-21 22:14     ` Jeremy Fitzhardinge
2007-02-21 22:16     ` Keir Fraser
2007-02-21 23:25     ` Zachary Amsden
2007-02-21 23:29       ` Jeremy Fitzhardinge
2007-02-21 20:53 ` [patch 18/24] Xen-paravirt_ops: Some generic early printk & boot console fixups Jeremy Fitzhardinge
2007-02-22  3:10   ` Andrew Morton
2007-02-22  5:48     ` Jeremy Fitzhardinge
2007-02-22  8:33       ` Gerd Hoffmann
2007-02-21 20:53 ` [patch 19/24] Xen-paravirt_ops: Use the hvc console infrastructure for Xen console Jeremy Fitzhardinge
2007-02-21 20:53 ` [patch 20/24] Xen-paravirt_ops: Add early printk support via hvc console Jeremy Fitzhardinge
2007-02-21 20:53 ` [patch 21/24] Xen-paravirt_ops: Add Xen grant table support Jeremy Fitzhardinge
2007-02-21 20:53 ` [patch 22/24] Xen-paravirt_ops: Add the Xenbus sysfs and virtual device hotplug driver Jeremy Fitzhardinge
2007-02-21 20:53 ` [patch 23/24] Xen-paravirt_ops: Add Xen virtual block device driver Jeremy Fitzhardinge
2007-02-21 20:53 ` [patch 24/24] Xen-paravirt_ops: Add the Xen virtual network " Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070221205322.515407374@goop.org \
    --to=jeremy@goop.org \
    --cc=ak@muc.de \
    --cc=akpm@linux-foundation.org \
    --cc=chrisw@sous-sol.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.osdl.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).