From: Benjamin LaHaise <bcrl@kvack.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Zachary Amsden <zach@vmware.com>,
xen-devel@lists.xensource.com, virtualization@lists.osdl.org,
Rusty Russell <rusty@rustcorp.com.au>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@suse.de>,
Chris Wright <chrisw@sous-sol.org>, Andi Kleen <ak@muc.de>,
Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch 28/34] Xen-pv_ops: Xen SMP guest support
Date: Wed, 14 Mar 2007 09:28:20 -0400 [thread overview]
Message-ID: <20070314132820.GL6209@kvack.org> (raw)
In-Reply-To: <20070313233034.586018620@goop.org>
On Tue, Mar 13, 2007 at 04:30:45PM -0700, Jeremy Fitzhardinge wrote:
> [ brcl, mingo: Would you mind having a close look at the code in
> xen_exit_mm and drop_mm_ref? - Thanks ]
I see what you're doing here, and this comment seems to allude to the reasons
behind it without spelling it out.
> +/*
> + * We aggressively remove defunct pgd from cr3. We execute unmap_vmas()
> + * *much* faster this way.
> + */
Are you switching mms in order to avoid all of the overhead associated with
flushing an active mm during task exit? If so, it makes much more sense to
do this in the generic helper, as it should be a win on x86 and x86-64
where switching to init_mm is relatively low cost given the support for
global pages. I'll run some tests on a couple of systems this evening and
post the results.
-ben
--
"Time is of no importance, Mr. President, only life is important."
Don't Email: <zyntrop@kvack.org>.
next prev parent reply other threads:[~2007-03-14 13:28 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-13 23:30 [patch 00/34] Xen-pv_ops: Xen guest implementation for paravirt_ops interface Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 01/34] Xen-pv_ops: Fix typo in sync_constant_test_bit()s name Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 02/34] Xen-pv_ops: ignore vgacon if hardware not present Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 03/34] Xen-pv_ops: update MAINTAINERS Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 04/34] Xen-pv_ops: use paravirt_nop to consistently mark no-op operations Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 05/34] Xen-pv_ops: Add pagetable accessors to pack and unpack pagetable entries Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 06/34] Xen-pv_ops: Hooks to set up initial pagetable Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 07/34] Xen-pv_ops: Allocate a fixmap slot Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 08/34] Xen-pv_ops: Allow paravirt backend to choose kernel PMD sharing Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 09/34] Xen-pv_ops: add hooks to intercept mm creation and destruction Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 10/34] Xen-pv_ops: Simplify smp_call_function*() by using common implementation Jeremy Fitzhardinge
2007-03-16 2:38 ` Randy Dunlap
2007-03-13 23:30 ` [patch 11/34] Xen-pv_ops: Add smp_ops interface Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 12/34] Xen-pv_ops: rename struct paravirt_patch to paravirt_patch_site for clarity Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 13/34] Xen-pv_ops: Use patch site IDs computed from offset in paravirt_ops structure Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 14/34] Xen-pv_ops: Fix patch site clobbers to include return register Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 15/34] Xen-pv_ops: Consistently wrap paravirt ops callsites to make them patchable Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 16/34] Xen-pv_ops: add common patching machinery Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 17/34] Xen-pv_ops: add flush_tlb_others paravirt_op Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 18/34] Xen-pv_ops: revert map_pt_hook Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 19/34] Xen-pv_ops: add kmap_atomic_pte for mapping highpte pages Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 20/34] Xen-pv_ops: Add apply_to_page_range() which applies a function to a pte range Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 21/34] Xen-pv_ops: Allocate and free vmalloc areas Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 22/34] Xen-pv_ops: Add nosegneg capability to the vsyscall page notes Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 23/34] Xen-pv_ops: Add XEN config options Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 24/34] Xen-pv_ops: Add Xen interface header files Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 25/34] Xen-pv_ops: Core Xen implementation Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 26/34] Xen-pv_ops: Complete pagetable pinning for Xen Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 27/34] Xen-pv_ops: Implement Xen clockevent device Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 28/34] Xen-pv_ops: Xen SMP guest support Jeremy Fitzhardinge
2007-03-14 13:28 ` Benjamin LaHaise [this message]
2007-03-14 15:05 ` Jeremy Fitzhardinge
2007-03-14 20:23 ` Zachary Amsden
2007-03-13 23:30 ` [patch 29/34] Xen-pv_ops: Use the hvc console infrastructure for Xen console Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 30/34] Xen-pv_ops: Add early printk support via hvc console Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 31/34] Xen-pv_ops: Add Xen grant table support Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 32/34] Xen-pv_ops: Add the Xenbus sysfs and virtual device hotplug driver Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 33/34] Xen-pv_ops: Add Xen virtual block device driver Jeremy Fitzhardinge
2007-03-13 23:30 ` [patch 34/34] Xen-pv_ops: Add the Xen virtual network " Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070314132820.GL6209@kvack.org \
--to=bcrl@kvack.org \
--cc=ak@muc.de \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=chrisw@sous-sol.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.osdl.org \
--cc=xen-devel@lists.xensource.com \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).