From: Andrew Morton <akpm@linux-foundation.org>
To: Chris Wright <chrisw@sous-sol.org>
Cc: virtualization@lists.osdl.org,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] make CONFIG_PARAVIRT require NO_HZ
Date: Fri, 16 Mar 2007 16:18:54 -0800 [thread overview]
Message-ID: <20070316161854.9de1c784.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070316054746.GD10574@sequoia.sous-sol.org>
On Thu, 15 Mar 2007 22:47:46 -0700 Chris Wright <chrisw@sous-sol.org> wrote:
> Given all the discussion, let's just require NO_HZ when
> CONFIG_PARAVIRT. Anyone object?
>
> Signed-off-by: Chris Wright <chrisw@sous-sol.org>
> ---
>
> --- a/arch/i386/Kconfig Mon Mar 12 11:07:45 2007 -0700
> +++ b/arch/i386/Kconfig Mon Mar 12 16:53:14 2007 -0700
> @@ -208,7 +208,7 @@ endchoice
>
> config PARAVIRT
> bool "Paravirtualization support (EXPERIMENTAL)"
> - depends on EXPERIMENTAL
> + depends on EXPERIMENTAL && NO_HZ
> depends on !(X86_VISWS || X86_VOYAGER)
> help
> Paravirtualization is a way of running multiple instances of
Apart from all the other fun, it seems that we need to merge
kconfig-abort-configuration-with-recursive-dependencies.patch, because
scripts/kconfig/conf -m arch/i386/Kconfig
Error: Found recursive dependency: PARAVIRT NO_HZ PARAVIRT
make[1]: *** [allmodconfig] Error 1
make: *** [allmodconfig] Error 2
This is due to your patch interacting with
make-config_paravirt-require-no_hz.patch:
From: Chris Wright <chrisw@sous-sol.org>
Require NO_HZ when CONFIG_PARAVIRT.
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Acked-by: Zachary Amsden <zach@vmware.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Andi Kleen <ak@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
arch/i386/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN arch/i386/Kconfig~make-config_paravirt-require-no_hz arch/i386/Kconfig
--- a/arch/i386/Kconfig~make-config_paravirt-require-no_hz
+++ a/arch/i386/Kconfig
@@ -208,7 +208,7 @@ endchoice
config PARAVIRT
bool "Paravirtualization support (EXPERIMENTAL)"
- depends on EXPERIMENTAL
+ depends on EXPERIMENTAL && NO_HZ
depends on !(X86_VISWS || X86_VOYAGER)
select NO_HZ
help
_
I'll drop both of them while you guys sort it all out.
prev parent reply other threads:[~2007-03-17 0:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-16 5:47 [PATCH] make CONFIG_PARAVIRT require NO_HZ Chris Wright
2007-03-16 5:56 ` Zachary Amsden
2007-03-16 10:55 ` Ingo Molnar
2007-03-16 11:29 ` Andi Kleen
2007-03-16 11:48 ` Ingo Molnar
2007-03-16 16:09 ` Chris Wright
2007-03-17 0:18 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070316161854.9de1c784.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=chrisw@sous-sol.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).