From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH] make CONFIG_PARAVIRT require NO_HZ Date: Fri, 16 Mar 2007 16:18:54 -0800 Message-ID: <20070316161854.9de1c784.akpm@linux-foundation.org> References: <20070316054746.GD10574@sequoia.sous-sol.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20070316054746.GD10574@sequoia.sous-sol.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Chris Wright Cc: virtualization@lists.osdl.org, Thomas Gleixner , Ingo Molnar List-Id: virtualization@lists.linuxfoundation.org On Thu, 15 Mar 2007 22:47:46 -0700 Chris Wright wrote: > Given all the discussion, let's just require NO_HZ when > CONFIG_PARAVIRT. Anyone object? > = > Signed-off-by: Chris Wright > --- > = > --- a/arch/i386/Kconfig Mon Mar 12 11:07:45 2007 -0700 > +++ b/arch/i386/Kconfig Mon Mar 12 16:53:14 2007 -0700 > @@ -208,7 +208,7 @@ endchoice > = > config PARAVIRT > bool "Paravirtualization support (EXPERIMENTAL)" > - depends on EXPERIMENTAL > + depends on EXPERIMENTAL && NO_HZ > depends on !(X86_VISWS || X86_VOYAGER) > help > Paravirtualization is a way of running multiple instances of Apart from all the other fun, it seems that we need to merge kconfig-abort-configuration-with-recursive-dependencies.patch, because scripts/kconfig/conf -m arch/i386/Kconfig Error: Found recursive dependency: PARAVIRT NO_HZ PARAVIRT make[1]: *** [allmodconfig] Error 1 make: *** [allmodconfig] Error 2 This is due to your patch interacting with make-config_paravirt-require-no_hz.patch: From: Chris Wright Require NO_HZ when CONFIG_PARAVIRT. Signed-off-by: Chris Wright Cc: Jeremy Fitzhardinge Cc: Rusty Russell Acked-by: Zachary Amsden Cc: Ingo Molnar Cc: Thomas Gleixner Cc: Andi Kleen Signed-off-by: Andrew Morton --- arch/i386/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN arch/i386/Kconfig~make-config_paravirt-require-no_hz arch/i386/Kc= onfig --- a/arch/i386/Kconfig~make-config_paravirt-require-no_hz +++ a/arch/i386/Kconfig @@ -208,7 +208,7 @@ endchoice = config PARAVIRT bool "Paravirtualization support (EXPERIMENTAL)" - depends on EXPERIMENTAL + depends on EXPERIMENTAL && NO_HZ depends on !(X86_VISWS || X86_VOYAGER) select NO_HZ help _ I'll drop both of them while you guys sort it all out.