From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [patch 24/26] Xen-paravirt_ops: Add the Xenbus sysfs and virtual device hotplug driver. Date: Fri, 16 Mar 2007 10:53:16 -0700 Message-ID: <20070316175316.GA17091@kroah.com> References: <20070301232443.195603797@goop.org> <20070301232529.271605211@goop.org> <20070316084704.GB23174@elte.hu> <20070316161804.GH10574@sequoia.sous-sol.org> <20070316161948.GE9413@elte.hu> <20070316164023.GJ10574@sequoia.sous-sol.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20070316164023.GJ10574@sequoia.sous-sol.org> Sender: linux-kernel-owner@vger.kernel.org To: Chris Wright Cc: Ingo Molnar , Jeremy Fitzhardinge , Andi Kleen , Andrew Morton , linux-kernel@vger.kernel.org, virtualization@lists.osdl.org, xen-devel@lists.xensource.com, Zachary Amsden , Rusty Russell , Ian Pratt , Christian Limpach , Greg KH List-Id: virtualization@lists.linuxfoundation.org On Fri, Mar 16, 2007 at 09:40:23AM -0700, Chris Wright wrote: > * Ingo Molnar (mingo@elte.hu) wrote: > > please indicate any such review feedback (and approval) via > > signed-off-by lines done by that person. > > Certainly, Greg didn't sign off, he simply gave review feedback. Yeah, I did that a while ago, but I don't want to give my acked-by or signed-off for this code. While I can not find anything specfically wrong with it, it seems a bit "odd", but that might just be because I really don't understand what they are doing here, or why. And no, I really don't want to understand it either at the moment due to being busy with other things :) thanks, greg k-h