From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Andi Kleen <ak@suse.de>
Cc: virtualization@lists.osdl.org,
Andrew Morton <akpm@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: [patch 5/6] Allow boot-time disable of SMP altinstructions
Date: Tue, 03 Apr 2007 18:07:00 -0700 [thread overview]
Message-ID: <20070404011453.778754570@goop.org> (raw)
In-Reply-To: 20070404010655.400913479@goop.org
[-- Attachment #1: disable-smp-alternatives.patch --]
[-- Type: text/plain, Size: 2818 bytes --]
Add "noreplace-smp" to disable SMP instruction replacement.
Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>
---
Documentation/kernel-parameters.txt | 6 ++++++
arch/i386/kernel/alternative.c | 23 +++++++++++++++++++----
2 files changed, 25 insertions(+), 4 deletions(-)
===================================================================
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -1134,6 +1134,9 @@ and is between 256 and 4096 characters.
nomca [IA-64] Disable machine check abort handling
nomce [IA-32] Machine Check Exception
+
+ noreplace-smp [IA-32,SMP] Don't replace SMP instructions
+ with UP alternatives
noresidual [PPC] Don't use residual data on PReP machines.
@@ -1540,6 +1543,9 @@ and is between 256 and 4096 characters.
smart2= [HW]
Format: <io1>[,<io2>[,...,<io8>]]
+ smp-alt-once [IA-32,SMP] On a hotplug CPU system, only
+ attempt to substitute SMP alternatives once at boot.
+
snd-ad1816a= [HW,ALSA]
snd-ad1848= [HW,ALSA]
===================================================================
--- a/arch/i386/kernel/alternative.c
+++ b/arch/i386/kernel/alternative.c
@@ -5,6 +5,7 @@
#include <asm/alternative.h>
#include <asm/sections.h>
+static int noreplace_smp = 0;
static int smp_alt_once = 0;
static int debug_alternative = 0;
@@ -13,14 +14,22 @@ static int __init bootonly(char *str)
smp_alt_once = 1;
return 1;
}
+__setup("smp-alt-boot", bootonly);
+
static int __init debug_alt(char *str)
{
debug_alternative = 1;
return 1;
}
-
-__setup("smp-alt-boot", bootonly);
__setup("debug-alternative", debug_alt);
+
+static int __init setup_noreplace_smp(char *str)
+{
+ noreplace_smp = 1;
+ return 1;
+}
+__setup("noreplace-smp", setup_noreplace_smp);
+
#define DPRINTK(fmt, args...) if (debug_alternative) \
printk(KERN_DEBUG fmt, args)
@@ -185,6 +194,9 @@ static void alternatives_smp_unlock(u8 *
{
u8 **ptr;
+ if (noreplace_smp)
+ return;
+
for (ptr = start; ptr < end; ptr++) {
if (*ptr < text)
continue;
@@ -218,6 +230,9 @@ void alternatives_smp_module_add(struct
{
struct smp_alt_module *smp;
unsigned long flags;
+
+ if (noreplace_smp)
+ return;
if (smp_alt_once) {
if (boot_cpu_has(X86_FEATURE_UP))
@@ -253,7 +268,7 @@ void alternatives_smp_module_del(struct
struct smp_alt_module *item;
unsigned long flags;
- if (smp_alt_once)
+ if (smp_alt_once || noreplace_smp)
return;
spin_lock_irqsave(&smp_alt, flags);
@@ -284,7 +299,7 @@ void alternatives_smp_switch(int smp)
return;
#endif
- if (smp_alt_once)
+ if (noreplace_smp || smp_alt_once)
return;
BUG_ON(!smp && (num_online_cpus() > 1));
--
next prev parent reply other threads:[~2007-04-04 1:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-04 1:06 [patch 0/6] Various cleanups Jeremy Fitzhardinge
2007-04-04 1:06 ` [patch 1/6] Re-enable VDSO by default with PARAVIRT Jeremy Fitzhardinge
2007-04-04 16:57 ` Andi Kleen
2007-04-04 17:12 ` Jeremy Fitzhardinge
2007-04-04 1:06 ` [patch 2/6] Remove noreplacement option Jeremy Fitzhardinge
2007-04-04 1:06 ` [patch 3/6] Remove smp_alt_instructions Jeremy Fitzhardinge
2007-04-04 1:06 ` [patch 4/6] Rename the parainstructions symbols to be consistent with the others Jeremy Fitzhardinge
2007-04-04 2:03 ` Rusty Russell
2007-04-10 18:07 ` Andi Kleen
2007-04-10 18:44 ` Andrew Morton
2007-04-04 1:07 ` Jeremy Fitzhardinge [this message]
2007-04-04 1:07 ` [patch 6/6] Allow boot-time disable of paravirt_ops patching Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070404011453.778754570@goop.org \
--to=jeremy@goop.org \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).