From: Andrew Morton <akpm@linux-foundation.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Andi Kleen <ak@suse.de>,
virtualization@lists.osdl.org,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch 18/20] clean up tsc-based sched_clock
Date: Fri, 6 Apr 2007 16:22:33 -0700 [thread overview]
Message-ID: <20070406162233.b835bd4c.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070404191206.476822257@goop.org>
On Wed, 04 Apr 2007 12:12:09 -0700 Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> Three cleanups:
> - change "instable" -> "unstable"
> - its better to use get_cpu_var for getting this cpu's variables
> - change cycles_2_ns to do the full computation rather than just the
> tsc->ns scaling. Its a simpler interface, and it makes the function
> more generally useful.
>
> Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>
>
> ---
> arch/i386/kernel/sched-clock.c | 35 +++++++++++++++++++++--------------
I'm dropping the relevant patch from Andi's tree due to it causing
mysterious hangs when initscripts start ondemand. So I'll need to drop
this patch and "[patch 19/20] Add a sched_clock paravirt_op".
I still need to work out why that hang is happening - it is very
mysterious. I got as far as working out that it was hanging on
write_seqlock_irqsave(xtime_lock), then remembered that it's with
CONFIG_SMP=n so I stomped off to bed in disgust. Later.
next prev parent reply other threads:[~2007-04-06 23:22 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-04 19:11 [patch 00/20] paravirt_ops updates Jeremy Fitzhardinge
2007-04-04 19:11 ` [patch 01/20] update MAINTAINERS Jeremy Fitzhardinge
2007-04-04 19:11 ` [patch 02/20] Remove CONFIG_DEBUG_PARAVIRT Jeremy Fitzhardinge
2007-04-04 19:11 ` [patch 03/20] use paravirt_nop to consistently mark no-op operations Jeremy Fitzhardinge
2007-04-04 19:11 ` [patch 04/20] Add pagetable accessors to pack and unpack pagetable entries Jeremy Fitzhardinge
2007-04-04 19:11 ` [patch 05/20] Hooks to set up initial pagetable Jeremy Fitzhardinge
2007-04-04 19:11 ` [patch 06/20] Allocate a fixmap slot Jeremy Fitzhardinge
2007-04-04 19:11 ` [patch 07/20] Allow paravirt backend to choose kernel PMD sharing Jeremy Fitzhardinge
2007-04-05 0:30 ` Christoph Lameter
2007-04-05 0:43 ` Jeremy Fitzhardinge
2007-04-05 1:29 ` Chris Wright
2007-04-06 23:41 ` Andrew Morton
2007-04-07 0:02 ` Jeremy Fitzhardinge
2007-04-07 0:28 ` Andrew Morton
2007-04-07 0:40 ` Jeremy Fitzhardinge
2007-04-07 1:21 ` Andrew Morton
2007-04-07 5:47 ` Jeremy Fitzhardinge
2007-04-09 2:36 ` William Lee Irwin III
2007-04-04 19:11 ` [patch 08/20] add hooks to intercept mm creation and destruction Jeremy Fitzhardinge
2007-04-04 19:12 ` [patch 09/20] rename struct paravirt_patch to paravirt_patch_site for clarity Jeremy Fitzhardinge
2007-04-06 23:18 ` Andrew Morton
2007-04-06 23:24 ` Jeremy Fitzhardinge
2007-04-04 19:12 ` [patch 10/20] Use patch site IDs computed from offset in paravirt_ops structure Jeremy Fitzhardinge
2007-04-04 19:12 ` [patch 11/20] Fix patch site clobbers to include return register Jeremy Fitzhardinge
2007-04-04 19:12 ` [patch 12/20] Consistently wrap paravirt ops callsites to make them patchable Jeremy Fitzhardinge
2007-04-04 19:12 ` [patch 13/20] Document asm-i386/paravirt.h Jeremy Fitzhardinge
2007-04-04 19:12 ` [patch 14/20] add common patching machinery Jeremy Fitzhardinge
2007-04-04 19:12 ` [patch 15/20] add flush_tlb_others paravirt_op Jeremy Fitzhardinge
2007-04-04 19:12 ` [patch 16/20] revert map_pt_hook Jeremy Fitzhardinge
2007-04-04 19:12 ` [patch 17/20] add kmap_atomic_pte for mapping highpte pages Jeremy Fitzhardinge
2007-04-04 19:12 ` [patch 18/20] clean up tsc-based sched_clock Jeremy Fitzhardinge
2007-04-06 23:22 ` Andrew Morton [this message]
2007-04-06 23:27 ` Jeremy Fitzhardinge
2007-04-06 23:45 ` Andrew Morton
2007-04-06 23:40 ` Jeremy Fitzhardinge
2007-04-04 19:12 ` [patch 19/20] Add a sched_clock paravirt_op Jeremy Fitzhardinge
2007-04-04 19:12 ` [patch 20/20] Add apply_to_page_range() which applies a function to a pte range Jeremy Fitzhardinge
2007-04-05 4:41 ` Matt Mackall
2007-04-05 6:52 ` Jeremy Fitzhardinge
2007-04-17 20:56 ` Matt Mackall
2007-04-19 19:44 ` Jeremy Fitzhardinge
2007-04-19 19:59 ` Matt Mackall
2007-04-19 21:37 ` Jeremy Fitzhardinge
2007-04-19 21:30 ` Matt Mackall
2007-04-19 22:30 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070406162233.b835bd4c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@suse.de \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).