From: Randy Dunlap <randy.dunlap@oracle.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Andrew Morton <akpm@osdl.org>, Andi Kleen <ak@suse.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Virtualization Mailing List <virtualization@lists.osdl.org>
Subject: Re: [PATCH 1/2] Clean up asm-x86_64/bugs.h
Date: Mon, 9 Apr 2007 08:45:57 -0700 [thread overview]
Message-ID: <20070409084557.28748317.randy.dunlap@oracle.com> (raw)
In-Reply-To: <4617D339.3080801@goop.org>
On Sat, 07 Apr 2007 10:22:01 -0700 Jeremy Fitzhardinge wrote:
> Most of asm-x86_64/bugs.h is code which should be in a C file, so put it there.
>
> Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>
> Cc: Andi Kleen <ak@suse.de>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
>
> ---
> arch/x86_64/kernel/Makefile | 3 ++-
> arch/x86_64/kernel/bugs.c | 28 ++++++++++++++++++++++++++++
> include/asm-x86_64/alternative.h | 1 +
> include/asm-x86_64/bugs.h | 30 ++++--------------------------
> 4 files changed, 35 insertions(+), 27 deletions(-)
>
> ===================================================================
> --- /dev/null
> +++ b/arch/x86_64/kernel/bugs.c
> @@ -0,0 +1,28 @@
> +/*
> + * arch/x86_64/kernel/bugs.c
> + *
> + * Copyright (C) 1994 Linus Torvalds
> + * Copyright (C) 2000 SuSE
> + *
> + * This is included by init/main.c to check for architecture-dependent bugs.
drop comment.
Are you going to tackle asm-i386/bugs.h also?
Thanks.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2007-04-09 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-07 17:22 [PATCH 1/2] Clean up asm-x86_64/bugs.h Jeremy Fitzhardinge
2007-04-09 15:45 ` Randy Dunlap [this message]
2007-04-09 15:48 ` Jeremy Fitzhardinge
2007-04-09 15:49 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070409084557.28748317.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).