From mboxrd@z Thu Jan 1 00:00:00 1970 From: William Lee Irwin III Subject: Re: [PATCH 4/10] I386 pgd clone under lock fix.patch Date: Mon, 9 Apr 2007 17:27:50 -0700 Message-ID: <20070410002750.GZ2986@holomorphy.com> References: <200704100006.l3A06Bao020614@zach-dev.vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <200704100006.l3A06Bao020614@zach-dev.vmware.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Zachary Amsden Cc: Andrew Morton , Andi Kleen , Chris Wright , Virtualization Mailing List , Linux Kernel Mailing List List-Id: virtualization@lists.linuxfoundation.org On Mon, Apr 09, 2007 at 05:06:11PM -0700, Zachary Amsden wrote: > Copying of the pgd range must happen under the pgd_lock. This got broken= by > the paravirt changes in the -mm tree. Badness can result if you copy the= pgd > before being added to the list when splitting or rejoining large pages. > Signed-off-by: Zachary Amsden Sorry my review missed this. Acked-by: William Irwin -- wli