virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: James.Bottomley@hansenpartnership.com,
	virtualization@lists.osdl.org, "H. Peter Anvin" <hpa@zytor.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: The virtuailization patches break Voyager.
Date: Sat, 28 Apr 2007 11:34:52 +0200	[thread overview]
Message-ID: <200704281134.53160.ak@suse.de> (raw)
In-Reply-To: <m1zm4sgaqt.fsf@ebiederm.dsl.xmission.com>


> 
> The sane pattern is and seems to has always been.
> 
> arch_function()
> {
>         platform_ops.platform_function();
> }

Yes agreed. We'll slowly move there. Patches to accelerate it are
welcome (for post .22) 

But you're flaming the wrong person for this really. Jeremy and other
paravirt implementors have  done a lot of work of moving things into this 
direction.

> At the same time I find it very distressing how many functions named
> native_xxx we are accumulating.  Especially when all native refers is
> to the default i386 subarch and not to anything particularly native.
> Just one particular way something was implemented.

How else would you name and/or implement that?

> The fact that 2 level or 3 level page tables can't be selected at
> runtime seems to be a failing to think of themselves as a generic 
> a subarch mechanism.  I can't fault you to much for that one as
> that is a little off the beaten path.

That would really require generic mm changes to do properly. I know
PA-RISC does it without that, but that wouldn't fly on x86 I think
because PAE and non PAE are more different there.

-Andi

  parent reply	other threads:[~2007-04-28  9:34 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-28  6:40 The virtuailization patches break Voyager Eric W. Biederman
2007-04-28  6:59 ` Jeremy Fitzhardinge
2007-04-28  7:25   ` Eric W. Biederman
2007-04-28  7:52     ` Jeremy Fitzhardinge
2007-04-28  8:32       ` Eric W. Biederman
2007-04-28  8:52         ` Jeremy Fitzhardinge
2007-04-28  9:34         ` Andi Kleen [this message]
2007-04-28 16:05           ` James Bottomley
2007-04-28 17:15             ` Andi Kleen
2007-04-28  8:42       ` Andi Kleen
2007-04-28  9:13         ` Thomas Gleixner
2007-04-28  9:15           ` Jeremy Fitzhardinge
2007-04-28  9:39           ` Andi Kleen
2007-04-28  9:48             ` Thomas Gleixner
2007-04-28  9:15         ` Eric W. Biederman
2007-04-28  9:37           ` Andi Kleen
2007-04-28 15:24             ` Eric W. Biederman
2007-04-28 16:08             ` James Bottomley
2007-04-28 15:54         ` James Bottomley
2007-04-28 17:15           ` Andi Kleen
2007-04-28 16:40       ` H. Peter Anvin
2007-04-28 17:00         ` Eric W. Biederman
2007-04-28 17:07           ` H. Peter Anvin
2007-04-28 15:47 ` James Bottomley
2007-04-28 16:02   ` Eric W. Biederman
2007-04-28 16:18     ` Jeremy Fitzhardinge
2007-04-28 16:20     ` James Bottomley
2007-04-28 17:23       ` Andi Kleen
2007-04-28 17:22   ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200704281134.53160.ak@suse.de \
    --to=ak@suse.de \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=virtualization@lists.osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).