From: Christoph Hellwig <hch@infradead.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Jeff Garzik <jeff@garzik.org>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
virtualization@lists.osdl.org, ak@suse.de, jmorris@namei.org
Subject: Re: [patch 7/9] lguest: the net driver
Date: Wed, 9 May 2007 22:09:04 +0100 [thread overview]
Message-ID: <20070509210904.GA20064@infradead.org> (raw)
In-Reply-To: <1178723695.7286.164.camel@localhost.localdomain>
On Thu, May 10, 2007 at 01:14:55AM +1000, Rusty Russell wrote:
> > > + info->peer = (void *)ioremap(info->peer_phys, info->mapsize);
> >
> > check for NULL
>
> Erk, good catch!
Also the cast is bogus. ioremap already returns void already. Even
more importantly the lack of the __iomem annotations shows that either this
code hasn't been run through sparse or someone decided to ignore it's
errors.
next prev parent reply other threads:[~2007-05-09 21:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-09 9:51 [patch 7/9] lguest: the net driver akpm
2007-05-09 10:12 ` Herbert Xu
2007-05-09 11:55 ` Rusty Russell
2007-05-09 12:00 ` Herbert Xu
2007-05-09 12:13 ` Rusty Russell
2007-05-09 12:28 ` Jeff Garzik
2007-05-09 12:42 ` Andi Kleen
2007-05-09 15:14 ` Rusty Russell
2007-05-09 21:09 ` Christoph Hellwig [this message]
2007-05-10 5:33 ` Jeff Garzik
2007-05-10 10:12 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070509210904.GA20064@infradead.org \
--to=hch@infradead.org \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).