From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH 1/3] KVM paravirt_ops infrastructure Date: Thu, 31 May 2007 11:58:28 +0200 Message-ID: <200705311158.28632.ak@suse.de> References: <465D8F03.7000201@us.ibm.com> <465D8FA7.9050600@us.ibm.com> <1180573347.30202.135.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1180573347.30202.135.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Cc: kvm-devel , virtualization List-Id: virtualization@lists.linuxfoundation.org > > + if (wrmsr_safe(MSR_KVM_API_MAGIC, __pa(para_state), 0)) { > > + printk(KERN_INFO "KVM guest: WRMSR probe failed.\n"); > > + return -ENOENT; > > + } > > How about printk(KERN_INFO "I am not a KVM guest\n");? Actually paravirt probes that fail should be silent; similar like drivers that don't find their hardware should do the same. Otherwise if there are later distro kernels with various of those compiled in the boot log would become quite noisy -andi ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/