From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH 1/3] KVM paravirt_ops infrastructure Date: Thu, 31 May 2007 12:40:19 +0200 Message-ID: <200705311240.19794.ak@suse.de> References: <465D8F03.7000201@us.ibm.com> <200705311158.28632.ak@suse.de> <20070531101116.GA10872@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20070531101116.GA10872-X9Un+BFzKDI@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Ingo Molnar Cc: kvm-devel , virtualization , virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: virtualization@lists.linuxfoundation.org On Thursday 31 May 2007 12:11:16 Ingo Molnar wrote: > > * Andi Kleen wrote: > > > > > > > + if (wrmsr_safe(MSR_KVM_API_MAGIC, __pa(para_state), 0)) { > > > > + printk(KERN_INFO "KVM guest: WRMSR probe failed.\n"); > > > > + return -ENOENT; > > > > + } > > > > > > How about printk(KERN_INFO "I am not a KVM guest\n");? > > > > Actually paravirt probes that fail should be silent; similar like > > drivers that don't find their hardware should do the same. Otherwise > > if there are later distro kernels with various of those compiled in > > the boot log would become quite noisy > > yeah. I suspect printing that it's executing in native mode is OK. But only a single printk for that please -Andi ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/